From: Pekka Paalanen <ppaalanen@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: Sebastian Wick <sebastian.wick@redhat.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
Uma Shankar <uma.shankar@intel.com>,
Vitaly.Prosyak@amd.com, Joshua Ashton <joshua@froggi.es>
Subject: Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum
Date: Fri, 10 Feb 2023 11:37:38 +0200 [thread overview]
Message-ID: <20230210113738.38ecda93@eldfell> (raw)
In-Reply-To: <hlhk2_vNweAm7d8c2FK8GlUEi1-JHOZTU2W8unUHLoyTtyjXQnnAoGur8KqYgrbw6nsP9Yy91k8OzgiP1k_zwIX4JB0Qt5W178zqOgHilZY=@emersion.fr>
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
On Thu, 09 Feb 2023 17:03:19 +0000
Simon Ser <contact@emersion.fr> wrote:
> On Thursday, February 9th, 2023 at 17:38, Joshua Ashton <joshua@froggi.es> wrote:
>
> > > I mean, the strings are the uAPI, not the integers, right?
> >
> > Both are uAPI these days.
>
> Yes. The integers are uAPI, if you change them you'll break libliftoff
> users. There is an old thread discussing this somewhere. The tl;dr was
> that there is no use-case for exposing the same string with a different
> integer, so no good reason to justify the substantial complexity of
> handling this case.
Funny, I remember exactly the opposite.
This case would have been multiple different strings with the same
integer, anyway.
But no matter. If a uAPI header or documentation has exposed the
integers, then there is no taking that back.
This won't be a problem for enums that have no meaningful string names,
like enums where the integer names a blob that describes what the value
means, and enums where the integer is an index into an array of
descriptions exposed as a blob.
Thanks,
pq
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-10 9:37 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 2:07 [PATCH 1/3] drm/connector: Convert DRM_MODE_COLORIMETRY to enum Joshua Ashton
2023-02-03 2:07 ` Joshua Ashton
2023-02-03 2:07 ` [PATCH 2/3] drm/connector: Add enum documentation to drm_colorspace Joshua Ashton
2023-02-03 2:07 ` Joshua Ashton
2023-02-08 8:56 ` Pekka Paalanen
2023-02-08 8:56 ` Pekka Paalanen
2023-02-16 21:22 ` Harry Wentland
2023-02-16 21:22 ` Harry Wentland
2023-02-03 2:07 ` [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum Joshua Ashton
2023-02-03 2:07 ` Joshua Ashton
2023-02-03 10:39 ` Ville Syrjälä
2023-02-03 12:59 ` Sebastian Wick
2023-02-03 13:35 ` Ville Syrjälä
2023-02-03 13:52 ` Sebastian Wick
2023-02-03 14:02 ` Ville Syrjälä
2023-02-08 9:18 ` Pekka Paalanen
2023-02-08 14:49 ` Ville Syrjälä
2023-02-09 10:05 ` Pekka Paalanen
2023-02-09 10:05 ` Pekka Paalanen
2023-02-03 14:39 ` Harry Wentland
2023-02-03 15:19 ` Ville Syrjälä
2023-02-03 15:24 ` Harry Wentland
2023-02-03 16:00 ` Ville Syrjälä
2023-02-03 18:28 ` Harry Wentland
2023-02-03 18:56 ` Ville Syrjälä
2023-02-03 19:16 ` Harry Wentland
2023-02-03 19:25 ` Ville Syrjälä
2023-02-03 19:33 ` Harry Wentland
2023-02-08 10:03 ` Pekka Paalanen
2023-02-08 10:03 ` Pekka Paalanen
2023-02-03 19:34 ` Ville Syrjälä
2023-02-03 19:43 ` Harry Wentland
2023-02-04 6:09 ` Joshua Ashton
2023-02-06 9:47 ` Ville Syrjälä
2023-02-06 9:47 ` Ville Syrjälä
2023-02-06 17:16 ` Harry Wentland
2023-02-08 10:32 ` Pekka Paalanen
2023-02-08 10:32 ` Pekka Paalanen
2023-02-08 9:30 ` Pekka Paalanen
2023-02-08 9:30 ` Pekka Paalanen
2023-02-08 9:25 ` Pekka Paalanen
2023-02-08 9:25 ` Pekka Paalanen
2023-02-14 15:49 ` Sebastian Wick
2023-02-14 15:49 ` Sebastian Wick
2023-02-14 16:56 ` Harry Wentland
2023-02-14 19:45 ` Sebastian Wick
2023-02-14 19:45 ` Sebastian Wick
2023-02-14 20:04 ` Harry Wentland
2023-02-14 20:04 ` Harry Wentland
2023-02-15 9:40 ` Pekka Paalanen
2023-02-15 9:40 ` Pekka Paalanen
2023-02-15 20:45 ` Harry Wentland
2023-02-15 20:45 ` Harry Wentland
2023-02-14 20:10 ` Ville Syrjälä
2023-02-14 20:10 ` Ville Syrjälä
2023-02-14 21:18 ` Sebastian Wick
2023-02-14 21:18 ` Sebastian Wick
2023-02-14 21:27 ` Ville Syrjälä
2023-02-14 21:27 ` Ville Syrjälä
2023-02-15 10:01 ` Pekka Paalanen
2023-02-15 10:01 ` Pekka Paalanen
2023-02-15 10:33 ` Ville Syrjälä
2023-02-15 10:33 ` Ville Syrjälä
2023-02-15 11:46 ` Daniel Stone
2023-02-15 11:46 ` Daniel Stone
2023-02-15 20:54 ` Harry Wentland
2023-02-15 20:54 ` Harry Wentland
2023-02-15 22:07 ` Daniel Stone
2023-02-15 22:07 ` Daniel Stone
2023-02-03 14:52 ` Harry Wentland
2023-02-04 16:06 ` kernel test robot
2023-02-04 16:06 ` kernel test robot
2023-02-08 9:30 ` Pekka Paalanen
2023-02-08 9:30 ` Pekka Paalanen
2023-02-09 16:38 ` Joshua Ashton
2023-02-09 16:38 ` Joshua Ashton
2023-02-09 17:03 ` Simon Ser
2023-02-09 18:08 ` Ville Syrjälä
2023-02-10 9:37 ` Pekka Paalanen [this message]
2023-02-10 9:44 ` Simon Ser
2023-02-04 9:06 ` [PATCH 1/3] drm/connector: Convert DRM_MODE_COLORIMETRY to enum kernel test robot
2023-02-04 9:06 ` kernel test robot
2023-02-04 10:28 ` kernel test robot
2023-02-04 10:28 ` kernel test robot
2023-02-08 8:29 ` Pekka Paalanen
2023-02-08 8:29 ` Pekka Paalanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210113738.38ecda93@eldfell \
--to=ppaalanen@gmail.com \
--cc=Vitaly.Prosyak@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=joshua@froggi.es \
--cc=sebastian.wick@redhat.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.