From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0DF9C05027 for ; Fri, 10 Feb 2023 12:45:24 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.493401.763349 (Exim 4.92) (envelope-from ) id 1pQSlr-0003W3-MO; Fri, 10 Feb 2023 12:44:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493401.763349; Fri, 10 Feb 2023 12:44:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSlr-0003Vw-JV; Fri, 10 Feb 2023 12:44:55 +0000 Received: by outflank-mailman (input) for mailman id 493401; Fri, 10 Feb 2023 12:44:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSlq-0003Vh-9S for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 12:44:54 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3056868-a940-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 13:44:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 462F62015B; Fri, 10 Feb 2023 13:44:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h12om-dWo-29; Fri, 10 Feb 2023 13:44:46 +0100 (CET) Received: from begin (p-gweduroam01.u-bordeaux.fr [147.210.179.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EB59120158; Fri, 10 Feb 2023 13:44:45 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQSlg-005qZZ-0w; Fri, 10 Feb 2023 13:44:44 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3056868-a940-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 13:44:44 +0100 From: Samuel Thibault To: Juergen Gross Cc: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Message-ID: <20230210124444.bc7siuuj5dwgf3pb@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit: > On 10.02.23 12:43, Andrew Cooper wrote: > > On 10/02/2023 10:46 am, Juergen Gross wrote: > > > diff --git a/lib/sys.c b/lib/sys.c > > > index 2f33c937..dc8a8c69 100644 > > > --- a/lib/sys.c > > > +++ b/lib/sys.c > > > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > > > return fd; > > > } > > > -static struct mount_point mount_points[] = { > > > +#ifdef CONFIG_CONSFRONT > > > +#define STATIC_MNTS 4 > > > +#else > > > +#define STATIC_MNTS 2 > > > +#endif > > > > This ought to be > > > > #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) > > > > because it shows where the parts come from, and is much cleaner to add a > > 3rd one to in due course. > > In principle fine, but I'm not sure it is worth the effort to add > IS_ENABLED() support to Mini-OS. > > > That said, it would be simpler to just have a total mounts set at 16 or > > so?  Does a difference of two dynamic mounts depending on CONSFRONT > > actually matter? > > Probably not. Samuel, any thoughts on that? We can probably as well just have 16 mount entries indeed. Samuel