From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FCCA7F4 for ; Fri, 10 Feb 2023 04:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676004503; x=1707540503; h=date:from:to:cc:subject:message-id:mime-version; bh=HB0vY/V7mbYbh/ZeWdGJxFDA/CH/YlFdtRAf+AvDehw=; b=FNzs0YvsF9egPtRqZX+5BKA8cvsrrx+XaSSaP6C8alp1wMejeXgQs7Bf NnE0xf24b2wuff50RlrkzuV/c+tIFb6c9A2z4scDVutWngB5Yrtj5Qr+q YlDFINOb2ZSfsymhh0lafoC+XHWL3ni8liRFFJjwW8HT37Gqd1YR1YVD/ ju/IOGvV8NUGGrqag45gwnMR/WlNzTAoeEA9bVaAkMvaCU247xYf7m+0K A6aE9Y6q0FHu/2N+g1K9HEkdMk1h/hNdQr4uASaIQiDM1whexNvmVm/6D TVro+IMwwoGAjkDwynq5JD1oErprGR+mEXI3v4+sV2pnTGq/SXUfhYgum g==; X-IronPort-AV: E=McAfee;i="6500,9779,10616"; a="416562067" X-IronPort-AV: E=Sophos;i="5.97,285,1669104000"; d="scan'208";a="416562067" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2023 20:48:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10616"; a="756656859" X-IronPort-AV: E=Sophos;i="5.97,285,1669104000"; d="scan'208";a="756656859" Received: from lkp-server01.sh.intel.com (HELO 4455601a8d94) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 09 Feb 2023 20:48:21 -0800 Received: from kbuild by 4455601a8d94 with local (Exim 4.96) (envelope-from ) id 1pQLKe-0005Ym-22; Fri, 10 Feb 2023 04:48:20 +0000 Date: Fri, 10 Feb 2023 12:47:39 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/net/ethernet/sfc/tc_bindings.c:90 efx_tc_setup_block() warn: passing a valid pointer to 'PTR_ERR' Message-ID: <202302101258.5EKZjIX8-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Edward Cree tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 38c1e0c65865426676123cc9a127526fa02bcac6 commit: 9dc0cad203ab57efac34e6bcb67635edf3b62ebf sfc: bind blocks for TC offload on EF100 date: 5 months ago :::::: branch date: 3 hours ago :::::: commit date: 5 months ago config: parisc-randconfig-m031-20230209 (https://download.01.org/0day-ci/archive/20230210/202302101258.5EKZjIX8-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Link: https://lore.kernel.org/r/202302101258.5EKZjIX8-lkp@intel.com/ smatch warnings: drivers/net/ethernet/sfc/tc_bindings.c:90 efx_tc_setup_block() warn: passing a valid pointer to 'PTR_ERR' vim +/PTR_ERR +90 drivers/net/ethernet/sfc/tc_bindings.c 9dc0cad203ab57e Edward Cree 2022-09-26 72 9dc0cad203ab57e Edward Cree 2022-09-26 73 int efx_tc_setup_block(struct net_device *net_dev, struct efx_nic *efx, 9dc0cad203ab57e Edward Cree 2022-09-26 74 struct flow_block_offload *tcb, struct efx_rep *efv) 9dc0cad203ab57e Edward Cree 2022-09-26 75 { 9dc0cad203ab57e Edward Cree 2022-09-26 76 struct efx_tc_block_binding *binding; 9dc0cad203ab57e Edward Cree 2022-09-26 77 struct flow_block_cb *block_cb; 9dc0cad203ab57e Edward Cree 2022-09-26 78 int rc; 9dc0cad203ab57e Edward Cree 2022-09-26 79 9dc0cad203ab57e Edward Cree 2022-09-26 80 if (tcb->binder_type != FLOW_BLOCK_BINDER_TYPE_CLSACT_INGRESS) 9dc0cad203ab57e Edward Cree 2022-09-26 81 return -EOPNOTSUPP; 9dc0cad203ab57e Edward Cree 2022-09-26 82 9dc0cad203ab57e Edward Cree 2022-09-26 83 if (WARN_ON(!efx->tc)) 9dc0cad203ab57e Edward Cree 2022-09-26 84 return -ENETDOWN; 9dc0cad203ab57e Edward Cree 2022-09-26 85 9dc0cad203ab57e Edward Cree 2022-09-26 86 switch (tcb->command) { 9dc0cad203ab57e Edward Cree 2022-09-26 87 case FLOW_BLOCK_BIND: 9dc0cad203ab57e Edward Cree 2022-09-26 88 binding = efx_tc_create_binding(efx, efv, net_dev, tcb->block); 9dc0cad203ab57e Edward Cree 2022-09-26 89 if (IS_ERR(binding)) 9dc0cad203ab57e Edward Cree 2022-09-26 @90 return PTR_ERR(binding); 9dc0cad203ab57e Edward Cree 2022-09-26 91 block_cb = flow_block_cb_alloc(efx_tc_block_cb, binding, 9dc0cad203ab57e Edward Cree 2022-09-26 92 binding, efx_tc_block_unbind); 9dc0cad203ab57e Edward Cree 2022-09-26 93 rc = PTR_ERR_OR_ZERO(block_cb); 9dc0cad203ab57e Edward Cree 2022-09-26 94 netif_dbg(efx, drv, efx->net_dev, 9dc0cad203ab57e Edward Cree 2022-09-26 95 "bind %sdirect block for device %s, rc %d\n", 9dc0cad203ab57e Edward Cree 2022-09-26 96 net_dev == efx->net_dev ? "" : 9dc0cad203ab57e Edward Cree 2022-09-26 97 efv ? "semi" : "in", 9dc0cad203ab57e Edward Cree 2022-09-26 98 net_dev ? net_dev->name : NULL, rc); 9dc0cad203ab57e Edward Cree 2022-09-26 99 if (rc) { 9dc0cad203ab57e Edward Cree 2022-09-26 100 list_del(&binding->list); 9dc0cad203ab57e Edward Cree 2022-09-26 101 kfree(binding); 9dc0cad203ab57e Edward Cree 2022-09-26 102 } else { 9dc0cad203ab57e Edward Cree 2022-09-26 103 flow_block_cb_add(block_cb, tcb); 9dc0cad203ab57e Edward Cree 2022-09-26 104 } 9dc0cad203ab57e Edward Cree 2022-09-26 105 return rc; 9dc0cad203ab57e Edward Cree 2022-09-26 106 case FLOW_BLOCK_UNBIND: 9dc0cad203ab57e Edward Cree 2022-09-26 107 binding = efx_tc_find_binding(efx, net_dev); 9dc0cad203ab57e Edward Cree 2022-09-26 108 if (binding) { 9dc0cad203ab57e Edward Cree 2022-09-26 109 block_cb = flow_block_cb_lookup(tcb->block, 9dc0cad203ab57e Edward Cree 2022-09-26 110 efx_tc_block_cb, 9dc0cad203ab57e Edward Cree 2022-09-26 111 binding); 9dc0cad203ab57e Edward Cree 2022-09-26 112 if (block_cb) { 9dc0cad203ab57e Edward Cree 2022-09-26 113 flow_block_cb_remove(block_cb, tcb); 9dc0cad203ab57e Edward Cree 2022-09-26 114 netif_dbg(efx, drv, efx->net_dev, 9dc0cad203ab57e Edward Cree 2022-09-26 115 "unbound %sdirect block for device %s\n", 9dc0cad203ab57e Edward Cree 2022-09-26 116 net_dev == efx->net_dev ? "" : 9dc0cad203ab57e Edward Cree 2022-09-26 117 binding->efv ? "semi" : "in", 9dc0cad203ab57e Edward Cree 2022-09-26 118 net_dev ? net_dev->name : NULL); 9dc0cad203ab57e Edward Cree 2022-09-26 119 return 0; 9dc0cad203ab57e Edward Cree 2022-09-26 120 } 9dc0cad203ab57e Edward Cree 2022-09-26 121 } 9dc0cad203ab57e Edward Cree 2022-09-26 122 /* If we're in driver teardown, then we expect to have 9dc0cad203ab57e Edward Cree 2022-09-26 123 * already unbound all our blocks (we did it early while 9dc0cad203ab57e Edward Cree 2022-09-26 124 * we still had MCDI to remove the filters), so getting 9dc0cad203ab57e Edward Cree 2022-09-26 125 * unbind callbacks now isn't a problem. 9dc0cad203ab57e Edward Cree 2022-09-26 126 */ 9dc0cad203ab57e Edward Cree 2022-09-26 127 netif_cond_dbg(efx, drv, efx->net_dev, 9dc0cad203ab57e Edward Cree 2022-09-26 128 !efx->tc->up, warn, 9dc0cad203ab57e Edward Cree 2022-09-26 129 "%sdirect block unbind for device %s, was never bound\n", 9dc0cad203ab57e Edward Cree 2022-09-26 130 net_dev == efx->net_dev ? "" : "in", 9dc0cad203ab57e Edward Cree 2022-09-26 131 net_dev ? net_dev->name : NULL); 9dc0cad203ab57e Edward Cree 2022-09-26 132 return -ENOENT; 9dc0cad203ab57e Edward Cree 2022-09-26 133 default: 9dc0cad203ab57e Edward Cree 2022-09-26 134 return -EOPNOTSUPP; 9dc0cad203ab57e Edward Cree 2022-09-26 135 } 9dc0cad203ab57e Edward Cree 2022-09-26 136 } 9dc0cad203ab57e Edward Cree 2022-09-26 137 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests