From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B91CC636D3 for ; Fri, 10 Feb 2023 12:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231684AbjBJM1I (ORCPT ); Fri, 10 Feb 2023 07:27:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjBJM1G (ORCPT ); Fri, 10 Feb 2023 07:27:06 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB26020077; Fri, 10 Feb 2023 04:27:04 -0800 (PST) Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B9FD6C0005; Fri, 10 Feb 2023 12:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676032023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=onC4uvSvom/UzAuHfG54ufV5S11DPr9PwQEDZQSvD/8=; b=D17I3QpQS2PBGfHhv5YdbROETUA+7fAsoT6dg4Br3BNDYs78m2tMntxVZ4/F4ORHBm3MsM PIxxe/dJ5MIrm7A7GSeYLl86oQ1yY8FGQNrFQwYK/8psH5xalF7vexhDY3Ng4kw5Ytg/m7 HHEFHly7quw+bfnMAu9Mt9duRki+Zl3+gbq7slWurMCNlLQIWNOgcGP1uV13SmIf4YY+ks WDZtzKrqM1zSksFoZFCSRkukqAPo0gNjir4+3putED9OScnNes0Qh2HFOHI4yocR6HATB6 udOEiLkIiwedm2twRteLedmCkJerZ3qruz6KSSwKAgrhAeWvN3vWwMFVtYLYtg== Date: Fri, 10 Feb 2023 13:29:21 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Krzysztof Kozlowski Cc: Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , Wong Vee Khee , Kurt Kanzenbach , Revanth Kumar Uppala , Tan Tee Min , Thomas Petazzoni , Herve Codina , =?UTF-8?B?TWlxdcOobA==?= Raynal , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Mohammad Athari Bin Ismail , Jon Hunter , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 4/6] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support Message-ID: <20230210132921.2d6ab6a0@fixe.home> In-Reply-To: References: <20230209151632.275883-1-clement.leger@bootlin.com> <20230209151632.275883-5-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Le Fri, 10 Feb 2023 13:01:01 +0100, Krzysztof Kozlowski a =C3=A9crit : > On 09/02/2023 16:16, Cl=C3=A9ment L=C3=A9ger wrote: > > Add "renesas,rzn1-gmac" binding documentation which is compatible with > > "snps,dwmac" compatible driver but uses a custom PCS to communicate > > with the phy. > >=20 > > Signed-off-by: Cl=C3=A9ment L=C3=A9ger > > --- > > .../bindings/net/renesas,rzn1-gmac.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/renesas,rzn1-= gmac.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.ya= ml b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > new file mode 100644 > > index 000000000000..029ce758a29c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas GMAC > > + > > +maintainers: > > + - Cl=C3=A9ment L=C3=A9ger > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,r9a06g032-gmac > > + - renesas,rzn1-gmac > > + required: > > + - compatible > > + > > +allOf: > > + - $ref: snps,dwmac.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - renesas,r9a06g032-gmac > > + - const: renesas,rzn1-gmac > > + - const: snps,dwmac =20 >=20 > Thanks, looks good now. >=20 > > + > > + pcs-handle: > > + description: > > + phandle pointing to a PCS sub-node compatible with > > + renesas,rzn1-miic.yaml# > > + $ref: /schemas/types.yaml#/definitions/phandle =20 >=20 > you do not need ref here - it is coming from ethernet-controller.yaml > via snps,dwmac.yaml. You actually could drop entire property, but it can > also stay for the description. Ok thanks for the tip. I will drop it since there will be a v4. >=20 > > + > > +required: > > + - compatible > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + ethernet@44000000 { > > + compatible =3D "renesas,r9a06g032-gmac", "renesas,rzn1-gmac", "s= nps,dwmac"; > > + reg =3D <0x44000000 0x2000>; > > + interrupt-parent =3D <&gic>; > > + interrupts =3D , > > + , =20 >=20 > Please align with previous < >=20 >=20 > Best regards, > Krzysztof >=20 --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15F79C05027 for ; Fri, 10 Feb 2023 12:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IUb239LBzAby+Zxg8fHRs9sbnX45+5gWhjUUhzhGKYc=; b=ol2SI2yBk+ug1L ramQvlp5Y6MI4I5TyzTDqr5rxxT4qGSPj9Cd6uVt9kBHkkG5O3kzP4J/sPBt9la9zcL48EZFDBnqR FUFU/W4/QQXTl0wccwwa/XIw5MAdX0Xka/p1DFxsJGxaOQgSULv45zndYgkCWWts6ru6sme2F2M4r 9mGFiE4jB8y9yGUCHLMjTfXMVkZzXqhxW1xJD9Al+p4K0mGQjefUjq9WGyXuIEC9hyRQ8LY0BOzJb npQCBu7xW2erfjNXJwKsT/YZqus/4I0DQwwpMlMyRvJsbDIBXv1m7qAQT1jWUheJItA9yHFm4ENXA bWEcfdhhr3khCYC//z1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQSUh-005fz1-2p; Fri, 10 Feb 2023 12:27:11 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQSUd-005fxy-5s for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 12:27:09 +0000 Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B9FD6C0005; Fri, 10 Feb 2023 12:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676032023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=onC4uvSvom/UzAuHfG54ufV5S11DPr9PwQEDZQSvD/8=; b=D17I3QpQS2PBGfHhv5YdbROETUA+7fAsoT6dg4Br3BNDYs78m2tMntxVZ4/F4ORHBm3MsM PIxxe/dJ5MIrm7A7GSeYLl86oQ1yY8FGQNrFQwYK/8psH5xalF7vexhDY3Ng4kw5Ytg/m7 HHEFHly7quw+bfnMAu9Mt9duRki+Zl3+gbq7slWurMCNlLQIWNOgcGP1uV13SmIf4YY+ks WDZtzKrqM1zSksFoZFCSRkukqAPo0gNjir4+3putED9OScnNes0Qh2HFOHI4yocR6HATB6 udOEiLkIiwedm2twRteLedmCkJerZ3qruz6KSSwKAgrhAeWvN3vWwMFVtYLYtg== Date: Fri, 10 Feb 2023 13:29:21 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Krzysztof Kozlowski Cc: Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , Wong Vee Khee , Kurt Kanzenbach , Revanth Kumar Uppala , Tan Tee Min , Thomas Petazzoni , Herve Codina , =?UTF-8?B?TWlxdcOobA==?= Raynal , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Mohammad Athari Bin Ismail , Jon Hunter , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 4/6] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support Message-ID: <20230210132921.2d6ab6a0@fixe.home> In-Reply-To: References: <20230209151632.275883-1-clement.leger@bootlin.com> <20230209151632.275883-5-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_042707_516761_0307D4CB X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgRnJpLCAxMCBGZWIgMjAyMyAxMzowMTowMSArMDEwMCwKS3J6eXN6dG9mIEtvemxvd3NraSA8 a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPiBhIMOpY3JpdCA6Cgo+IE9uIDA5LzAyLzIw MjMgMTY6MTYsIENsw6ltZW50IEzDqWdlciB3cm90ZToKPiA+IEFkZCAicmVuZXNhcyxyem4xLWdt YWMiIGJpbmRpbmcgZG9jdW1lbnRhdGlvbiB3aGljaCBpcyBjb21wYXRpYmxlIHdpdGgKPiA+ICJz bnBzLGR3bWFjIiBjb21wYXRpYmxlIGRyaXZlciBidXQgdXNlcyBhIGN1c3RvbSBQQ1MgdG8gY29t bXVuaWNhdGUKPiA+IHdpdGggdGhlIHBoeS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQ2zDqW1l bnQgTMOpZ2VyIDxjbGVtZW50LmxlZ2VyQGJvb3RsaW4uY29tPgo+ID4gLS0tCj4gPiAgLi4uL2Jp bmRpbmdzL25ldC9yZW5lc2FzLHJ6bjEtZ21hYy55YW1sICAgICAgIHwgNjcgKysrKysrKysrKysr KysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2NyBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRl IG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvcmVuZXNh cyxyem4xLWdtYWMueWFtbAo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL25ldC9yZW5lc2FzLHJ6bjEtZ21hYy55YW1sIGIvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9yZW5lc2FzLHJ6bjEtZ21hYy55YW1sCj4gPiBuZXcg ZmlsZSBtb2RlIDEwMDY0NAo+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi4wMjljZTc1OGEyOWMKPiA+ IC0tLSAvZGV2L251bGwKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9uZXQvcmVuZXNhcyxyem4xLWdtYWMueWFtbAo+ID4gQEAgLTAsMCArMSw2NyBAQAo+ID4gKyMg U1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wLW9ubHkgT1IgQlNELTItQ2xhdXNlKQo+ ID4gKyVZQU1MIDEuMgo+ID4gKy0tLQo+ID4gKyRpZDogaHR0cDovL2RldmljZXRyZWUub3JnL3Nj aGVtYXMvbmV0L3JlbmVzYXMscnpuMS1nbWFjLnlhbWwjCj4gPiArJHNjaGVtYTogaHR0cDovL2Rl dmljZXRyZWUub3JnL21ldGEtc2NoZW1hcy9jb3JlLnlhbWwjCj4gPiArCj4gPiArdGl0bGU6IFJl bmVzYXMgR01BQwo+ID4gKwo+ID4gK21haW50YWluZXJzOgo+ID4gKyAgLSBDbMOpbWVudCBMw6ln ZXIgPGNsZW1lbnQubGVnZXJAYm9vdGxpbi5jb20+Cj4gPiArCj4gPiArc2VsZWN0Ogo+ID4gKyAg cHJvcGVydGllczoKPiA+ICsgICAgY29tcGF0aWJsZToKPiA+ICsgICAgICBjb250YWluczoKPiA+ ICsgICAgICAgIGVudW06Cj4gPiArICAgICAgICAgIC0gcmVuZXNhcyxyOWEwNmcwMzItZ21hYwo+ ID4gKyAgICAgICAgICAtIHJlbmVzYXMscnpuMS1nbWFjCj4gPiArICByZXF1aXJlZDoKPiA+ICsg ICAgLSBjb21wYXRpYmxlCj4gPiArCj4gPiArYWxsT2Y6Cj4gPiArICAtICRyZWY6IHNucHMsZHdt YWMueWFtbCMKPiA+ICsKPiA+ICtwcm9wZXJ0aWVzOgo+ID4gKyAgY29tcGF0aWJsZToKPiA+ICsg ICAgaXRlbXM6Cj4gPiArICAgICAgLSBlbnVtOgo+ID4gKyAgICAgICAgICAtIHJlbmVzYXMscjlh MDZnMDMyLWdtYWMKPiA+ICsgICAgICAtIGNvbnN0OiByZW5lc2FzLHJ6bjEtZ21hYwo+ID4gKyAg ICAgIC0gY29uc3Q6IHNucHMsZHdtYWMgIAo+IAo+IFRoYW5rcywgbG9va3MgZ29vZCBub3cuCj4g Cj4gPiArCj4gPiArICBwY3MtaGFuZGxlOgo+ID4gKyAgICBkZXNjcmlwdGlvbjoKPiA+ICsgICAg ICBwaGFuZGxlIHBvaW50aW5nIHRvIGEgUENTIHN1Yi1ub2RlIGNvbXBhdGlibGUgd2l0aAo+ID4g KyAgICAgIHJlbmVzYXMscnpuMS1taWljLnlhbWwjCj4gPiArICAgICRyZWY6IC9zY2hlbWFzL3R5 cGVzLnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUgIAo+IAo+IHlvdSBkbyBub3QgbmVlZCByZWYg aGVyZSAtIGl0IGlzIGNvbWluZyBmcm9tIGV0aGVybmV0LWNvbnRyb2xsZXIueWFtbAo+IHZpYSBz bnBzLGR3bWFjLnlhbWwuIFlvdSBhY3R1YWxseSBjb3VsZCBkcm9wIGVudGlyZSBwcm9wZXJ0eSwg YnV0IGl0IGNhbgo+IGFsc28gc3RheSBmb3IgdGhlIGRlc2NyaXB0aW9uLgoKT2sgdGhhbmtzIGZv ciB0aGUgdGlwLiBJIHdpbGwgZHJvcCBpdCBzaW5jZSB0aGVyZSB3aWxsIGJlIGEgdjQuCgo+IAo+ ID4gKwo+ID4gK3JlcXVpcmVkOgo+ID4gKyAgLSBjb21wYXRpYmxlCj4gPiArCj4gPiArdW5ldmFs dWF0ZWRQcm9wZXJ0aWVzOiBmYWxzZQo+ID4gKwo+ID4gK2V4YW1wbGVzOgo+ID4gKyAgLSB8Cj4g PiArICAgICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9jbG9jay9yOWEwNmcwMzItc3lzY3RybC5oPgo+ ID4gKyAgICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvYXJtLWdp Yy5oPgo+ID4gKwo+ID4gKyAgICBldGhlcm5ldEA0NDAwMDAwMCB7Cj4gPiArICAgICAgY29tcGF0 aWJsZSA9ICJyZW5lc2FzLHI5YTA2ZzAzMi1nbWFjIiwgInJlbmVzYXMscnpuMS1nbWFjIiwgInNu cHMsZHdtYWMiOwo+ID4gKyAgICAgIHJlZyA9IDwweDQ0MDAwMDAwIDB4MjAwMD47Cj4gPiArICAg ICAgaW50ZXJydXB0LXBhcmVudCA9IDwmZ2ljPjsKPiA+ICsgICAgICBpbnRlcnJ1cHRzID0gPEdJ Q19TUEkgMzQgSVJRX1RZUEVfTEVWRUxfSElHSD4sCj4gPiArICAgICAgICAgICAgIDxHSUNfU1BJ IDM2IElSUV9UWVBFX0xFVkVMX0hJR0g+LCAgCj4gCj4gUGxlYXNlIGFsaWduIHdpdGggcHJldmlv dXMgPAo+IAo+IAo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKPiAKCgoKLS0gCkNsw6ltZW50 IEzDqWdlciwKRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlciBhdCBCb290bGluCmh0 dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK