From: Vinayak Dev <vinayakdev.sci@gmail.com>
To: sunshine@sunshineco.com
Cc: git@vger.kernel.org, Vinayak Dev <vinayakdev.sci@gmail.com>
Subject: [PATCH v2 2/3] {apply,alias}: convert pre-processor macros to enums
Date: Fri, 10 Feb 2023 22:43:37 +0530 [thread overview]
Message-ID: <20230210171338.81906-3-vinayakdev.sci@gmail.com> (raw)
In-Reply-To: <20230210171338.81906-1-vinayakdev.sci@gmail.com>
Revert the changes made to alias.c in v1.
Signed-off-by: Vinayak Dev <vinayakdev.sci@gmail.com>
---
alias.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/alias.c b/alias.c
index 61ef2c0c54..deb871d59c 100644
--- a/alias.c
+++ b/alias.c
@@ -44,14 +44,9 @@ void list_aliases(struct string_list *list)
read_early_config(config_alias_cb, &data);
}
-/* #define SPLIT_CMDLINE_BAD_ENDING 1 */
-/* #define SPLIT_CMDLINE_UNCLOSED_QUOTE 2 */
-/* #define SPLIT_CMDLINE_ARGC_OVERFLOW 3 */
-enum split_cmdline_error {
- SPLIT_CMDLINE_BAD_ENDING = 1,
- SPLIT_CMDLINE_UNCLOSED_QUOTE,
- SPLIT_CMDLINE_ARGC_OVERFLOW
-};
+#define SPLIT_CMDLINE_BAD_ENDING 1
+#define SPLIT_CMDLINE_UNCLOSED_QUOTE 2
+#define SPLIT_CMDLINE_ARGC_OVERFLOW 3
static const char *split_cmdline_errors[] = {
N_("cmdline ends with \\"),
--
2.39.1
next prev parent reply other threads:[~2023-02-10 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 17:13 [PATCH v2 0/3] {apply,alias}: convert pre-processor macros to enums Vinayak Dev
2023-02-10 17:13 ` [PATCH v2 1/3] " Vinayak Dev
2023-02-10 17:13 ` Vinayak Dev [this message]
2023-02-10 17:13 ` [PATCH v2 3/3] " Vinayak Dev
2023-02-10 22:01 ` [PATCH v2 0/3] " Junio C Hamano
2023-02-11 4:00 ` Vinayak Dev
2023-02-15 0:04 ` Eric Sunshine
2023-02-15 8:19 ` Vinayak Dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210171338.81906-3-vinayakdev.sci@gmail.com \
--to=vinayakdev.sci@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.