From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/pkg-waf: add missing $
Date: Sat, 11 Feb 2023 11:04:28 +0100 [thread overview]
Message-ID: <20230211100428.GE2796@scaer> (raw)
In-Reply-To: <20230211094202.3816592-1-romain.naour@gmail.com>
Romain, All,
On 2023-02-11 10:42 +0100, Romain Naour spake thusly:
> We want to have $(@D) expanded at the time the recipe is run, so like
> all other variables, we need to $$-expand it.
>
> Fixes:
> http://autobuild.buildroot.org/results/b6f/b6fd3a866af182edc7831492aecc8323f377b826
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <peter@korsgaard.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/pkg-waf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-waf.mk b/package/pkg-waf.mk
> index 0e752072c8..c3e965bdf3 100644
> --- a/package/pkg-waf.mk
> +++ b/package/pkg-waf.mk
> @@ -42,7 +42,7 @@ define inner-waf-package
> # otherwise waf errors out with:
> # Waf script 'X' and library 'Y' do not match
> define WAF_PACKAGE_REMOVE_WAF_LIB
> - $(RM) -fr $(@D)/waf $(@D)/waflib
> + $(RM) -fr $$(@D)/waf $$(@D)/waflib
> endef
>
> # We need host-python3 to run waf
> --
> 2.34.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-11 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 9:42 [Buildroot] [PATCH] package/pkg-waf: add missing $ Romain Naour
2023-02-11 9:51 ` Yann E. MORIN
2023-02-11 9:57 ` Romain Naour
2023-02-11 10:04 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230211100428.GE2796@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.