From: kernel test robot <lkp@intel.com>
To: Harsh Jain <h.jain@amd.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, thomas.lendacky@amd.com, Raju.Rangoju@amd.com,
Shyam-sundar.S-k@amd.com, harshjain.prof@gmail.com,
abhijit.gangurde@amd.com, puneet.gupta@amd.com,
nikhil.agarwal@amd.com, tarak.reddy@amd.com,
netdev@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Harsh Jain <h.jain@amd.com>
Subject: Re: [PATCH 6/6] net: ethernet: efct: Add maintainer, kconfig, makefile
Date: Sat, 11 Feb 2023 11:32:57 +0800 [thread overview]
Message-ID: <202302111128.JPr7UbtM-lkp@intel.com> (raw)
In-Reply-To: <20230210130321.2898-7-h.jain@amd.com>
Hi Harsh,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master horms-ipvs/master linus/master v6.2-rc7 next-20230210]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Harsh-Jain/net-ethernet-efct-New-X3-net-driver/20230210-210711
patch link: https://lore.kernel.org/r/20230210130321.2898-7-h.jain%40amd.com
patch subject: [PATCH 6/6] net: ethernet: efct: Add maintainer, kconfig, makefile
config: mips-db1xxx_defconfig (https://download.01.org/0day-ci/archive/20230211/202302111128.JPr7UbtM-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/93ed306161ac0259bd72b14922a7f6af60b3748c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Harsh-Jain/net-ethernet-efct-New-X3-net-driver/20230210-210711
git checkout 93ed306161ac0259bd72b14922a7f6af60b3748c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/ethernet/amd/efct/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302111128.JPr7UbtM-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/net/ethernet/amd/efct/mcdi_functions.c: In function 'efct_mcdi_filter_table_probe':
>> drivers/net/ethernet/amd/efct/mcdi_functions.c:283:24: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
283 | table->entry = vzalloc(EFCT_MCDI_FILTER_TBL_ROWS *
| ^~~~~~~
| kvzalloc
>> drivers/net/ethernet/amd/efct/mcdi_functions.c:283:22: warning: assignment to 'struct <anonymous> *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
283 | table->entry = vzalloc(EFCT_MCDI_FILTER_TBL_ROWS *
| ^
drivers/net/ethernet/amd/efct/mcdi_functions.c: In function 'efct_mcdi_filter_table_remove':
>> drivers/net/ethernet/amd/efct/mcdi_functions.c:309:9: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
309 | vfree(table->entry);
| ^~~~~
| kfree
cc1: some warnings being treated as errors
vim +283 drivers/net/ethernet/amd/efct/mcdi_functions.c
83f06a5b784384c Harsh Jain 2023-02-10 267
83f06a5b784384c Harsh Jain 2023-02-10 268 int efct_mcdi_filter_table_probe(struct efct_nic *efct)
83f06a5b784384c Harsh Jain 2023-02-10 269 {
83f06a5b784384c Harsh Jain 2023-02-10 270 struct efct_mcdi_filter_table *table;
83f06a5b784384c Harsh Jain 2023-02-10 271 int rc = 0, i;
83f06a5b784384c Harsh Jain 2023-02-10 272
83f06a5b784384c Harsh Jain 2023-02-10 273 if (efct->filter_table) /* already probed */
83f06a5b784384c Harsh Jain 2023-02-10 274 return rc;
83f06a5b784384c Harsh Jain 2023-02-10 275
83f06a5b784384c Harsh Jain 2023-02-10 276 table = kzalloc(sizeof(*table), GFP_KERNEL);
83f06a5b784384c Harsh Jain 2023-02-10 277 if (!table)
83f06a5b784384c Harsh Jain 2023-02-10 278 return -ENOMEM;
83f06a5b784384c Harsh Jain 2023-02-10 279
83f06a5b784384c Harsh Jain 2023-02-10 280 efct->filter_table = table;
83f06a5b784384c Harsh Jain 2023-02-10 281
83f06a5b784384c Harsh Jain 2023-02-10 282 init_rwsem(&table->lock);
83f06a5b784384c Harsh Jain 2023-02-10 @283 table->entry = vzalloc(EFCT_MCDI_FILTER_TBL_ROWS *
83f06a5b784384c Harsh Jain 2023-02-10 284 sizeof(*table->entry));
83f06a5b784384c Harsh Jain 2023-02-10 285 if (!table->entry) {
83f06a5b784384c Harsh Jain 2023-02-10 286 rc = -ENOMEM;
83f06a5b784384c Harsh Jain 2023-02-10 287 return rc;
83f06a5b784384c Harsh Jain 2023-02-10 288 }
83f06a5b784384c Harsh Jain 2023-02-10 289
83f06a5b784384c Harsh Jain 2023-02-10 290 for (i = 0; i < EFCT_MCDI_FILTER_TBL_ROWS; i++) {
83f06a5b784384c Harsh Jain 2023-02-10 291 table->entry[i].handle = EFCT_HANDLE_INVALID;
83f06a5b784384c Harsh Jain 2023-02-10 292 table->entry[i].ref_cnt = 0;
83f06a5b784384c Harsh Jain 2023-02-10 293 }
83f06a5b784384c Harsh Jain 2023-02-10 294
83f06a5b784384c Harsh Jain 2023-02-10 295 return rc;
83f06a5b784384c Harsh Jain 2023-02-10 296 }
83f06a5b784384c Harsh Jain 2023-02-10 297
83f06a5b784384c Harsh Jain 2023-02-10 298 void efct_mcdi_filter_table_remove(struct efct_nic *efct)
83f06a5b784384c Harsh Jain 2023-02-10 299 {
83f06a5b784384c Harsh Jain 2023-02-10 300 struct efct_mcdi_filter_table *table = efct->filter_table;
83f06a5b784384c Harsh Jain 2023-02-10 301 int i;
83f06a5b784384c Harsh Jain 2023-02-10 302
83f06a5b784384c Harsh Jain 2023-02-10 303 if (!table)
83f06a5b784384c Harsh Jain 2023-02-10 304 return;
83f06a5b784384c Harsh Jain 2023-02-10 305 for (i = 0; i < EFCT_MCDI_FILTER_TBL_ROWS; i++) {
83f06a5b784384c Harsh Jain 2023-02-10 306 if (table->entry[i].spec)
83f06a5b784384c Harsh Jain 2023-02-10 307 kfree((struct efct_filter_spec *)table->entry[i].spec);
83f06a5b784384c Harsh Jain 2023-02-10 308 }
83f06a5b784384c Harsh Jain 2023-02-10 @309 vfree(table->entry);
83f06a5b784384c Harsh Jain 2023-02-10 310 table->entry = NULL;
83f06a5b784384c Harsh Jain 2023-02-10 311 efct->filter_table = NULL;
83f06a5b784384c Harsh Jain 2023-02-10 312 kfree(table);
83f06a5b784384c Harsh Jain 2023-02-10 313 }
83f06a5b784384c Harsh Jain 2023-02-10 314
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-11 3:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 13:03 [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver Harsh Jain
2023-02-10 13:03 ` [PATCH 1/6] net: ethernet: efct: New X3 net driver Harsh Jain
2023-02-10 17:00 ` Simon Horman
2023-02-10 13:03 ` [PATCH 2/6] net: ethernet: efct: Add datapath Harsh Jain
2023-02-10 13:03 ` [PATCH 3/6] net: ethernet: efct: Add devlink support Harsh Jain
2023-02-10 13:03 ` [PATCH 4/6] net: ethernet: efct: Add Hardware timestamp support Harsh Jain
2023-02-10 13:03 ` [PATCH 5/6] net: ethernet: efct: Add ethtool support Harsh Jain
2023-02-11 17:05 ` Andrew Lunn
2023-02-10 13:03 ` [PATCH 6/6] net: ethernet: efct: Add maintainer, kconfig, makefile Harsh Jain
2023-02-11 3:32 ` kernel test robot [this message]
2023-02-11 6:36 ` kernel test robot
2023-02-11 13:55 ` kernel test robot
2023-02-13 17:02 ` kernel test robot
2023-02-14 12:25 ` kernel test robot
2023-02-10 19:22 ` [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver Jakub Kicinski
2023-05-09 5:30 ` Jain, Harsh (DCG-ENG)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302111128.JPr7UbtM-lkp@intel.com \
--to=lkp@intel.com \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=h.jain@amd.com \
--cc=harshjain.prof@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=puneet.gupta@amd.com \
--cc=tarak.reddy@amd.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.