From: Oz Shlomo <ozsh@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Roi Dayan <roid@nvidia.com>,
"Jiri Pirko" <jiri@nvidia.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
"Simon Horman" <simon.horman@corigine.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Oz Shlomo <ozsh@nvidia.com>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>
Subject: [PATCH net-next v4 2/9] net/sched: act_pedit, setup offload action for action stats query
Date: Sun, 12 Feb 2023 15:25:13 +0200 [thread overview]
Message-ID: <20230212132520.12571-3-ozsh@nvidia.com> (raw)
In-Reply-To: <20230212132520.12571-1-ozsh@nvidia.com>
A single tc pedit action may be translated to multiple flow_offload
actions.
Offload only actions that translate to a single pedit command value.
Signed-off-by: Oz Shlomo <ozsh@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
Change log:
V1 -> V2:
- Add extack message on error
- Assign the flow action id outside the for loop.
Ensure the rest of the pedit actions follow the assigned id.
V2 -> V3:
- Fix last_cmd initialization
V3 -> V4:
- Compare all action types to the first action
---
net/sched/act_pedit.c | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index c42fcc47dd6d..35ebe5d5c261 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -545,7 +545,28 @@ static int tcf_pedit_offload_act_setup(struct tc_action *act, void *entry_data,
}
*index_inc = k;
} else {
- return -EOPNOTSUPP;
+ struct flow_offload_action *fl_action = entry_data;
+ u32 cmd = tcf_pedit_cmd(act, 0);
+ int k;
+
+ switch (cmd) {
+ case TCA_PEDIT_KEY_EX_CMD_SET:
+ fl_action->id = FLOW_ACTION_MANGLE;
+ break;
+ case TCA_PEDIT_KEY_EX_CMD_ADD:
+ fl_action->id = FLOW_ACTION_ADD;
+ break;
+ default:
+ NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
+ return -EOPNOTSUPP;
+ }
+
+ for (k = 1; k < tcf_pedit_nkeys(act); k++) {
+ if (cmd != tcf_pedit_cmd(act, k)) {
+ NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
+ return -EOPNOTSUPP;
+ }
+ }
}
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2023-02-12 13:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 13:25 [PATCH net-next v4 0/9] add support for per action hw stats Oz Shlomo
2023-02-12 13:25 ` [PATCH net-next v4 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-12 14:58 ` Jamal Hadi Salim
2023-02-12 13:25 ` Oz Shlomo [this message]
2023-02-12 14:59 ` [PATCH net-next v4 2/9] net/sched: act_pedit, setup offload action for action stats query Jamal Hadi Salim
2023-02-12 13:25 ` [PATCH net-next v4 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-12 15:01 ` Jamal Hadi Salim
2023-02-12 13:25 ` [PATCH net-next v4 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-12 15:14 ` Jamal Hadi Salim
2023-02-12 13:25 ` [PATCH net-next v4 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-12 15:12 ` Jamal Hadi Salim
2023-02-12 13:25 ` [PATCH net-next v4 6/9] net/mlx5e: TC, add hw counter to branching actions Oz Shlomo
2023-02-12 13:25 ` [PATCH net-next v4 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-12 13:25 ` [PATCH net-next v4 8/9] net/mlx5e: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-12 13:25 ` [PATCH net-next v4 9/9] net/mlx5e: TC, support per action stats Oz Shlomo
2023-02-14 10:20 ` [PATCH net-next v4 0/9] add support for per action hw stats patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230212132520.12571-3-ozsh@nvidia.com \
--to=ozsh@nvidia.com \
--cc=baowen.zheng@corigine.com \
--cc=ecree.xilinx@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.