From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Gonglei Arei <arei.gonglei@huawei.com>, Li Qiang <liq3ea@163.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>, Hu Tao <hutao@cn.fujitsu.com>,
qemu-block@nongnu.org, qemu-ppc@nongnu.org,
xiaoqiang zhao <zxq_yx_007@163.com>
Subject: Re: [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus()
Date: Mon, 13 Feb 2023 05:53:21 -0500 [thread overview]
Message-ID: <20230213055302-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230213070423.76428-1-philmd@linaro.org>
On Mon, Feb 13, 2023 at 08:04:14AM +0100, Philippe Mathieu-Daudé wrote:
> v2: Convert more qdev_get_parent_bus()
>
> DeviceState::parent_bus is an internal field and should be
> accessed by the qdev_get_parent_bus() helper. Replace most uses.
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
who's merging this?
> Philippe Mathieu-Daudé (9):
> hw/qdev: Constify DeviceState* argument of qdev_get_parent_bus()
> hw/audio: Replace dev->parent_bus by qdev_get_parent_bus(dev)
> hw/block: Replace dev->parent_bus by qdev_get_parent_bus(dev)
> hw/net: Replace dev->parent_bus by qdev_get_parent_bus(dev)
> hw/pci: Replace dev->parent_bus by qdev_get_parent_bus(dev)
> hw/ppc: Replace dev->parent_bus by qdev_get_parent_bus(dev)
> hw/usb: Replace dev->parent_bus by qdev_get_parent_bus(dev)
> hw: Use qdev_get_parent_bus() in
> qdev_get_own_fw_dev_path_from_handler()
> qdev-monitor: Use qdev_get_parent_bus() in bus_print_dev()
>
> hw/audio/intel-hda.c | 10 +++++-----
> hw/block/fdc.c | 2 +-
> hw/block/swim.c | 2 +-
> hw/core/qdev-fw.c | 9 +++++----
> hw/core/qdev.c | 2 +-
> hw/ide/qdev.c | 6 +++---
> hw/net/virtio-net.c | 2 +-
> hw/pci-bridge/pci_expander_bridge.c | 2 +-
> hw/ppc/spapr_vio.c | 4 ++--
> hw/scsi/scsi-bus.c | 18 +++++++++---------
> hw/usb/bus.c | 2 +-
> hw/usb/desc.c | 2 +-
> hw/usb/dev-smartcard-reader.c | 16 ++++++++--------
> include/hw/qdev-core.h | 4 ++--
> include/hw/scsi/scsi.h | 2 +-
> include/hw/usb.h | 2 +-
> softmmu/bootdevice.c | 2 +-
> softmmu/qdev-monitor.c | 6 +++---
> 18 files changed, 47 insertions(+), 46 deletions(-)
>
> --
> 2.38.1
>
>
>
next prev parent reply other threads:[~2023-02-13 10:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 7:04 [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus() Philippe Mathieu-Daudé
2023-02-13 7:04 ` [PATCH v2 1/9] hw/qdev: Constify DeviceState* argument of qdev_get_parent_bus() Philippe Mathieu-Daudé
2023-02-13 7:04 ` [PATCH v2 2/9] hw/audio: Replace dev->parent_bus by qdev_get_parent_bus(dev) Philippe Mathieu-Daudé
2023-02-13 7:04 ` [PATCH v2 3/9] hw/block: " Philippe Mathieu-Daudé
2023-02-13 7:04 ` [PATCH v2 4/9] hw/net: " Philippe Mathieu-Daudé
2023-02-13 10:52 ` Michael S. Tsirkin
2023-02-13 7:04 ` [PATCH v2 5/9] hw/pci: " Philippe Mathieu-Daudé
2023-02-13 10:52 ` Michael S. Tsirkin
2023-02-13 7:04 ` [PATCH v2 6/9] hw/ppc: " Philippe Mathieu-Daudé
2023-02-13 7:32 ` Cédric Le Goater
2023-02-13 7:04 ` [PATCH v2 7/9] hw/usb: " Philippe Mathieu-Daudé
2023-02-13 7:04 ` [PATCH v2 8/9] hw: Use qdev_get_parent_bus() in qdev_get_own_fw_dev_path_from_handler() Philippe Mathieu-Daudé
2023-02-13 7:04 ` [PATCH v2 9/9] qdev-monitor: Use qdev_get_parent_bus() in bus_print_dev() Philippe Mathieu-Daudé
2023-02-13 7:09 ` Markus Armbruster
2023-02-13 10:53 ` Michael S. Tsirkin [this message]
2023-02-13 11:07 ` [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213055302-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=eduardo@habkost.net \
--cc=hutao@cn.fujitsu.com \
--cc=liq3ea@163.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.