From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DB2C64ED6 for ; Mon, 13 Feb 2023 10:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbjBMKng (ORCPT ); Mon, 13 Feb 2023 05:43:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbjBMKnX (ORCPT ); Mon, 13 Feb 2023 05:43:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C8F16AD2; Mon, 13 Feb 2023 02:43:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 665BC60FAC; Mon, 13 Feb 2023 10:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1243AC432C5; Mon, 13 Feb 2023 10:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676284997; bh=NTHXrrpZCAJQDbqGQ5Dk1VncIloUIc9A9BrVorjY3xI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CNDlo9Po/2gPGU3zXwvDyv9/xAcEVX0HaRAAkak++yvXs+wbnXKJAwqfv8Rjf8kNR sZWrSmYMDOvaoHQXZV8T5E9O3D9BETt+mQSaoBiCh6YLevccQH9cQ364zNR7fNS8fy vwIUSRfsC0c6of1luL1aP5BvHA/xEmfXI6HnLLJ8KTT9J9IyAL0t4bRRHP9Rjz69BX j5D67N8cbwM5G6JpN/m68eQd4GIIMpcsoH0fm19uTJC7jMyjNmZEa/1IykGpFz6JHq R8j1UxprHjmCavisECqnL+qzza/RdnvFYAZSyJiltkZvj5W77cyft/sXUOqNFp8Sm8 HP7th7KNQo7hA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pRWJc-0004Wu-5U; Mon, 13 Feb 2023 11:44:08 +0100 From: Johan Hovold To: Marc Zyngier , Thomas Gleixner Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: [PATCH v6 14/20] irqchip/alpine-msi: Use irq_domain_add_hierarchy() Date: Mon, 13 Feb 2023 11:42:56 +0100 Message-Id: <20230213104302.17307-15-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213104302.17307-1-johan+linaro@kernel.org> References: <20230213104302.17307-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Use the irq_domain_add_hierarchy() helper to create the hierarchical domain, which both serves as documentation and avoids poking at irqdomain internals. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Hsin-Yi Wang Tested-by: Mark-PK Tsai Signed-off-by: Johan Hovold --- drivers/irqchip/irq-alpine-msi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index 5ddb8e578ac6..604459372fdd 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -204,16 +204,14 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, return -ENXIO; } - middle_domain = irq_domain_add_tree(NULL, - &alpine_msix_middle_domain_ops, - priv); + middle_domain = irq_domain_add_hierarchy(gic_domain, 0, 0, NULL, + &alpine_msix_middle_domain_ops, + priv); if (!middle_domain) { pr_err("Failed to create the MSIX middle domain\n"); return -ENOMEM; } - middle_domain->parent = gic_domain; - msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), &alpine_msix_domain_info, middle_domain); -- 2.39.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37777C636CC for ; Mon, 13 Feb 2023 10:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=khaAjXFDXQO1AH5lwlRo/wXChBs3Ql3ryoSdDkjKgrU=; b=Td5y52fqpD0I01 VlIIaEjVWMQ1DIRCw9sQpqht6rZBO04+TK9jw5T4dqWllaERFN69eDQ6tmHEfzfrDgxOQsexY6Vpv 293Z/zv/B6yCKGFo+epXfeuQRkJ1A41JcqnDjpMoyAQszjxkatQB644oveJyNHBFxct00Dg/k9zWO D/V1XAmKgNwwj6mBMClW/Iz/RU46imhgd77fa1lbFUvQMjSoxSvMFOgO3JyemTPkGLWeqSsN0aJcB xTa7Eko3zZZs1cC6tXuKIXTCx4219tM8ioEKVE7/mJduJsMgBQcN7DRWmZfzGmmQ0f8f5av6+JRI/ WdBCzzsdmk2+Uq/GfZ5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWQH-00EDK6-2j; Mon, 13 Feb 2023 10:51:02 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWJR-00E9gL-Mz for linux-arm-kernel@bombadil.infradead.org; Mon, 13 Feb 2023 10:43:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=Vgc8FUquq3+r4rz4cJ4Ol4+2ak580W8lYszkhVwD6ZU=; b=EPptOpZXyjhi1N9BU1W+OXSmTM Xj7mZsVetk42DeRzUhzkDalE6H4tCrVmAaV0nF6xpt8qneUdUjlq2LmrNS1cK1sbYeIjowSse/W47 dCTS7vs6p56/yBM632Bd0970133WJ9YkzvTrl86+/RlazD8Yc0Eb8KKx06NgLWFrx58iHilcAlptV oWQf2mSUSZfpvU/VHCfDQ9g5E1/tKj7qEXMfxVQGwqqeA5FhD0aNms+LcCTz27a/ibsAlqgDejwUZ /kTRfvdrtnOSoi8k8wVOd+dvBTMMWH3Dr0CfcsXgFBmBLS31zs65chQAwCLUiW7V02NwYJyL0pLAb a/OqYzIw==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pRWIG-009Guy-0m for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 10:43:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF00660F9E; Mon, 13 Feb 2023 10:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1243AC432C5; Mon, 13 Feb 2023 10:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676284997; bh=NTHXrrpZCAJQDbqGQ5Dk1VncIloUIc9A9BrVorjY3xI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CNDlo9Po/2gPGU3zXwvDyv9/xAcEVX0HaRAAkak++yvXs+wbnXKJAwqfv8Rjf8kNR sZWrSmYMDOvaoHQXZV8T5E9O3D9BETt+mQSaoBiCh6YLevccQH9cQ364zNR7fNS8fy vwIUSRfsC0c6of1luL1aP5BvHA/xEmfXI6HnLLJ8KTT9J9IyAL0t4bRRHP9Rjz69BX j5D67N8cbwM5G6JpN/m68eQd4GIIMpcsoH0fm19uTJC7jMyjNmZEa/1IykGpFz6JHq R8j1UxprHjmCavisECqnL+qzza/RdnvFYAZSyJiltkZvj5W77cyft/sXUOqNFp8Sm8 HP7th7KNQo7hA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pRWJc-0004Wu-5U; Mon, 13 Feb 2023 11:44:08 +0100 From: Johan Hovold To: Marc Zyngier , Thomas Gleixner Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: [PATCH v6 14/20] irqchip/alpine-msi: Use irq_domain_add_hierarchy() Date: Mon, 13 Feb 2023 11:42:56 +0100 Message-Id: <20230213104302.17307-15-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213104302.17307-1-johan+linaro@kernel.org> References: <20230213104302.17307-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_104244_907756_F8C668F3 X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VXNlIHRoZSBpcnFfZG9tYWluX2FkZF9oaWVyYXJjaHkoKSBoZWxwZXIgdG8gY3JlYXRlIHRoZSBo aWVyYXJjaGljYWwKZG9tYWluLCB3aGljaCBib3RoIHNlcnZlcyBhcyBkb2N1bWVudGF0aW9uIGFu ZCBhdm9pZHMgcG9raW5nIGF0CmlycWRvbWFpbiBpbnRlcm5hbHMuCgpSZXZpZXdlZC1ieTogUGhp bGlwcGUgTWF0aGlldS1EYXVkw6kgPHBoaWxtZEBsaW5hcm8ub3JnPgpUZXN0ZWQtYnk6IEhzaW4t WWkgV2FuZyA8aHNpbnlpQGNocm9taXVtLm9yZz4KVGVzdGVkLWJ5OiBNYXJrLVBLIFRzYWkgPG1h cmstcGsudHNhaUBtZWRpYXRlay5jb20+ClNpZ25lZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8am9o YW4rbGluYXJvQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy9pcnFjaGlwL2lycS1hbHBpbmUtbXNp LmMgfCA4ICsrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtYWxwaW5lLW1zaS5jIGIv ZHJpdmVycy9pcnFjaGlwL2lycS1hbHBpbmUtbXNpLmMKaW5kZXggNWRkYjhlNTc4YWM2Li42MDQ0 NTkzNzJmZGQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtYWxwaW5lLW1zaS5jCisr KyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtYWxwaW5lLW1zaS5jCkBAIC0yMDQsMTYgKzIwNCwxNCBA QCBzdGF0aWMgaW50IGFscGluZV9tc2l4X2luaXRfZG9tYWlucyhzdHJ1Y3QgYWxwaW5lX21zaXhf ZGF0YSAqcHJpdiwKIAkJcmV0dXJuIC1FTlhJTzsKIAl9CiAKLQltaWRkbGVfZG9tYWluID0gaXJx X2RvbWFpbl9hZGRfdHJlZShOVUxMLAotCQkJCQkgICAgJmFscGluZV9tc2l4X21pZGRsZV9kb21h aW5fb3BzLAotCQkJCQkgICAgcHJpdik7CisJbWlkZGxlX2RvbWFpbiA9IGlycV9kb21haW5fYWRk X2hpZXJhcmNoeShnaWNfZG9tYWluLCAwLCAwLCBOVUxMLAorCQkJCQkJICZhbHBpbmVfbXNpeF9t aWRkbGVfZG9tYWluX29wcywKKwkJCQkJCSBwcml2KTsKIAlpZiAoIW1pZGRsZV9kb21haW4pIHsK IAkJcHJfZXJyKCJGYWlsZWQgdG8gY3JlYXRlIHRoZSBNU0lYIG1pZGRsZSBkb21haW5cbiIpOwog CQlyZXR1cm4gLUVOT01FTTsKIAl9CiAKLQltaWRkbGVfZG9tYWluLT5wYXJlbnQgPSBnaWNfZG9t YWluOwotCiAJbXNpX2RvbWFpbiA9IHBjaV9tc2lfY3JlYXRlX2lycV9kb21haW4ob2Zfbm9kZV90 b19md25vZGUobm9kZSksCiAJCQkJCSAgICAgICAmYWxwaW5lX21zaXhfZG9tYWluX2luZm8sCiAJ CQkJCSAgICAgICBtaWRkbGVfZG9tYWluKTsKLS0gCjIuMzkuMQoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK