From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78646C6FD19 for ; Mon, 13 Feb 2023 10:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230157AbjBMKnZ (ORCPT ); Mon, 13 Feb 2023 05:43:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbjBMKnV (ORCPT ); Mon, 13 Feb 2023 05:43:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0622C166F9; Mon, 13 Feb 2023 02:43:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29A8B60F8D; Mon, 13 Feb 2023 10:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CEA3C43238; Mon, 13 Feb 2023 10:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676284997; bh=HISCOQlywscKKiMV1pBIVu7ICjzhN///DKg1eFvToD4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dhoeml51KJM8ll0CtYS1SWgoxEo/C8kFsPEpYCkltzjIj/1Be//qMw8JqZaVZyWtM s64H1m3LZqwZubHFGvAjhm/7MbQy2toeD8W6Ua30HktBEyC5WfVCmgQYALK6rzRKpe yEtTuTINBQIb84QG1NSWYEcTKORkIGp0VHCRms5WrNmRTBf1myYNgsq2FKIeHwP3PN peLnpfhAZv2FS7hwflt68Fi1BsXmA72S4hI1Bj0ugvjpDEN9Z6QQeOtcTl7fwIOdtp QClv/6Ir7GHfKwyepV0y3vkJnmoyPVVmh4p0gly43/CIJ1qzhxxnQaMZj7g3OYE9OS nGLcLHzZREAkA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pRWJc-0004X9-JY; Mon, 13 Feb 2023 11:44:08 +0100 From: Johan Hovold To: Marc Zyngier , Thomas Gleixner Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: [PATCH v6 19/20] irqchip/mvebu-odmi: Use irq_domain_create_hierarchy() Date: Mon, 13 Feb 2023 11:43:01 +0100 Message-Id: <20230213104302.17307-20-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213104302.17307-1-johan+linaro@kernel.org> References: <20230213104302.17307-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Use the irq_domain_create_hierarchy() helper to create the hierarchical domain, which both serves as documentation and avoids poking at irqdomain internals. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Hsin-Yi Wang Tested-by: Mark-PK Tsai Signed-off-by: Johan Hovold --- drivers/irqchip/irq-mvebu-odmi.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c index dc4145abdd6f..108091533e10 100644 --- a/drivers/irqchip/irq-mvebu-odmi.c +++ b/drivers/irqchip/irq-mvebu-odmi.c @@ -161,7 +161,7 @@ static struct msi_domain_info odmi_msi_domain_info = { static int __init mvebu_odmi_init(struct device_node *node, struct device_node *parent) { - struct irq_domain *inner_domain, *plat_domain; + struct irq_domain *parent_domain, *inner_domain, *plat_domain; int ret, i; if (of_property_read_u32(node, "marvell,odmi-frames", &odmis_count)) @@ -197,16 +197,17 @@ static int __init mvebu_odmi_init(struct device_node *node, } } - inner_domain = irq_domain_create_linear(of_node_to_fwnode(node), - odmis_count * NODMIS_PER_FRAME, - &odmi_domain_ops, NULL); + parent_domain = irq_find_host(parent); + + inner_domain = irq_domain_create_hierarchy(parent_domain, 0, + odmis_count * NODMIS_PER_FRAME, + of_node_to_fwnode(node), + &odmi_domain_ops, NULL); if (!inner_domain) { ret = -ENOMEM; goto err_unmap; } - inner_domain->parent = irq_find_host(parent); - plat_domain = platform_msi_create_irq_domain(of_node_to_fwnode(node), &odmi_msi_domain_info, inner_domain); -- 2.39.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EC17C636D7 for ; Mon, 13 Feb 2023 10:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jw5FeoPZI29VHGjS4MNpYMioVRX5NdDwmQtA8HIYhVc=; b=08hqGe2zKvkwLg CPA01TH1qB3KKdMOkaRd8IPio014dHn68lUBCrBrPvCfnS8W8MCmRBnwbrRZq3TDxnKAdW3aDo/xa LkQIIENBLcuCk9BgNF2gKkNuSi2KMPJZWpZTdicZPACK5xxJ4Ml0cc69Knk40zFQZi/UK+Q1ifCFp FQOV+aVW9BCUv8qPa0SSIoETBVnj9PRiO/e/byu2mez+gucQSY1rggfJUjj/W7I4pJem5t2cyEgGl 6aSpEnmJCbDpitZ+cZoX+vdwylcMuj0MM1Sb+14kM0aQ9njK/jmXIiEtF4aCuipKs7gpZcatPHrrn lYLGIYHRpK/EtTlPfJKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWMI-00EBG5-QI; Mon, 13 Feb 2023 10:46:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRWIr-00E9OP-Ly for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 10:43:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EC9C60FE1; Mon, 13 Feb 2023 10:43:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CEA3C43238; Mon, 13 Feb 2023 10:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676284997; bh=HISCOQlywscKKiMV1pBIVu7ICjzhN///DKg1eFvToD4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dhoeml51KJM8ll0CtYS1SWgoxEo/C8kFsPEpYCkltzjIj/1Be//qMw8JqZaVZyWtM s64H1m3LZqwZubHFGvAjhm/7MbQy2toeD8W6Ua30HktBEyC5WfVCmgQYALK6rzRKpe yEtTuTINBQIb84QG1NSWYEcTKORkIGp0VHCRms5WrNmRTBf1myYNgsq2FKIeHwP3PN peLnpfhAZv2FS7hwflt68Fi1BsXmA72S4hI1Bj0ugvjpDEN9Z6QQeOtcTl7fwIOdtp QClv/6Ir7GHfKwyepV0y3vkJnmoyPVVmh4p0gly43/CIJ1qzhxxnQaMZj7g3OYE9OS nGLcLHzZREAkA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pRWJc-0004X9-JY; Mon, 13 Feb 2023 11:44:08 +0100 From: Johan Hovold To: Marc Zyngier , Thomas Gleixner Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: [PATCH v6 19/20] irqchip/mvebu-odmi: Use irq_domain_create_hierarchy() Date: Mon, 13 Feb 2023 11:43:01 +0100 Message-Id: <20230213104302.17307-20-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213104302.17307-1-johan+linaro@kernel.org> References: <20230213104302.17307-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_024322_000661_C29F6CF5 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VXNlIHRoZSBpcnFfZG9tYWluX2NyZWF0ZV9oaWVyYXJjaHkoKSBoZWxwZXIgdG8gY3JlYXRlIHRo ZSBoaWVyYXJjaGljYWwKZG9tYWluLCB3aGljaCBib3RoIHNlcnZlcyBhcyBkb2N1bWVudGF0aW9u IGFuZCBhdm9pZHMgcG9raW5nIGF0CmlycWRvbWFpbiBpbnRlcm5hbHMuCgpSZXZpZXdlZC1ieTog UGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPHBoaWxtZEBsaW5hcm8ub3JnPgpUZXN0ZWQtYnk6IEhz aW4tWWkgV2FuZyA8aHNpbnlpQGNocm9taXVtLm9yZz4KVGVzdGVkLWJ5OiBNYXJrLVBLIFRzYWkg PG1hcmstcGsudHNhaUBtZWRpYXRlay5jb20+ClNpZ25lZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8 am9oYW4rbGluYXJvQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy9pcnFjaGlwL2lycS1tdmVidS1v ZG1pLmMgfCAxMyArKysrKysrLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp LCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUt b2RtaS5jIGIvZHJpdmVycy9pcnFjaGlwL2lycS1tdmVidS1vZG1pLmMKaW5kZXggZGM0MTQ1YWJk ZDZmLi4xMDgwOTE1MzNlMTAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUt b2RtaS5jCisrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtb2RtaS5jCkBAIC0xNjEsNyAr MTYxLDcgQEAgc3RhdGljIHN0cnVjdCBtc2lfZG9tYWluX2luZm8gb2RtaV9tc2lfZG9tYWluX2lu Zm8gPSB7CiBzdGF0aWMgaW50IF9faW5pdCBtdmVidV9vZG1pX2luaXQoc3RydWN0IGRldmljZV9u b2RlICpub2RlLAogCQkJCSAgc3RydWN0IGRldmljZV9ub2RlICpwYXJlbnQpCiB7Ci0Jc3RydWN0 IGlycV9kb21haW4gKmlubmVyX2RvbWFpbiwgKnBsYXRfZG9tYWluOworCXN0cnVjdCBpcnFfZG9t YWluICpwYXJlbnRfZG9tYWluLCAqaW5uZXJfZG9tYWluLCAqcGxhdF9kb21haW47CiAJaW50IHJl dCwgaTsKIAogCWlmIChvZl9wcm9wZXJ0eV9yZWFkX3UzMihub2RlLCAibWFydmVsbCxvZG1pLWZy YW1lcyIsICZvZG1pc19jb3VudCkpCkBAIC0xOTcsMTYgKzE5NywxNyBAQCBzdGF0aWMgaW50IF9f aW5pdCBtdmVidV9vZG1pX2luaXQoc3RydWN0IGRldmljZV9ub2RlICpub2RlLAogCQl9CiAJfQog Ci0JaW5uZXJfZG9tYWluID0gaXJxX2RvbWFpbl9jcmVhdGVfbGluZWFyKG9mX25vZGVfdG9fZndu b2RlKG5vZGUpLAotCQkJCQkJb2RtaXNfY291bnQgKiBOT0RNSVNfUEVSX0ZSQU1FLAotCQkJCQkJ Jm9kbWlfZG9tYWluX29wcywgTlVMTCk7CisJcGFyZW50X2RvbWFpbiA9IGlycV9maW5kX2hvc3Qo cGFyZW50KTsKKworCWlubmVyX2RvbWFpbiA9IGlycV9kb21haW5fY3JlYXRlX2hpZXJhcmNoeShw YXJlbnRfZG9tYWluLCAwLAorCQkJCQkJICAgb2RtaXNfY291bnQgKiBOT0RNSVNfUEVSX0ZSQU1F LAorCQkJCQkJICAgb2Zfbm9kZV90b19md25vZGUobm9kZSksCisJCQkJCQkgICAmb2RtaV9kb21h aW5fb3BzLCBOVUxMKTsKIAlpZiAoIWlubmVyX2RvbWFpbikgewogCQlyZXQgPSAtRU5PTUVNOwog CQlnb3RvIGVycl91bm1hcDsKIAl9CiAKLQlpbm5lcl9kb21haW4tPnBhcmVudCA9IGlycV9maW5k X2hvc3QocGFyZW50KTsKLQogCXBsYXRfZG9tYWluID0gcGxhdGZvcm1fbXNpX2NyZWF0ZV9pcnFf ZG9tYWluKG9mX25vZGVfdG9fZndub2RlKG5vZGUpLAogCQkJCQkJICAgICAmb2RtaV9tc2lfZG9t YWluX2luZm8sCiAJCQkJCQkgICAgIGlubmVyX2RvbWFpbik7Ci0tIAoyLjM5LjEKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==