From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B7CF8F57 for ; Mon, 13 Feb 2023 14:55:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F874C433D2; Mon, 13 Feb 2023 14:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676300121; bh=U2A2YxVpHIRcT1Q3uq/TgJmcRs5gm/qHCZvvBwC5NYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IAhy6n7dd3wKez9AKIkCcC1Xe5sccrORhFuDLzTW0HKOWdGaacn7UW/KRhrAygGTr nYtBBqpzm1KhsbPCBtLDoUZj+kwe6dr77qhdjggheFzKW0hUMfKrcI2O4PbjSGIg0t 1Ta2ndhAl1pB6oIh4ptNnmYCjJd8BKaSTFzRZNyw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joel Stanley , Andrew Jeffery , Linus Walleij , Sasha Levin Subject: [PATCH 6.1 072/114] pinctrl: aspeed: Fix confusing types in return value Date: Mon, 13 Feb 2023 15:48:27 +0100 Message-Id: <20230213144745.929206556@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213144742.219399167@linuxfoundation.org> References: <20230213144742.219399167@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Joel Stanley [ Upstream commit 287a344a11f1ebd31055cf9b22c88d7005f108d7 ] The function signature is int, but we return a bool. Instead return a negative errno as the kerneldoc suggests. Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index a30912a92f057..f93d6959cee94 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -113,7 +113,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx, int ret = 0; if (!exprs) - return true; + return -EINVAL; while (*exprs && !ret) { ret = aspeed_sig_expr_disable(ctx, *exprs); -- 2.39.0