From: Jakub Kicinski <kuba@kernel.org>
To: mchehab@kernel.org
Cc: netdev@vger.kernel.org, hverkuil@xs4all.nl,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: drop unnecessary networking includes
Date: Tue, 14 Feb 2023 18:41:28 -0800 [thread overview]
Message-ID: <20230214184128.45cabcf8@kernel.org> (raw)
In-Reply-To: <20230203233129.3413367-1-kuba@kernel.org>
On Fri, 3 Feb 2023 15:31:29 -0800 Jakub Kicinski wrote:
> dvb_net.h includes a bunch of core networking headers which increases
> the number of objects rebuilt when we touch them. They are unnecessary
> for the header itself and only one driver has an indirect dependency.
>
> tveeprom.h includes if_packet to gain access to ETH_ALEN. This
> is a bit of an overkill because if_packet.h pulls in skbuff.h.
> The definition of ETH_ALEN is in the uAPI header, which is
> very rarely touched, so switch to including that.
>
> This results in roughly 250 fewer objects built when skbuff.h
> is touched (6028 -> 5788).
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Hi Mauro! Could you take this in for 6.3?
Is it okay if we queue it via the networking tree otherwise?
prev parent reply other threads:[~2023-02-15 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 23:31 [PATCH] media: drop unnecessary networking includes Jakub Kicinski
2023-02-15 2:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214184128.45cabcf8@kernel.org \
--to=kuba@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.