From: Rob Herring <robh@kernel.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: Janne Grunau <j@jannau.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hector Martin <marcan@marcan.st>,
devicetree@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Sven Peter <sven@svenpeter.dev>,
asahi@lists.linux.dev, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: dma: apple,sio: Add schema
Date: Tue, 14 Feb 2023 13:19:59 -0600 [thread overview]
Message-ID: <20230214191959.GA27025-robh@kernel.org> (raw)
In-Reply-To: <167638945429.3790.16067227881981242831.robh@kernel.org>
On Tue, Feb 14, 2023 at 10:12:34AM -0600, Rob Herring wrote:
>
> On Tue, 14 Feb 2023 15:10:53 +0100, Martin Povišer wrote:
> > Describe the SIO coprocessor which serves as pretend DMA controller on
> > recent Apple platforms.
> >
> > Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
> > ---
> >
> > Since the schema mentions a loader preparing the binding appropriately,
> > here's a PR with the relevant (WIP) loader code, if anyone wants to look:
> > https://github.com/AsahiLinux/m1n1/pull/286
> >
> > .../devicetree/bindings/dma/apple,sio.yaml | 129 ++++++++++++++++++
> > 1 file changed, 129 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/dma/apple,sio.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/dma/apple,sio.example.dts:24.35-27.11: Warning (node_name_vs_property_name): /example-0/interrupt-controller: node name and property name conflict
This is a quirk with how the examples are constructed. In any case, just
drop the 'interrupt-controller' node. No need to show providers in an
example.
Rob
next prev parent reply other threads:[~2023-02-14 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 14:10 [RFC PATCH] dt-bindings: dma: apple,sio: Add schema Martin Povišer
2023-02-14 16:12 ` Rob Herring
2023-02-14 19:18 ` Martin Povišer
2023-02-15 14:44 ` Rob Herring
2023-02-14 19:19 ` Rob Herring [this message]
2023-02-14 19:25 ` Rob Herring
2023-02-14 20:02 ` Martin Povišer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214191959.GA27025-robh@kernel.org \
--to=robh@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=povik+lin@cutebit.org \
--cc=sven@svenpeter.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.