From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD6CC61DA4 for ; Tue, 14 Feb 2023 22:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233357AbjBNWOU (ORCPT ); Tue, 14 Feb 2023 17:14:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233364AbjBNWOS (ORCPT ); Tue, 14 Feb 2023 17:14:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0282930B2D for ; Tue, 14 Feb 2023 14:14:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EBBB61941 for ; Tue, 14 Feb 2023 22:14:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3A1BC433A0; Tue, 14 Feb 2023 22:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676412852; bh=4RylD1+QgEHlXROUt365Og+KQdvLIFdi3neuxri9Nu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQP8LfAD5LBPBgwjZvqMxGE6HGSxPEywBr8CJprBMkWchdnAvH3wAKwNmGHh7NKip ledHTbmMOtQu2iWcBijqlc5gQU6kWyEW4AtUhZGneNYE9oURyzr3He53Ls8UYL+iHn SwHO6qd9sLcwSqGJyJ+GhRZb8/CONyLFl+p/yruCXAJJCSEbs7FacHT+xs8brWgr+u KVkOPSQXbMYFkaEZ6PrEzjR593KBF5z8r21AVTI2nqbeO4o6YGisAnEBtsKzwCu0sG VPtgMxS+3DDUaP85Mx6DmPshMe/OQ6avRCF7R6mVR6Yrnrlp7LDKb7oCG+cjzESmXh X1l2mxB6IdGCg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Roi Dayan Subject: [net-next V2 06/15] net/mlx5e: Use a simpler comparison for uplink rep Date: Tue, 14 Feb 2023 14:12:30 -0800 Message-Id: <20230214221239.159033-7-saeed@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214221239.159033-1-saeed@kernel.org> References: <20230214221239.159033-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan get_route_and_out_devs() is uses the following condition mlx5e_eswitch_rep() && mlx5e_is_uplink_rep() to check if a given netdev is the uplink rep. Alternatively we can just use the straight forward version mlx5e_eswitch_uplink_rep() that only checks if a given netdev is uplink rep. Signed-off-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c index 684c0293a4d6..00a04fdd756f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c @@ -93,8 +93,7 @@ static int get_route_and_out_devs(struct mlx5e_priv *priv, else return -EOPNOTSUPP; - if (!(mlx5e_eswitch_rep(*out_dev) && - mlx5e_is_uplink_rep(netdev_priv(*out_dev)))) + if (!mlx5e_eswitch_uplink_rep(*out_dev)) return -EOPNOTSUPP; if (mlx5e_eswitch_uplink_rep(priv->netdev) && *out_dev != priv->netdev && -- 2.39.1