All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChiYuan Huang <cy_huang@richtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
	ChiaEn Wu <chiaen_wu@richtek.com>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<peterwu.pub@gmail.com>
Subject: Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name
Date: Wed, 15 Feb 2023 11:34:40 +0800	[thread overview]
Message-ID: <20230215033440.GA6570@linuxcarl2.richtek.com> (raw)
In-Reply-To: <75d37ae7-3632-a195-b12b-44e8a940be4a@linaro.org>

H, Krzysztof/Sebastian:
On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 21:53, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> >> "richtek,rt9467"
> >>
> >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> >> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> >> ---
> > 
> > Is there a new version of this fixing the issues pointed out by Krzysztof?
> > Also I think the filename and $id should be changed to richtek,rt9467.yaml
> > in addition to the compatible change.
> 
> Yes, indeed.
> 
From the current discussion, there're things to be fixed.
1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'.
2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'

Anything else? like as changing source code filename from from 'rt9467-charger.c' to 'rt9467.c"?

And we'll submit a new patch to fix it days later.

Thanks.
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2023-02-15  3:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08  3:14 [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name ChiaEn Wu
2023-02-08  8:04 ` Krzysztof Kozlowski
2023-02-08 23:51 ` Rob Herring
2023-02-13 20:53 ` Sebastian Reichel
2023-02-14  8:14   ` Krzysztof Kozlowski
2023-02-15  3:34     ` ChiYuan Huang [this message]
2023-02-15 13:15       ` Sebastian Reichel
2023-02-15  3:45     ` ChiYuan Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215033440.GA6570@linuxcarl2.richtek.com \
    --to=cy_huang@richtek.com \
    --cc=chiaen_wu@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterwu.pub@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.