All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: Ming Lei <ming.lei@redhat.com>,
	axboe@kernel.dk, hch@lst.de, mcgrof@kernel.org,
	gost.dev@samsung.com, linux-block@vger.kernel.org
Subject: Re: [PATCH 0/1] improve brd performance with blk-mq
Date: Wed, 15 Feb 2023 07:47:23 +0100	[thread overview]
Message-ID: <20230215064723.GA30472@lst.de> (raw)
In-Reply-To: <95506a88-c89c-0f41-3ab4-eb5741410c02@samsung.com>

On Tue, Feb 14, 2023 at 08:18:54PM +0530, Pankaj Raghav wrote:
> Should we add a module parameter to switch between bio and blk-mq back-end
> in brd, similar to null_blk? The default option would be bio to avoid
> regression on existing workloads.

No.  Duplicate code paths are alaways a bad idea.  Please drill in further
what causes the differences.

  reply	other threads:[~2023-02-15  6:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230203103122eucas1p161c0f0b674d26e23cf38466d5415420e@eucas1p1.samsung.com>
2023-02-03 10:30 ` [PATCH 0/1] improve brd performance with blk-mq Pankaj Raghav
2023-02-03 10:30   ` [PATCH] brd: improve " Pankaj Raghav
2023-02-06 15:50     ` Christoph Hellwig
2023-02-06 16:10       ` Pankaj Raghav
2023-02-07  1:43   ` [PATCH 0/1] improve brd " Ming Lei
2023-02-13  5:56     ` Pankaj Raghav
2023-02-13  8:10       ` Ming Lei
2023-02-14 14:48         ` Pankaj Raghav
2023-02-15  6:47           ` Christoph Hellwig [this message]
2023-02-15 23:38           ` Jens Axboe
2023-02-15 23:39             ` Jens Axboe
2023-02-17 14:27             ` Pankaj Raghav
2023-02-17 14:40               ` Jens Axboe
2023-02-17 14:52                 ` Pankaj Raghav
2023-02-21 21:59                   ` Luis Chamberlain
2023-02-21 23:51                     ` Jens Axboe
2023-02-22 22:42                       ` Luis Chamberlain
2023-02-22 22:47                         ` Jens Axboe
2023-02-22 22:54                           ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215064723.GA30472@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=p.raghav@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.