From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next 2/2] skbuff: Add likely to skb pointer in build_skb()
Date: Wed, 15 Feb 2023 15:01:30 -0800 [thread overview]
Message-ID: <20230215150130.6c2662ea@kernel.org> (raw)
In-Reply-To: <20230215121707.1936762-3-gal@nvidia.com>
On Wed, 15 Feb 2023 14:17:07 +0200 Gal Pressman wrote:
> - if (skb && frag_size) {
> + if (likely(skb) && frag_size) {
Should frag_size also be inside the likely?
See the warning in __build_skb_around().
next prev parent reply other threads:[~2023-02-15 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 12:17 [PATCH net-next 0/2] Couple of minor improvements to build_skb variants Gal Pressman
2023-02-15 12:17 ` [PATCH net-next 1/2] skbuff: Replace open-coded skb_propagate_pfmemalloc()s Gal Pressman
2023-02-15 12:17 ` [PATCH net-next 2/2] skbuff: Add likely to skb pointer in build_skb() Gal Pressman
2023-02-15 23:01 ` Jakub Kicinski [this message]
2023-02-16 14:55 ` Gal Pressman
2023-02-16 15:00 ` Paolo Abeni
2023-02-16 12:15 ` Paolo Abeni
2023-02-15 15:03 ` [PATCH net-next 0/2] Couple of minor improvements to build_skb variants Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215150130.6c2662ea@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.