From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Norbert Lange <nolange79@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/zstd: bump to version 1.5.4
Date: Wed, 15 Feb 2023 22:41:40 +0100 [thread overview]
Message-ID: <20230215224140.212f6e6b@windsurf> (raw)
In-Reply-To: <20230215151302.140387-1-nolange79@gmail.com>
Hello Norbert,
On Wed, 15 Feb 2023 16:13:01 +0100
Norbert Lange <nolange79@gmail.com> wrote:
> The LICENSE text has changed, nominally the copyright owner changed
> from "Facebook" to "Meta Platforms, Inc. and affiliates",
> reflecting the name change of that company.
>
> Add upstream patch to fix zstd-dll build.
>
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
> ---
> ...-zstd-dll-build-missing-dependencies.patch | 179 ++++++++++++++++++
> package/zstd/zstd.hash | 6 +-
> package/zstd/zstd.mk | 2 +-
> 3 files changed, 183 insertions(+), 4 deletions(-)
> create mode 100644 package/zstd/0001-Fix-zstd-dll-build-missing-dependencies.patch
Thanks for the patch.
>
> diff --git a/package/zstd/0001-Fix-zstd-dll-build-missing-dependencies.patch b/package/zstd/0001-Fix-zstd-dll-build-missing-dependencies.patch
> new file mode 100644
> index 0000000000..bbb008c3b3
> --- /dev/null
> +++ b/package/zstd/0001-Fix-zstd-dll-build-missing-dependencies.patch
> @@ -0,0 +1,179 @@
> +Fix zstd-dll build
> +
> +https://github.com/facebook/zstd/commit/c78f434aa4f5f1097c8edb975f4c1635817a5a71
> +
> +Signed-off-by: Norbert Lange <nolange79@gmail.com>
Could you use git format-patch to generate this patch, and preserve the
authorship of the patch from its original author?
Essentially this:
- git clone ...
- git checkout v1.5.4
- git cherry-pick c78f434aa4f5f1097c8edb975f4c1635817a5a71
- git commit --amend
(add your own SoB in the commit log + reference to the upstream commit)
- git format-patch HEAD^
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-15 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 15:13 [Buildroot] [PATCH] package/zstd: bump to version 1.5.4 Norbert Lange
2023-02-15 21:41 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215224140.212f6e6b@windsurf \
--to=buildroot@buildroot.org \
--cc=andrew.smirnov@gmail.com \
--cc=nolange79@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.