All of lore.kernel.org
 help / color / mirror / Atom feed
From: Orlando Chamberlain <orlandoch.dev@gmail.com>
To: linux-input@vger.kernel.org
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Pavel Machek" <pavel@ucw.cz>,
	"Aditya Garg" <gargaditya08@live.com>,
	"Aun-Ali Zaidi" <admin@kodeit.net>,
	"Kerem Karabay" <kekrby@gmail.com>,
	"Andy Shevchenko" <andy@infradead.org>,
	"Thomas Weißschuh" <thomas@t-8ch.de>,
	"Orlando Chamberlain" <orlandoch.dev@gmail.com>
Subject: [PATCHv2 0/2] Apple Magic Keyboard Backlight
Date: Thu, 16 Feb 2023 15:12:24 +1100	[thread overview]
Message-ID: <20230216041224.4731-1-orlandoch.dev@gmail.com> (raw)

This patchseries adds support for the internal keyboard backlight of
Macs with Apple's "Magic" keyboard (MacBookPro16,* and MacBookAir9,1),
and also documents what names should be used for keyboard backlight
leds in Documentation/leds/well-known-leds.txt.

A previous version of this patch was sent alongside some other drivers
here[1] but for v2 I'm submitting it separately to make upstreaming
easier.

v1->v2:
- drop unneeded remove function
- combine set functions
- add missing header inclusions
- avoid char as argument in favour of u8
- handful of style/formatting fixes
- use standard led name ":white:kbd_backlight"
- rename USAGE_MAGIC_BL to HID_USAGE_MAGIC_BL
- New patch documenting preferred keyboard backlight names

[1]: https://lore.kernel.org/linux-input/7D70F1FE-7F54-4D0A-8922-5466AA2AD364@live.com/

Orlando Chamberlain (2):
  Documentation: leds: standardise keyboard backlight led names
  HID: apple-magic-backlight: Add driver for keyboard backlight on
    internal Magic Keyboards

 Documentation/leds/well-known-leds.txt |   8 ++
 MAINTAINERS                            |   6 ++
 drivers/hid/Kconfig                    |  13 +++
 drivers/hid/Makefile                   |   1 +
 drivers/hid/apple-magic-backlight.c    | 125 +++++++++++++++++++++++++
 5 files changed, 153 insertions(+)
 create mode 100644 drivers/hid/apple-magic-backlight.c

-- 
2.39.1


             reply	other threads:[~2023-02-16  4:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  4:12 Orlando Chamberlain [this message]
2023-02-16  4:12 ` [PATCH 1/2] Documentation: leds: standardise keyboard backlight led names Orlando Chamberlain
2023-02-16  4:12 ` [PATCH 2/2] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards Orlando Chamberlain
2023-02-16  5:41   ` Thomas Weißschuh
2023-02-16  5:58     ` Orlando Chamberlain
2023-02-16 11:51     ` Andy Shevchenko
2023-02-16  7:10   ` Orlando Chamberlain
2023-02-16 11:49     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216041224.4731-1-orlandoch.dev@gmail.com \
    --to=orlandoch.dev@gmail.com \
    --cc=admin@kodeit.net \
    --cc=andy@infradead.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=corbet@lwn.net \
    --cc=gargaditya08@live.com \
    --cc=jikos@kernel.org \
    --cc=kekrby@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=thomas@t-8ch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.