From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1250D2F5 for ; Wed, 15 Feb 2023 21:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676496608; x=1708032608; h=date:from:to:cc:subject:message-id:mime-version; bh=VHA+4xYjWydo9f8DKfmcl6xZsgu2/mUgnP6iQWqsv1U=; b=m2kSlqTJMzj1qcpqf2966hAXf3k1oqKJPa7E23G0c08y89sGlF79aXmH byO5jk/cstNxWz+w0ZKcvS5+zesoOyVZl+CJzq/wo+ewyK2dkPT63C9tt 3spzKOZZGfGxwabgAecqLTUkRsepZyImTNjYp0Yl3C98nN5dWMAHhgkva l93mdFGxIQBEUqdxsW5h1R6IUd7aD+g7bExMa/0+EHGEdmUjyakSFpHDE 6+kzoImfxsDvIFH6evJgsqeUCc/v9gTS4hR3nuDU/PMJfL/Vld7e3p+Ir h2v970l0h6UG+cK24y9g0Qd9HaeuGEksU5POvjG6sOwjpjRpFvo3LMaGi w==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="417771127" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="417771127" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 13:30:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="812690633" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="812690633" Received: from lkp-server01.sh.intel.com (HELO 4455601a8d94) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 15 Feb 2023 13:30:06 -0800 Received: from kbuild by 4455601a8d94 with local (Exim 4.96) (envelope-from ) id 1pSPLp-0009oD-2o; Wed, 15 Feb 2023 21:30:05 +0000 Date: Thu, 16 Feb 2023 05:29:13 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here Message-ID: <202302160504.G6Rsomen-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Lucas De Marchi CC: Wayne Boyer tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e1c04510f521e853019afeca2a5991a5ef8d6a5b commit: 3d99597c6496b9319f7522e0d073afab314d518a drm/i915: Split i915_gem_init_stolen() date: 5 months ago :::::: branch date: 28 hours ago :::::: commit date: 5 months ago config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230216/202302160504.G6Rsomen-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Link: https://lore.kernel.org/r/202302160504.G6Rsomen-lkp@intel.com/ smatch warnings: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here drivers/gpu/drm/i915/gem/i915_gem_stolen.c:455 init_reserved_stolen() warn: missing error code 'ret' vim +173 drivers/gpu/drm/i915/gem/i915_gem_stolen.c 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 141 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 142 static int request_smem_stolen(struct drm_i915_private *i915, 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 143 struct resource *dsm) 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 144 { 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 145 struct resource *r; 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 146 d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 147 /* 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 148 * With stolen lmem, we don't need to request system memory for the 3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 149 * address range since it's local to the gpu. d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 150 */ d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 151 if (HAS_LMEM(i915)) d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 152 return 0; d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 153 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 154 /* 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 155 * Verify that nothing else uses this physical address. Stolen eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 156 * memory should be reserved by the BIOS and hidden from the eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 157 * kernel. So if the region is already marked as busy, something eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 158 * is seriously wrong. eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 159 */ bdce2bea0f5e6b drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 160 r = devm_request_mem_region(i915->drm.dev, dsm->start, 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 161 resource_size(dsm), eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 162 "Graphics Stolen Memory"); 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 163 if (r == NULL) { 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 164 /* 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 165 * One more attempt but this time requesting region from 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 166 * start + 1, as we have seen that this resolves the region 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 167 * conflict with the PCI Bus. 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 168 * This is a BIOS w/a: Some BIOS wrap stolen in the root 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 169 * PCI bus, but have an off-by-one error. Hence retry the 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 170 * reservation starting from 1 instead of 0. 023f807989f4d6 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2017-07-19 171 * There's also BIOS with off-by-one on the other end. 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 172 */ bdce2bea0f5e6b drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 @173 r = devm_request_mem_region(i915->drm.dev, dsm->start + 1, 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 174 resource_size(dsm) - 2, 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 175 "Graphics Stolen Memory"); 0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 176 /* 0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 177 * GEN3 firmware likes to smash pci bridges into the stolen 0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 178 * range. Apparently this works. 0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 179 */ 40e1956ec505a1 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2021-06-05 180 if (!r && GRAPHICS_VER(i915) != 3) { baa89ba3f1feda drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 181 drm_err(&i915->drm, baa89ba3f1feda drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 182 "conflict detected with stolen region: %pR\n", 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 183 dsm); 920bcd1820a696 drivers/gpu/drm/i915/i915_gem_stolen.c Paulo Zanoni 2017-01-26 184 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 185 return -EBUSY; eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 186 } 3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 187 } eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 188 7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 189 return 0; 9797fbfbcfe251 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 190 } 9797fbfbcfe251 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 191 :::::: The code at line 173 was first introduced by commit :::::: bdce2bea0f5e6bd3e3fa85278cc2fb8632f71572 drm/i915/gem: Replace implicit dev_priv->uncore for stolen init :::::: TO: Chris Wilson :::::: CC: Chris Wilson -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests