From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pSYNk-0006RQ-EW for mharc-grub-devel@gnu.org; Thu, 16 Feb 2023 02:08:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSYNi-0006RE-6G for grub-devel@gnu.org; Thu, 16 Feb 2023 02:08:38 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSYNg-0001nl-Q5 for grub-devel@gnu.org; Thu, 16 Feb 2023 02:08:37 -0500 Received: by mail-qt1-x82b.google.com with SMTP id q13so1261709qtx.2 for ; Wed, 15 Feb 2023 23:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qL61Ud8xMYs7Ws44NC8biU7DUBo2i5nhXhHZy+zMkHM=; b=yve24oDmkdyei6gyxX0tymxElVxJNjtp3dGela6h69rygmPwiaZVcDlxCuVZykzAne smhvny5kJGMJyrb23N8E8R8c9FOYrjJc2xpabb201Y9AgUr3WcMF9D1Oncl6lvUFqIsS PBte9EwzH3tPb8QlRmtIIcLDS60+gY9y6DD4gnINuS+zz0aQ401dAViQ4Uj4AFm/3FQt /iT89kWj9VXphejAE/UXYlEpWPFtJGoyC8qC+vpYwIUWzSDROBEEwhFctUh1wHzu046G blTEVZH6+V0LIycHylUy48HH5R3tpT0WhayRBmnccORRPCkoTIS8VsbvTUvlrBEwRb7n RnVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qL61Ud8xMYs7Ws44NC8biU7DUBo2i5nhXhHZy+zMkHM=; b=iwDP56grutUCeGozq0dpHt3Gfrqt3w9NmTCWe0TlaEUJep0MGntHr/Uc9Jpa+r0+XP yIQph4DMKCMnVqPHAtXOmBRsxe2mdYxbylYl++n4O64hE4tmWhFTsdonW0/ubGBX+XHA pbupwVgvlXf39Z8aOdO+ci4LJsxkAN2+fOeVQwT+OUxX1WCXbXs/lBOC2sQsyROAvB+p mE447Up5kS/ivIcLdHf9xMFVw3zvSG8DGMC2BuEXJTE8wEBANhI3oqMaT+N5u2EgXVGv r4mqCAUOk0zwMos4gMS5GobaUsHH6M6BPHFd35JTrnTsc2Qwk2UTUyp1qRkjAKl7ZGAB dwqA== X-Gm-Message-State: AO0yUKX1CrzNx0EQxEviOM0eeIrTFMFg/YRqScXYJXVnf5ksdnIXgdhy m3OwVNP8kKJyqpQHcgyz4wiH2biSuDTgWO5P X-Google-Smtp-Source: AK7set8DV0rmBEEuTKxFdisl669RZ8ZObw2vGM1kcAnMwaV/goKUNOx9rm920p4vTPnsQgdETU4LyQ== X-Received: by 2002:a05:622a:490:b0:3b7:fafc:73e3 with SMTP id p16-20020a05622a049000b003b7fafc73e3mr8134047qtx.41.1676531314830; Wed, 15 Feb 2023 23:08:34 -0800 (PST) Received: from localhost.localdomain ([37.218.244.251]) by smtp.gmail.com with ESMTPSA id x68-20020a379547000000b0073b692623c5sm610839qkd.129.2023.02.15.23.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 23:08:34 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH] tests: grub_cmd_cryptomount should hard error when pre-requisites are not met Date: Thu, 16 Feb 2023 01:08:21 -0600 Message-Id: <20230216070821.2142245-1-development@efficientek.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=development@efficientek.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2023 07:08:38 -0000 Tests should be SKIP'd only when they do not apply to a particular target. Hard errors are for when the test should run but can not be setup properly. Signed-off-by: Glenn Washburn --- tests/grub_cmd_cryptomount.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/grub_cmd_cryptomount.in b/tests/grub_cmd_cryptomount.in index b05cd3800e..4578ab7093 100644 --- a/tests/grub_cmd_cryptomount.in +++ b/tests/grub_cmd_cryptomount.in @@ -22,17 +22,17 @@ fi if [ "$EUID" != 0 ] ; then echo "not root; cannot test cryptomount." - exit 77 + exit 99 fi if ! which cryptsetup >/dev/null 2>&1; then echo "cryptsetup not installed; cannot test cryptomount." - exit 77 + exit 99 fi if ! which mkfs.vfat >/dev/null 2>&1; then echo "mkfs.vfat not installed; cannot test cryptomount." - exit 77 + exit 99 fi COMMON_OPTS='${V:+--debug=$V} --cs-opts="--pbkdf-force-iterations 1000"' -- 2.34.1