All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: peterx@redhat.com, david@redhat.com,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	kernel@collabora.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 2/2] mm/userfaultfd: add VM_WARN_ONCE()
Date: Thu, 16 Feb 2023 14:16:56 +0500	[thread overview]
Message-ID: <20230216091656.2045471-2-usama.anjum@collabora.com> (raw)
In-Reply-To: <20230216091656.2045471-1-usama.anjum@collabora.com>

Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 mm/userfaultfd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index 77c5839e591c..d89ed44d2668 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -717,6 +717,8 @@ long uffd_wp_range(struct mm_struct *dst_mm, struct vm_area_struct *dst_vma,
 	struct mmu_gather tlb;
 	long ret;
 
+	VM_WARN_ONCE(start < dst_vma->vm_start || start + len > dst_vma->vm_end,
+		     "The address range exceeds VMA boundary.\n");
 	if (enable_wp)
 		mm_cp_flags = MM_CP_UFFD_WP;
 	else
-- 
2.39.1



  reply	other threads:[~2023-02-16  9:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  9:16 [PATCH v4 1/2] mm/userfaultfd: Support WP on multiple VMAs Muhammad Usama Anjum
2023-02-16  9:16 ` Muhammad Usama Anjum [this message]
2023-02-16  9:24   ` [PATCH v4 2/2] mm/userfaultfd: add VM_WARN_ONCE() David Hildenbrand
2023-02-16  9:48     ` Muhammad Usama Anjum
2023-02-16 20:26       ` Peter Xu
2023-02-17 10:40         ` Muhammad Usama Anjum
2023-02-16  9:37 ` [PATCH v4 1/2] mm/userfaultfd: Support WP on multiple VMAs David Hildenbrand
2023-02-16 20:25   ` Peter Xu
2023-02-17  8:53     ` David Hildenbrand
2023-02-17 17:35       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216091656.2045471-2-usama.anjum@collabora.com \
    --to=usama.anjum@collabora.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.