From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEAC26FD0 for ; Thu, 16 Feb 2023 14:21:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC11C4339B; Thu, 16 Feb 2023 14:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676557309; bh=PIgKpAOv7CdOk3XI8N/fI6LgE9z/MAE9kl5fG7CCq9k=; h=From:To:Cc:Subject:Date:From; b=LD7E+5mPXyD8eAkRvRlmMWRpeX34fzxjC9/n3yBa8NIrpWH2y51YR62hsYTNX+R6b ZpFt2jWbF5EJomkJSAjAdHOUeAAgLetuux9xG7zdC8lYHfguT8geluSc+ypiMtqNce HcNNkTMIY2Ej5yukRG+4gHZNsofVlMLP3gK/hw6HlmTv2T78uMSEFhzLX43Smj3hUN VWMeHoLa84P8Xf6gW40so0TF0KIKq3gm9kJ1xt1rsa9siSOGcH7POscroTh8fQ5FaB BlK5ji8uIhwXXX5TWMVxkpKZpiyqlnrRkXI8I8/YVCQF9nlaSYy5qwjHba0JMnTJcy N6M+0n02S0DjA== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSf8t-00AuwB-5S; Thu, 16 Feb 2023 14:21:47 +0000 From: Marc Zyngier To: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Ricardo Koller , Simon Veith , dwmw2@infradead.org Subject: [PATCH 00/16] KVM: arm64: Rework timer offsetting for fun and profit Date: Thu, 16 Feb 2023 14:21:07 +0000 Message-Id: <20230216142123.2638675-1-maz@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false This series aims at satisfying multiple goals: - allow a VMM to atomically restore a timer offset for a whole VM instead of updating the offset each time a vcpu get its counter written - allow a VMM to save/restore the physical timer context, something that we cannot do at the moment due to the lack of offsetting - provide a framework that is suitable for NV support, where we get both global and per timer, per vcpu offsetting We fix a couple of issues along the way, both from a stylistic and correctness perspective. This results in a new per VM KVM API that allows a pair of global offsets to be set at any point in time, overriding the timer counter writeback. This has been moderately tested with nVHE, VHE and NV. I do not have access to CNTPOFF-aware HW, so the jury is still out on that one. Note that the NV patches in this series are here to give a perspective on how this gets used. I've updated the arch_timer selftest to allow offsets to be provided from the command line, but the arch_test is pretty flimsy and tends to fail with an error==EINTR, even without this series. Something to investigate. Note that this is at best 6.4 material. I have a branch stashed at [1] and based on kvmarm/next. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/timer-vm-offsets Marc Zyngier (16): arm64: Add CNTPOFF_EL2 register definition arm64: Add HAS_ECV_CNTPOFF capability kvm: arm64: Expose {un,}lock_all_vcpus() to the reset of KVM KVM: arm64: timers: Use a per-vcpu, per-timer accumulator for fractional ns KVM: arm64: timers: Convert per-vcpu virtual offset to a global value KVM: arm64: timers: Use CNTPOFF_EL2 to offset the physical timer KVM: arm64: timers: Allow physical offset without CNTPOFF_EL2 KVM: arm64: timers: Allow userspace to set the counter offsets KVM: arm64: timers: Allow save/restoring of the physical timer KVM: arm64: timers: Rationalise per-vcpu timer init KVM: arm64: Document KVM_ARM_SET_CNT_OFFSETS and co KVM: arm64: nv: timers: Add a per-timer, per-vcpu offset KVM: arm64: nv: timers: Support hyp timer emulation KVM: arm64: selftests: Add physical timer registers to the sysreg list KVM: arm64: selftests: Augment existing timer test to handle variable offsets KVM: arm64: selftests: Deal with spurious timer interrupts Documentation/virt/kvm/api.rst | 47 ++ arch/arm64/include/asm/kvm_host.h | 14 + arch/arm64/include/uapi/asm/kvm.h | 15 + arch/arm64/kernel/cpufeature.c | 11 + arch/arm64/kvm/arch_timer.c | 443 ++++++++++++++---- arch/arm64/kvm/arm.c | 47 ++ arch/arm64/kvm/guest.c | 29 +- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 18 +- arch/arm64/kvm/hypercalls.c | 2 +- arch/arm64/kvm/trace_arm.h | 6 +- arch/arm64/kvm/vgic/vgic-kvm-device.c | 38 -- arch/arm64/kvm/vgic/vgic.c | 15 + arch/arm64/kvm/vgic/vgic.h | 3 - arch/arm64/tools/cpucaps | 1 + arch/arm64/tools/sysreg | 4 + include/clocksource/arm_arch_timer.h | 1 + include/kvm/arm_arch_timer.h | 32 +- include/kvm/arm_vgic.h | 1 + include/uapi/linux/kvm.h | 3 + .../selftests/kvm/aarch64/arch_timer.c | 26 +- .../selftests/kvm/aarch64/get-reg-list.c | 5 +- 21 files changed, 603 insertions(+), 158 deletions(-) -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F79BC636CC for ; Thu, 16 Feb 2023 14:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/qtkl7H6lGxk+xi9BSGWNB86AI+bPGtstKD89fhFYJE=; b=hG9lLbU7Dzqnd9 WAE07Q9YGP+AHsaMU75JMiD8/5SnCLUzPrKQxZSHZT3aHaCq+V86wfN03MOAyqkhtZuVauZPpslu8 SMiorDl8mBplWUOyC7kO4Pn4MKEdxtHAmmUX6ZBiRFNnhLzDKQ9hMtx1iN5Y8V85plUq0LZ0/QauP vNOQGLwQwvr2sO3S79Tq2D7aNh8QlF2TgQmZTvDnhoiLuddopBnHYdEqG6vbOt1h4iz8n2iup5z/2 NSNQP1FIM7oySV0qltlyXyKR8j12pbCHdca66zPx27VdSqLjcFo/EB/od1qMDjTtf83L/yoISgSHs 4vVTjkKR8JRpYefacEzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSfAC-00Aa0T-0R; Thu, 16 Feb 2023 14:23:08 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSf99-00AZYP-EX for linux-arm-kernel@bombadil.infradead.org; Thu, 16 Feb 2023 14:22:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=0kNYObapL4zHooC4ODsz+M9H5tFgLODsqjYTwS9BAjc=; b=AgNEmR2lA226UqgRijrA6XLshX ltB0ngL7tNWOSkpd5UXoJE4RxB075O+E9dKlr/bmEFH3QUn4v/LBwIHY2L3dpRI0X1NDIejWbKBRB 8J7vutUS4mEzRKJ63YJRSaGFPN1xjfuOr0HROFWy4G+1d8oqX7dIs7txVM2RlNPb7a0snsNWP69Uj Xwipjs/ewHYFOiPIA/7czmKv7fLZmOVwPP4QpCXDCCIDl64YZKl0/g8D2FIpHmju1hjX8tYDjK/bP 0cjfnZSPfNTppZQuM7Sgta2mZBejnQGeXOVTV04iGSSk1pwee2F4jFadDE2xEm7yZUzCjtPrpG89H d5eqHh0A==; Received: from sin.source.kernel.org ([145.40.73.55]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pSf8L-00AIta-0A for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 14:22:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 54619CE2BC5; Thu, 16 Feb 2023 14:21:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC11C4339B; Thu, 16 Feb 2023 14:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676557309; bh=PIgKpAOv7CdOk3XI8N/fI6LgE9z/MAE9kl5fG7CCq9k=; h=From:To:Cc:Subject:Date:From; b=LD7E+5mPXyD8eAkRvRlmMWRpeX34fzxjC9/n3yBa8NIrpWH2y51YR62hsYTNX+R6b ZpFt2jWbF5EJomkJSAjAdHOUeAAgLetuux9xG7zdC8lYHfguT8geluSc+ypiMtqNce HcNNkTMIY2Ej5yukRG+4gHZNsofVlMLP3gK/hw6HlmTv2T78uMSEFhzLX43Smj3hUN VWMeHoLa84P8Xf6gW40so0TF0KIKq3gm9kJ1xt1rsa9siSOGcH7POscroTh8fQ5FaB BlK5ji8uIhwXXX5TWMVxkpKZpiyqlnrRkXI8I8/YVCQF9nlaSYy5qwjHba0JMnTJcy N6M+0n02S0DjA== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSf8t-00AuwB-5S; Thu, 16 Feb 2023 14:21:47 +0000 From: Marc Zyngier To: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Ricardo Koller , Simon Veith , dwmw2@infradead.org Subject: [PATCH 00/16] KVM: arm64: Rework timer offsetting for fun and profit Date: Thu, 16 Feb 2023 14:21:07 +0000 Message-Id: <20230216142123.2638675-1-maz@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, ricarkol@google.com, sveith@amazon.de, dwmw2@infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_142156_101868_25C59E2A X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series aims at satisfying multiple goals: - allow a VMM to atomically restore a timer offset for a whole VM instead of updating the offset each time a vcpu get its counter written - allow a VMM to save/restore the physical timer context, something that we cannot do at the moment due to the lack of offsetting - provide a framework that is suitable for NV support, where we get both global and per timer, per vcpu offsetting We fix a couple of issues along the way, both from a stylistic and correctness perspective. This results in a new per VM KVM API that allows a pair of global offsets to be set at any point in time, overriding the timer counter writeback. This has been moderately tested with nVHE, VHE and NV. I do not have access to CNTPOFF-aware HW, so the jury is still out on that one. Note that the NV patches in this series are here to give a perspective on how this gets used. I've updated the arch_timer selftest to allow offsets to be provided from the command line, but the arch_test is pretty flimsy and tends to fail with an error==EINTR, even without this series. Something to investigate. Note that this is at best 6.4 material. I have a branch stashed at [1] and based on kvmarm/next. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/timer-vm-offsets Marc Zyngier (16): arm64: Add CNTPOFF_EL2 register definition arm64: Add HAS_ECV_CNTPOFF capability kvm: arm64: Expose {un,}lock_all_vcpus() to the reset of KVM KVM: arm64: timers: Use a per-vcpu, per-timer accumulator for fractional ns KVM: arm64: timers: Convert per-vcpu virtual offset to a global value KVM: arm64: timers: Use CNTPOFF_EL2 to offset the physical timer KVM: arm64: timers: Allow physical offset without CNTPOFF_EL2 KVM: arm64: timers: Allow userspace to set the counter offsets KVM: arm64: timers: Allow save/restoring of the physical timer KVM: arm64: timers: Rationalise per-vcpu timer init KVM: arm64: Document KVM_ARM_SET_CNT_OFFSETS and co KVM: arm64: nv: timers: Add a per-timer, per-vcpu offset KVM: arm64: nv: timers: Support hyp timer emulation KVM: arm64: selftests: Add physical timer registers to the sysreg list KVM: arm64: selftests: Augment existing timer test to handle variable offsets KVM: arm64: selftests: Deal with spurious timer interrupts Documentation/virt/kvm/api.rst | 47 ++ arch/arm64/include/asm/kvm_host.h | 14 + arch/arm64/include/uapi/asm/kvm.h | 15 + arch/arm64/kernel/cpufeature.c | 11 + arch/arm64/kvm/arch_timer.c | 443 ++++++++++++++---- arch/arm64/kvm/arm.c | 47 ++ arch/arm64/kvm/guest.c | 29 +- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 18 +- arch/arm64/kvm/hypercalls.c | 2 +- arch/arm64/kvm/trace_arm.h | 6 +- arch/arm64/kvm/vgic/vgic-kvm-device.c | 38 -- arch/arm64/kvm/vgic/vgic.c | 15 + arch/arm64/kvm/vgic/vgic.h | 3 - arch/arm64/tools/cpucaps | 1 + arch/arm64/tools/sysreg | 4 + include/clocksource/arm_arch_timer.h | 1 + include/kvm/arm_arch_timer.h | 32 +- include/kvm/arm_vgic.h | 1 + include/uapi/linux/kvm.h | 3 + .../selftests/kvm/aarch64/arch_timer.c | 26 +- .../selftests/kvm/aarch64/get-reg-list.c | 5 +- 21 files changed, 603 insertions(+), 158 deletions(-) -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel