From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16A35C636CC for ; Thu, 16 Feb 2023 14:29:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 278C810ED8F; Thu, 16 Feb 2023 14:29:35 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id C656910ED8F for ; Thu, 16 Feb 2023 14:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676557772; x=1708093772; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+I2KAMDx037/R9NsawQn5d7tMSDPQZO0PVR+h6apQ5A=; b=V17XS5Oaac79XbJErKAi7gXtpWaohIWbujOu15Z4khJSYUBEpemqr/Yy ARihv+DKj9aHMPmCtdKLwOO5VVFit7X20P2u6tbIxQvDoTL284kNyODxm kfhpw8FlMTls7zqoRs+926/MoFdHUUjKs0fxGByC4Oy7upt17U3jBAqRO 1+oTSMLMlksPyzRPqo1n/yaL4wSVy81RFk3gNGGDicQxnGOOZsnkEz8BW 0/u4QVcVK//ubr4UgazTttnQnN9g19U/8befY0CeedT+SP80FwuyKPkG9 +nP+ttlPBBMOzLDJYMQ0Mv8UEjMmqFRoWi1QH/8QR5FB59dQBBSxi3gHQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="359158187" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="359158187" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 06:29:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="700505140" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="700505140" Received: from joe-255.igk.intel.com (HELO localhost) ([10.91.220.57]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 06:29:30 -0800 Date: Thu, 16 Feb 2023 15:29:28 +0100 From: Stanislaw Gruszka To: Oded Gabbay Subject: Re: [PATCH 18/27] habanalabs: change user interrupt to threaded IRQ Message-ID: <20230216142928.GG2849548@linux.intel.com> References: <20230212204454.2938561-1-ogabbay@kernel.org> <20230212204454.2938561-18-ogabbay@kernel.org> <20230216102821.GA2849548@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tal Cohen , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 16, 2023 at 03:47:44PM +0200, Oded Gabbay wrote: > On Thu, Feb 16, 2023 at 12:28 PM Stanislaw Gruszka > wrote: > > > > Hi > > > > On Sun, Feb 12, 2023 at 10:44:45PM +0200, Oded Gabbay wrote: > > > > > irqreturn_t hl_irq_handler_user_interrupt(int irq, void *arg) > > > +{ > > > + return IRQ_WAKE_THREAD; > > > +} > > > > This is not needed. You can pass NULL to request_threaded_irq() and > > the irq core will use irq_default_primary_handler() which is exactly > > the same function :-) > > > > Regards > > Stanislaw > > > > > You are correct but in patch 19/27 (the one after this), this function > is filled with actual code, so I don't know if it's worth changing > this patch... I see, no need to change this patch if the function will be extended. Regards Stanislaw