From: Florian Eckert <fe@dev.tdt.de>
To: u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Eckert.Florian@googlemail.com
Subject: [PATCH v2 0/2] leds: ledtrig-tty: add tty_led_mode xtension
Date: Fri, 17 Feb 2023 10:44:01 +0100 [thread overview]
Message-ID: <20230217094403.1574468-1-fe@dev.tdt.de> (raw)
Hello,
here commes v2 of this series to add additional tty_led_modes.
Changes compared to the initial patchset with
20230213140638.620206-1-fe@dev.tdt.de are.
Addressed review comments by Jiri Slaby are:
tty.h:
- Fix compilation error because of wrong rebaseing
- Remove empty lines
- Use new 'tty_get_mget' in 'tty_tiocmget'
ledtrg-tty.c:
- Update commit description
- Use enum for tty_led_mod in struct ledtrig_tty_date
- Rename sysfs file from 'mode' to 'tty_led_mode'
- Change tty_led_mode show function to use loop instead of switch/case
- Change tty_led_mode store function to use loop instead of switch/case
- Check return value of function tty_get_mget
Florian Eckert (2):
tty: new helper function tty_get_mget
trigger: ledtrig-tty: add additional modes
.../ABI/testing/sysfs-class-led-trigger-tty | 16 ++
drivers/leds/trigger/ledtrig-tty.c | 146 ++++++++++++++++--
drivers/tty/tty_io.c | 30 +++-
include/linux/tty.h | 1 +
4 files changed, 171 insertions(+), 22 deletions(-)
--
2.30.2
next reply other threads:[~2023-02-17 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 9:44 Florian Eckert [this message]
2023-02-17 9:44 ` [PATCH v2 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-17 9:49 ` Greg KH
2023-02-17 9:44 ` [PATCH v2 2/2] trigger: ledtrig-tty: add additional modes Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217094403.1574468-1-fe@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.