From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90BB5C05027 for ; Fri, 17 Feb 2023 13:51:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F80CF21; Fri, 17 Feb 2023 14:51:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F80CF21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676641914; bh=wo9leP4z+3lq2c8RvEbXWZDwVdn9gtko4armAoJhFVo=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ScJ2LOTWAe095SH1YuLrkhH3AlFM7YLXHNyQHdp+lyb1nJMaDqFS+IZShtl0fHAFQ ECZcZa57SliDTOOB6H3/W4amXv19Gy7Y0xAvFQJoUx1PgVxTbF/djryaqlNDU8zggA iP2dyA9d8lqhQ+GHGKTWMHTQnYumCWnGEe7QaO8U= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0CD48F800E4; Fri, 17 Feb 2023 14:50:39 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31E24F80171; Fri, 17 Feb 2023 14:50:35 +0100 (CET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9A04AF80083 for ; Fri, 17 Feb 2023 14:50:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9A04AF80083 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=RoBsXKNP Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 47F6B60003; Fri, 17 Feb 2023 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676641825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXtty5j4EPkHzMourS16qE5SNRSNmBZzzykreudpYyw=; b=RoBsXKNPDSFIw+waIM9X3bayblvPaLqhufkZQmycFa7Xnrs3aTpCAWzjhfnGtitb8+V2N1 7lvs3fA9mB2xffWdKYEEfQNqEKifHKxSneXjI8wUgFitrhpYd/n+2eAtt+u9wdBpmfiF99 3+IsOBT6U1N4DOFMFnmQspVrm+xBGluGmi55YzwE/u8kJufXbbl+0bmekuU9Xl8KhAW5EU AVXU7Vb/pZ14cC+S+t5i+AZPWyZoqSPusgF7ggwvHd6IDqZnmrk8/AarNmkNGQDl6tIZJP kmwG5k2P/GWE4TNLz5ynqio6byKJqgjXOVaFfHowgpEcNTsKLnSWj+XNN8tEKQ== Date: Fri, 17 Feb 2023 14:50:19 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v5 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230217145019.0def6f9a@bootlin.com> In-Reply-To: <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> References: <20230216134226.1692107-1-herve.codina@bootlin.com> <20230216134226.1692107-2-herve.codina@bootlin.com> <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Q5SDUYAWVBOK63OYPGMHBHNFQBIB4KYJ X-Message-ID-Hash: Q5SDUYAWVBOK63OYPGMHBHNFQBIB4KYJ X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Krzysztof, On Fri, 17 Feb 2023 10:14:48 +0100 Krzysztof Kozlowski wrote: > On 16/02/2023 14:42, Herve Codina wrote: > > Add support for the time slot assigner (TSA) > > available in some PowerQUICC SoC such as MPC885 > > or MPC866. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-tsa.yaml | 234 ++++++++++++++++++ > > include/dt-bindings/soc/fsl,tsa.h | 13 + > > 2 files changed, 247 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,cpm1-tsa.yaml > > create mode 100644 include/dt-bindings/soc/fsl,tsa.h [...] > > + > > +patternProperties: > > + '^tdm@[0-1]$': > > + description: > > + The TDM managed by this controller > > + type: object > > + > > + additionalProperties: false > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > + description: > > + The TDM number for this TDM, 0 for TDMa and 1 for TDMb [...] > > + > > + fsl,rx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] =20 >=20 > maxItems: 1 The property is an enum Why this maxItems value ? If I add the maxItems value, I've got some dt_binding_check errors: /xxxx/bindings/soc/fsl/cpm_qe/fsl,cpm1-tsa.yaml: patternProperties:^tdm@[0-1]$:properties:fsl,rx-frame-sync-delay-bits: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMax= imum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# >=20 > > + default: 0 > > + description: | > > + Receive frame sync delay in number of bits. > > + Indicates the delay between the Rx sync and the first bit of= the Rx > > + frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits dela= y. > > + > > + fsl,tx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] =20 >=20 > maxItems: 1 Same question here. Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A56FDC64EC4 for ; Fri, 17 Feb 2023 13:51:35 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PJCsK6f0Kz3fBH for ; Sat, 18 Feb 2023 00:51:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=RoBsXKNP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::223; helo=relay3-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=RoBsXKNP; dkim-atps=neutral Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PJCrF5GHCz3cfl for ; Sat, 18 Feb 2023 00:50:34 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 47F6B60003; Fri, 17 Feb 2023 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676641825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXtty5j4EPkHzMourS16qE5SNRSNmBZzzykreudpYyw=; b=RoBsXKNPDSFIw+waIM9X3bayblvPaLqhufkZQmycFa7Xnrs3aTpCAWzjhfnGtitb8+V2N1 7lvs3fA9mB2xffWdKYEEfQNqEKifHKxSneXjI8wUgFitrhpYd/n+2eAtt+u9wdBpmfiF99 3+IsOBT6U1N4DOFMFnmQspVrm+xBGluGmi55YzwE/u8kJufXbbl+0bmekuU9Xl8KhAW5EU AVXU7Vb/pZ14cC+S+t5i+AZPWyZoqSPusgF7ggwvHd6IDqZnmrk8/AarNmkNGQDl6tIZJP kmwG5k2P/GWE4TNLz5ynqio6byKJqgjXOVaFfHowgpEcNTsKLnSWj+XNN8tEKQ== Date: Fri, 17 Feb 2023 14:50:19 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v5 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230217145019.0def6f9a@bootlin.com> In-Reply-To: <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> References: <20230216134226.1692107-1-herve.codina@bootlin.com> <20230216134226.1692107-2-herve.codina@bootlin.com> <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Krzysztof, On Fri, 17 Feb 2023 10:14:48 +0100 Krzysztof Kozlowski wrote: > On 16/02/2023 14:42, Herve Codina wrote: > > Add support for the time slot assigner (TSA) > > available in some PowerQUICC SoC such as MPC885 > > or MPC866. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-tsa.yaml | 234 ++++++++++++++++++ > > include/dt-bindings/soc/fsl,tsa.h | 13 + > > 2 files changed, 247 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,cpm1-tsa.yaml > > create mode 100644 include/dt-bindings/soc/fsl,tsa.h [...] > > + > > +patternProperties: > > + '^tdm@[0-1]$': > > + description: > > + The TDM managed by this controller > > + type: object > > + > > + additionalProperties: false > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > + description: > > + The TDM number for this TDM, 0 for TDMa and 1 for TDMb [...] > > + > > + fsl,rx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] =20 >=20 > maxItems: 1 The property is an enum Why this maxItems value ? If I add the maxItems value, I've got some dt_binding_check errors: /xxxx/bindings/soc/fsl/cpm_qe/fsl,cpm1-tsa.yaml: patternProperties:^tdm@[0-1]$:properties:fsl,rx-frame-sync-delay-bits: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMax= imum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# >=20 > > + default: 0 > > + description: | > > + Receive frame sync delay in number of bits. > > + Indicates the delay between the Rx sync and the first bit of= the Rx > > + frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits dela= y. > > + > > + fsl,tx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] =20 >=20 > maxItems: 1 Same question here. Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65392C05027 for ; Fri, 17 Feb 2023 13:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=suSW+n7L7fCVH/GfHwD49hR+JIAAD5PQrC8OmZOb+PQ=; b=FHrWE+Dh6nWy3K sWRYoPKXPqrJO/dvKtcbPpubfox8mo0M6KRPP6m/n63qjC1v5X6hPoDMcXjmlF1oxS3qNfgpirrJg QvOrV1kkS8bbGz7y39W7vhaDDKlDfaURSpSKe99p3K6DsIamTKL2ljWe2kYbq9Unas7snGYz8H3Pq jcm2GiHC04eb7nqGGi/e3EdvqVImWyLhSFQpbJjiFLpYEYQEDXYR/1Ll1M6cTLThXtNGqoxYd7OFe A0jyEHhego/0/41Fynjl95A4MjXj812IHbIWngQzkiqXmqTJZ3v/FhzbeBe29WMuBQyly3sDkJLSA aUhPvFYOxvawc6qVxdzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT18F-00EPvV-OI; Fri, 17 Feb 2023 13:50:35 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT18A-00EPtf-Ul for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2023 13:50:33 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 47F6B60003; Fri, 17 Feb 2023 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676641825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXtty5j4EPkHzMourS16qE5SNRSNmBZzzykreudpYyw=; b=RoBsXKNPDSFIw+waIM9X3bayblvPaLqhufkZQmycFa7Xnrs3aTpCAWzjhfnGtitb8+V2N1 7lvs3fA9mB2xffWdKYEEfQNqEKifHKxSneXjI8wUgFitrhpYd/n+2eAtt+u9wdBpmfiF99 3+IsOBT6U1N4DOFMFnmQspVrm+xBGluGmi55YzwE/u8kJufXbbl+0bmekuU9Xl8KhAW5EU AVXU7Vb/pZ14cC+S+t5i+AZPWyZoqSPusgF7ggwvHd6IDqZnmrk8/AarNmkNGQDl6tIZJP kmwG5k2P/GWE4TNLz5ynqio6byKJqgjXOVaFfHowgpEcNTsKLnSWj+XNN8tEKQ== Date: Fri, 17 Feb 2023 14:50:19 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v5 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230217145019.0def6f9a@bootlin.com> In-Reply-To: <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> References: <20230216134226.1692107-1-herve.codina@bootlin.com> <20230216134226.1692107-2-herve.codina@bootlin.com> <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_055031_324946_52C62F8B X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gRnJpLCAxNyBGZWIgMjAyMyAxMDoxNDo0OCArMDEwMApLcnp5c3p0 b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBP biAxNi8wMi8yMDIzIDE0OjQyLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBBZGQgc3VwcG9ydCBm b3IgdGhlIHRpbWUgc2xvdCBhc3NpZ25lciAoVFNBKQo+ID4gYXZhaWxhYmxlIGluIHNvbWUgUG93 ZXJRVUlDQyBTb0Mgc3VjaCBhcyBNUEM4ODUKPiA+IG9yIE1QQzg2Ni4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9vdGxpbi5jb20+Cj4gPiAtLS0K PiA+ICAuLi4vYmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLGNwbTEtdHNhLnlhbWwgfCAyMzQg KysrKysrKysrKysrKysrKysrCj4gPiAgaW5jbHVkZS9kdC1iaW5kaW5ncy9zb2MvZnNsLHRzYS5o ICAgICAgICAgICAgIHwgIDEzICsKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDI0NyBpbnNlcnRpb25z KCspCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9zb2MvZnNsL2NwbV9xZS9mc2wsY3BtMS10c2EueWFtbAo+ID4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBpbmNsdWRlL2R0LWJpbmRpbmdzL3NvYy9mc2wsdHNhLmgKClsuLi5dCj4gPiArCj4gPiAr cGF0dGVyblByb3BlcnRpZXM6Cj4gPiArICAnXnRkbUBbMC0xXSQnOgo+ID4gKyAgICBkZXNjcmlw dGlvbjoKPiA+ICsgICAgICBUaGUgVERNIG1hbmFnZWQgYnkgdGhpcyBjb250cm9sbGVyCj4gPiAr ICAgIHR5cGU6IG9iamVjdAo+ID4gKwo+ID4gKyAgICBhZGRpdGlvbmFsUHJvcGVydGllczogZmFs c2UKPiA+ICsKPiA+ICsgICAgcHJvcGVydGllczoKPiA+ICsgICAgICByZWc6Cj4gPiArICAgICAg ICBtaW5pbXVtOiAwCj4gPiArICAgICAgICBtYXhpbXVtOiAxCj4gPiArICAgICAgICBkZXNjcmlw dGlvbjoKPiA+ICsgICAgICAgICAgVGhlIFRETSBudW1iZXIgZm9yIHRoaXMgVERNLCAwIGZvciBU RE1hIGFuZCAxIGZvciBURE1iClsuLi5dCj4gPiArCj4gPiArICAgICAgZnNsLHJ4LWZyYW1lLXN5 bmMtZGVsYXktYml0czoKPiA+ICsgICAgICAgIGVudW06IFswLCAxLCAyLCAzXSAgCj4gCj4gbWF4 SXRlbXM6IDEKClRoZSBwcm9wZXJ0eSBpcyBhbiBlbnVtCldoeSB0aGlzIG1heEl0ZW1zIHZhbHVl ID8KCklmIEkgYWRkIHRoZSBtYXhJdGVtcyB2YWx1ZSwgSSd2ZSBnb3Qgc29tZSBkdF9iaW5kaW5n X2NoZWNrIGVycm9yczoKICAveHh4eC9iaW5kaW5ncy9zb2MvZnNsL2NwbV9xZS9mc2wsY3BtMS10 c2EueWFtbDoKICBwYXR0ZXJuUHJvcGVydGllczpedGRtQFswLTFdJDpwcm9wZXJ0aWVzOmZzbCxy eC1mcmFtZS1zeW5jLWRlbGF5LWJpdHM6CiAgJ2VudW0nIHNob3VsZCBub3QgYmUgdmFsaWQgdW5k ZXIgeydlbnVtJzogWydjb25zdCcsICdlbnVtJywgJ2V4Y2x1c2l2ZU1heGltdW0nLCAnZXhjbHVz aXZlTWluaW11bScsICdtaW5pbXVtJywgJ21heGltdW0nLCAnbXVsdGlwbGVPZicsICdwYXR0ZXJu J119CgloaW50OiBTY2FsYXIgYW5kIGFycmF5IGtleXdvcmRzIGNhbm5vdCBiZSBtaXhlZAoJZnJv bSBzY2hlbWEgJGlkOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvbWV0YS1zY2hlbWFzL2tleXdvcmRz LnlhbWwjCgo+IAo+ID4gKyAgICAgICAgZGVmYXVsdDogMAo+ID4gKyAgICAgICAgZGVzY3JpcHRp b246IHwKPiA+ICsgICAgICAgICAgUmVjZWl2ZSBmcmFtZSBzeW5jIGRlbGF5IGluIG51bWJlciBv ZiBiaXRzLgo+ID4gKyAgICAgICAgICBJbmRpY2F0ZXMgdGhlIGRlbGF5IGJldHdlZW4gdGhlIFJ4 IHN5bmMgYW5kIHRoZSBmaXJzdCBiaXQgb2YgdGhlIFJ4Cj4gPiArICAgICAgICAgIGZyYW1lLiAw IGZvciBubyBiaXQgZGVsYXkuIDEsIDIgb3IgMyBmb3IgMSwgMiBvciAzIGJpdHMgZGVsYXkuCj4g PiArCj4gPiArICAgICAgZnNsLHR4LWZyYW1lLXN5bmMtZGVsYXktYml0czoKPiA+ICsgICAgICAg IGVudW06IFswLCAxLCAyLCAzXSAgCj4gCj4gbWF4SXRlbXM6IDEKClNhbWUgcXVlc3Rpb24gaGVy ZS4KCgpUaGFua3MgZm9yIHRoZSByZXZpZXcsCgpIZXJ2w6kKLS0gCkhlcnbDqSBDb2RpbmEsIEJv b3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3Rs aW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A1CFC05027 for ; Fri, 17 Feb 2023 13:51:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbjBQNvV (ORCPT ); Fri, 17 Feb 2023 08:51:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjBQNvI (ORCPT ); Fri, 17 Feb 2023 08:51:08 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFC9F692A9; Fri, 17 Feb 2023 05:50:29 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 47F6B60003; Fri, 17 Feb 2023 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676641825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IXtty5j4EPkHzMourS16qE5SNRSNmBZzzykreudpYyw=; b=RoBsXKNPDSFIw+waIM9X3bayblvPaLqhufkZQmycFa7Xnrs3aTpCAWzjhfnGtitb8+V2N1 7lvs3fA9mB2xffWdKYEEfQNqEKifHKxSneXjI8wUgFitrhpYd/n+2eAtt+u9wdBpmfiF99 3+IsOBT6U1N4DOFMFnmQspVrm+xBGluGmi55YzwE/u8kJufXbbl+0bmekuU9Xl8KhAW5EU AVXU7Vb/pZ14cC+S+t5i+AZPWyZoqSPusgF7ggwvHd6IDqZnmrk8/AarNmkNGQDl6tIZJP kmwG5k2P/GWE4TNLz5ynqio6byKJqgjXOVaFfHowgpEcNTsKLnSWj+XNN8tEKQ== Date: Fri, 17 Feb 2023 14:50:19 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v5 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Message-ID: <20230217145019.0def6f9a@bootlin.com> In-Reply-To: <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> References: <20230216134226.1692107-1-herve.codina@bootlin.com> <20230216134226.1692107-2-herve.codina@bootlin.com> <6ae9af19-1d52-c31f-79be-a36f06caaf80@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Fri, 17 Feb 2023 10:14:48 +0100 Krzysztof Kozlowski wrote: > On 16/02/2023 14:42, Herve Codina wrote: > > Add support for the time slot assigner (TSA) > > available in some PowerQUICC SoC such as MPC885 > > or MPC866. > >=20 > > Signed-off-by: Herve Codina > > --- > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-tsa.yaml | 234 ++++++++++++++++++ > > include/dt-bindings/soc/fsl,tsa.h | 13 + > > 2 files changed, 247 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fs= l,cpm1-tsa.yaml > > create mode 100644 include/dt-bindings/soc/fsl,tsa.h [...] > > + > > +patternProperties: > > + '^tdm@[0-1]$': > > + description: > > + The TDM managed by this controller > > + type: object > > + > > + additionalProperties: false > > + > > + properties: > > + reg: > > + minimum: 0 > > + maximum: 1 > > + description: > > + The TDM number for this TDM, 0 for TDMa and 1 for TDMb [...] > > + > > + fsl,rx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] =20 >=20 > maxItems: 1 The property is an enum Why this maxItems value ? If I add the maxItems value, I've got some dt_binding_check errors: /xxxx/bindings/soc/fsl/cpm_qe/fsl,cpm1-tsa.yaml: patternProperties:^tdm@[0-1]$:properties:fsl,rx-frame-sync-delay-bits: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMax= imum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# >=20 > > + default: 0 > > + description: | > > + Receive frame sync delay in number of bits. > > + Indicates the delay between the Rx sync and the first bit of= the Rx > > + frame. 0 for no bit delay. 1, 2 or 3 for 1, 2 or 3 bits dela= y. > > + > > + fsl,tx-frame-sync-delay-bits: > > + enum: [0, 1, 2, 3] =20 >=20 > maxItems: 1 Same question here. Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com