Re: [Buildroot] [PATCH] python-wheel: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Nasser,

Thanks for the contribution, and sorry for the very slow feedback :-/

On Tue, 25 Oct 2022 10:23:56 +0330
Nasser Afshin <afshin.nasser@gmail.com> wrote:

> Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>
> ---
>  package/Config.in                      |  1 +
>  package/python-wheel/Config.in         | 15 +++++++++++++++
>  package/python-wheel/python-wheel.hash |  5 +++++
>  package/python-wheel/python-wheel.mk   | 14 ++++++++++++++
>  4 files changed, 35 insertions(+)
>  create mode 100644 package/python-wheel/Config.in
>  create mode 100644 package/python-wheel/python-wheel.hash
>  create mode 100644 package/python-wheel/python-wheel.mk

Could you give some details on the use case for python-wheels on the
target?

Also, could you add an entry to the DEVELOPERS file?

In addition, for Python packages, we really like to have a runtime test
in support/testing/. Could you have a look into this?


>  	source "package/python-ws4py/Config.in"
> diff --git a/package/python-wheel/Config.in b/package/python-wheel/Config.in
> new file mode 100644
> index 0000000000..225d7529a4
> --- /dev/null
> +++ b/package/python-wheel/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_PYTHON_WHEEL
> +	bool "python-wheel"
> +	help
> +      This library is the reference implementation of the Python wheel
> +      packaging standard, as defined in PEP 427.
> +
> +        It has two different roles:
> +            1. A setuptools extension for building wheels that provides the bdist_wheel
> +            setuptools command
> +            2. A command line tool for working with wheel files
> +
> +        It should be noted that wheel is not intended to be used as a library, and as
> +        such there is no stable, public API.
> +
> +          https://github.com/pypa/wheel

The indentation is not correct. Could you run "make check-package" and
make sure there are no warnings?


> index 0000000000..d8fab54867
> --- /dev/null
> +++ b/package/python-wheel/python-wheel.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-wheel
> +#
> +################################################################################
> +
> +PYTHON_WHEEL_VERSION = 0.37.1
> +PYTHON_WHEEL_SOURCE = wheel-$(PYTHON_WHEEL_VERSION).tar.gz
> +PYTHON_WHEEL_SITE = https://files.pythonhosted.org/packages/c0/6c/9f840c2e55b67b90745af06a540964b73589256cb10cc10057c87ac78fc2
> +PYTHON_WHEEL_SETUP_TYPE = distutils

Are you sure? It seems to be using setuptools. Could you double check
this?

Could you fix this and resend, as a new patch sent with "git
send-email" (and not in the middle of a reply, like you did for
python-pycrate, which was not good)?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot