From: kernel test robot <lkp@intel.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 11/12] tpm: add the null key name as a sysfs export
Date: Fri, 17 Feb 2023 18:59:09 +0800 [thread overview]
Message-ID: <202302171852.zpg5jNaj-lkp@intel.com> (raw)
In-Reply-To: <93740b6b42e67caa2a1854520b7e68f0966e5024.camel@HansenPartnership.com>
Hi James,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus herbert-cryptodev-2.6/master linus/master v6.2-rc8 next-20230217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/James-Bottomley/crypto-lib-implement-library-version-of-AES-in-CFB-mode/20230217-044329
patch link: https://lore.kernel.org/r/93740b6b42e67caa2a1854520b7e68f0966e5024.camel%40HansenPartnership.com
patch subject: [PATCH 11/12] tpm: add the null key name as a sysfs export
config: nios2-randconfig-m041-20230217 (https://download.01.org/0day-ci/archive/20230217/202302171852.zpg5jNaj-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4c35ecc57dfd3fd82341cd20dfc30c5f665ba952
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review James-Bottomley/crypto-lib-implement-library-version-of-AES-in-CFB-mode/20230217-044329
git checkout 4c35ecc57dfd3fd82341cd20dfc30c5f665ba952
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/char/tpm/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302171852.zpg5jNaj-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/char/tpm/tpm-sysfs.c:344:5: warning: "CONFIG_TPM_BUS_SECURITY" is not defined, evaluates to 0 [-Wundef]
344 | #if CONFIG_TPM_BUS_SECURITY
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/CONFIG_TPM_BUS_SECURITY +344 drivers/char/tpm/tpm-sysfs.c
341
342 static struct attribute *tpm2_dev_attrs[] = {
343 &dev_attr_tpm_version_major.attr,
> 344 #if CONFIG_TPM_BUS_SECURITY
345 &dev_attr_null_name.attr,
346 #endif
347 NULL
348 };
349
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-17 11:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 20:13 [PATCH 00/12] add integrity and security to TPM2 transactions James Bottomley
2023-02-16 20:13 ` [PATCH 01/12] crypto: lib - implement library version of AES in CFB mode James Bottomley
2023-02-27 7:47 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 02/12] tpm: move buffer handling from static inlines to real functions James Bottomley
2023-02-27 8:18 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 03/12] tpm: add buffer handling for TPM2B types James Bottomley
2023-02-27 8:31 ` Jarkko Sakkinen
2023-03-28 19:42 ` James Bottomley
2023-02-16 20:14 ` [PATCH 04/12] tpm: add cursor based buffer functions for response parsing James Bottomley
2023-02-27 8:34 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 05/12] tpm: add buffer function to point to returned parameters James Bottomley
2023-02-27 8:36 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 06/12] tpm: export the context save and load commands James Bottomley
2023-02-27 8:37 ` Jarkko Sakkinen
2023-04-03 16:54 ` James Bottomley
2023-02-16 20:14 ` [PATCH 07/12] tpm: Add full HMAC and encrypt/decrypt session handling code James Bottomley
2023-02-16 23:37 ` kernel test robot
2023-02-17 11:30 ` kernel test robot
2023-02-17 14:22 ` James Bottomley
2023-02-17 14:23 ` Ard Biesheuvel
2023-02-16 20:14 ` [PATCH 08/12] tpm: add hmac checks to tpm2_pcr_extend() James Bottomley
2023-02-27 9:16 ` Jarkko Sakkinen
2023-02-16 20:14 ` [PATCH 09/12] tpm: add session encryption protection to tpm2_get_random() James Bottomley
2023-02-16 20:14 ` [PATCH 10/12] KEYS: trusted: Add session encryption protection to the seal/unseal path James Bottomley
2023-02-16 20:40 ` [PATCH 11/12] tpm: add the null key name as a sysfs export James Bottomley
2023-02-17 10:59 ` kernel test robot [this message]
2023-02-16 20:41 ` [PATCH 12/12] Documentation: add tpm-security.rst James Bottomley
2023-02-17 22:43 ` [PATCH 00/12] add integrity and security to TPM2 transactions Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302171852.zpg5jNaj-lkp@intel.com \
--to=lkp@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.