All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Borislav Petkov <bp@suse.de>,
	Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
	Suraj Jitindar Singh <surajjs@amazon.com>,
	Suleiman Souhlal <suleiman@google.com>
Subject: [stable:linux-4.19.y 4340/5220] arch/x86/kvm/vmx.c:10763:1: warning: 'inline' is not at beginning of declaration
Date: Fri, 17 Feb 2023 21:35:19 +0800	[thread overview]
Message-ID: <202302172129.LCWCNLUT-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y
head:   53b696f0584acce2e90db69272a2a11aab138370
commit: e6ac9561776a1fa80e245993f94c8f63fa15632b [4340/5220] KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS
config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20230217/202302172129.LCWCNLUT-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=e6ac9561776a1fa80e245993f94c8f63fa15632b
        git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
        git fetch --no-tags stable linux-4.19.y
        git checkout e6ac9561776a1fa80e245993f94c8f63fa15632b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302172129.LCWCNLUT-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/x86/kvm/vmx.c: In function 'allow_1_setting':
   arch/x86/kvm/vmx.c:4532:13: warning: variable 'vmx_msr_low' set but not used [-Wunused-but-set-variable]
    4532 |         u32 vmx_msr_low, vmx_msr_high;
         |             ^~~~~~~~~~~
   arch/x86/kvm/vmx.c: At top level:
>> arch/x86/kvm/vmx.c:10763:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
   10763 | u64 __always_inline vmx_spec_ctrl_restore_host(struct vcpu_vmx *vmx)
         | ^~~
   arch/x86/kvm/vmx.c: In function 'vmx_set_msr':
   arch/x86/kvm/vmx.c:4359:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
    4359 |                 if ((data >> 32) != 0)
         |                    ^
   arch/x86/kvm/vmx.c:4362:9: note: here
    4362 |         default:
         |         ^~~~~~~
   arch/x86/kvm/vmx.c: In function 'vmx_get_msr':
   arch/x86/kvm/vmx.c:4174:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
    4174 |                 if (!msr_info->host_initiated &&
         |                    ^
   arch/x86/kvm/vmx.c:4178:9: note: here
    4178 |         default:
         |         ^~~~~~~


vim +/inline +10763 arch/x86/kvm/vmx.c

 10762	
 10763	u64 __always_inline vmx_spec_ctrl_restore_host(struct vcpu_vmx *vmx)
 10764	{
 10765		u64 guestval, hostval = this_cpu_read(x86_spec_ctrl_current);
 10766	
 10767		if (!cpu_feature_enabled(X86_FEATURE_MSR_SPEC_CTRL))
 10768			return 0;
 10769	
 10770		guestval = __rdmsr(MSR_IA32_SPEC_CTRL);
 10771	
 10772		/*
 10773		 * If the guest/host SPEC_CTRL values differ, restore the host value.
 10774		 */
 10775		if (guestval != hostval)
 10776			native_wrmsrl(MSR_IA32_SPEC_CTRL, hostval);
 10777	
 10778		barrier_nospec();
 10779	
 10780		return guestval;
 10781	}
 10782	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

                 reply	other threads:[~2023-02-17 13:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202302172129.LCWCNLUT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bp@suse.de \
    --cc=cascardo@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jpoimboe@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=suleiman@google.com \
    --cc=surajjs@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.