From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CDFBC05027 for ; Fri, 17 Feb 2023 22:46:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A64B58595D; Fri, 17 Feb 2023 23:46:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="FE1V1sFg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 033DA8595D; Fri, 17 Feb 2023 23:46:08 +0100 (CET) Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42DAB85A18 for ; Fri, 17 Feb 2023 23:45:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x131.google.com with SMTP id j23so827459ila.5 for ; Fri, 17 Feb 2023 14:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5i9fxNhllRPWlnublN1YagFS3aqFygzGOZUgT2TW4r8=; b=FE1V1sFg1v9S6xdFnL1Judza+/IpEQ5j2l1k0WwFaTIFAtv7WiQMXnidO9K9uZkXlY JLHevOqXT7KH3GHorSuIJQH6k1CbaXCYBMPwPwAMcZ8cupthNr0IUqXuhgVRJulrG85A xOdzOqMpURDYPwLPvSfLAijlf+IQmO3dGkUMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5i9fxNhllRPWlnublN1YagFS3aqFygzGOZUgT2TW4r8=; b=3aN1JLZq9CoK1WeZco1u52KOXcYBkz9P6yLEXIEjjiKSbOf35r8L0M+7uC7jTTmD60 /4ZR0ujNm/X2tfp7fjJzeTLG+nrQCnBZ10N0bKcvSALZHqcuqtwGodhgO7FtitCXT6b+ R+7TdBflT31aHpbx99PpbrxQ0esJuuWh6dU7Z+iWa94TJovClqK6figDtxJe6gRN58d0 lvhXQmV2OteZqJwFpT6ojoLBoQjwSEwWso24h/R7ApnzlWPdF+ElykLlS4sYXANs6gTu L4WcDgFzLzRL51L6Bd+jdsTZCQ+GfSnwbh1mh6/KLmxro/86wGZgBtPDOqs1Y/LEVyzB eWMQ== X-Gm-Message-State: AO0yUKWX1IrQVMsyWmPK0U4eDPWYBRBbqdjGdcd3fiGHNQENMxZyWMnq /XPFp5UcO9bh6QF4Ujk8LdqNbMX4haeSjHN7 X-Google-Smtp-Source: AK7set9ejQb7DDQOY+XJxyFzmZWP6lgrAvT7fWPxKb35FTOtHCfHdtGgdBrUfml+lQXCrVr2Gf4QfA== X-Received: by 2002:a05:6e02:164b:b0:316:ac06:f675 with SMTP id v11-20020a056e02164b00b00316ac06f675mr978105ilu.18.1676673951942; Fri, 17 Feb 2023 14:45:51 -0800 (PST) Received: from sjg1.roam.corp.google.com (c-73-14-173-85.hsd1.co.comcast.net. [73.14.173.85]) by smtp.gmail.com with ESMTPSA id f4-20020a056e0204c400b00315487d58ecsm1670098ils.53.2023.02.17.14.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 14:45:51 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Simon Glass , Anatolij Gustschin , Heinrich Schuchardt , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Stefan Roese Subject: [PATCH] sandbox: video: Fix building without SDL Date: Fri, 17 Feb 2023 15:45:47 -0700 Message-Id: <20230217224547.1647994-1-sjg@chromium.org> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean This is currently broken. If SDL is not installed, SANDBOX_SDL becomes false and build errors are generated, e.g.: test/dm/video.c:424: undefined reference to `sandbox_sdl_set_bpp' Fix it by making the function return an error in this case. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/test.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/sandbox/include/asm/test.h b/arch/sandbox/include/asm/test.h index 4853dc948f3..e482271fe97 100644 --- a/arch/sandbox/include/asm/test.h +++ b/arch/sandbox/include/asm/test.h @@ -300,6 +300,7 @@ void sandbox_cros_ec_set_test_flags(struct udevice *dev, uint flags); */ int sandbox_cros_ec_get_pwm_duty(struct udevice *dev, uint index, uint *duty); +#if IS_ENABLED(CONFIG_SANDBOX_SDL) /** * sandbox_sdl_set_bpp() - Set the depth of the sandbox display * @@ -315,6 +316,13 @@ int sandbox_cros_ec_get_pwm_duty(struct udevice *dev, uint index, uint *duty); * after the change */ int sandbox_sdl_set_bpp(struct udevice *dev, enum video_log2_bpp l2bpp); +#else +static inline int sandbox_sdl_set_bpp(struct udevice *dev, + enum video_log2_bpp l2bpp) +{ + return -ENOSYS; +} +#endif /** * sandbox_set_fake_efi_mgr_dev() - Control EFI bootmgr producing valid bootflow -- 2.39.2.637.g21b0678d19-goog