From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: [net-next V2 9/9] net/mlx5e: RX, Remove doubtful unlikely call
Date: Sat, 18 Feb 2023 01:05:13 -0800 [thread overview]
Message-ID: <20230218090513.284718-10-saeed@kernel.org> (raw)
In-Reply-To: <20230218090513.284718-1-saeed@kernel.org>
From: Gal Pressman <gal@nvidia.com>
When building an skb in non-linear mode, it is not likely nor unlikely
that the xdp buff has fragments, it depends on the size of the packet
received.
Signed-off-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
index 8e64f4b48d53..15d9932f741d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
@@ -1718,7 +1718,7 @@ mlx5e_skb_from_cqe_nonlinear(struct mlx5e_rq *rq, struct mlx5e_wqe_frag_info *wi
page_ref_inc(head_wi->au->page);
- if (unlikely(xdp_buff_has_frags(&mxbuf.xdp))) {
+ if (xdp_buff_has_frags(&mxbuf.xdp)) {
int i;
/* sinfo->nr_frags is reset by build_skb, calculate again. */
--
2.39.1
prev parent reply other threads:[~2023-02-18 9:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 9:05 [pull request][net-next V2 0/9] mlx5 updates 2023-02-15 Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 1/9] net/mlx5e: Switch to using napi_build_skb() Saeed Mahameed
2023-02-21 1:00 ` patchwork-bot+netdevbpf
2023-02-18 9:05 ` [net-next V2 2/9] net/mlx5e: Remove redundant page argument in mlx5e_xmit_xdp_buff() Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 3/9] net/mlx5e: Remove redundant page argument in mlx5e_xdp_handle() Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 4/9] net/mlx5: Simplify eq list traversal Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 5/9] net/mlx5e: Implement CT entry update Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 6/9] net/mlx5e: Allow offloading of ct 'new' match Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 7/9] net/mlx5e: Remove unused function mlx5e_sq_xmit_simple Saeed Mahameed
2023-02-18 9:05 ` [net-next V2 8/9] net/mlx5e: Fix outdated TLS comment Saeed Mahameed
2023-02-18 9:05 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230218090513.284718-10-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.