From: Tom Rix <trix@redhat.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, steen.hegelund@microchip.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error
Date: Sun, 19 Feb 2023 10:03:21 -0500 [thread overview]
Message-ID: <20230219150321.2683358-1-trix@redhat.com> (raw)
A rand config causes this link error
drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'
lan743x_netdev_open is controlled by LAN743X
fixed_phy_register is controlled by FIXED_PHY
So LAN743X should also select FIXED_PHY
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/microchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
index 24c994baad13..43ba71e82260 100644
--- a/drivers/net/ethernet/microchip/Kconfig
+++ b/drivers/net/ethernet/microchip/Kconfig
@@ -47,6 +47,7 @@ config LAN743X
depends on PCI
depends on PTP_1588_CLOCK_OPTIONAL
select PHYLIB
+ select FIXED_PHY
select CRC16
select CRC32
help
--
2.27.0
next reply other threads:[~2023-02-19 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 15:03 Tom Rix [this message]
2023-02-19 18:16 ` [PATCH] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error Simon Horman
2023-02-20 1:19 ` Andrew Lunn
2023-02-20 6:46 ` Simon Horman
2023-02-21 2:29 ` Andrew Lunn
2023-02-21 16:20 ` Simon Horman
2023-02-26 15:15 ` Tom Rix
2023-02-27 8:37 ` Arnd Bergmann
2023-02-27 12:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230219150321.2683358-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.