All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Anatoli Antonovitch <a.antonovitch@gmail.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock.
Date: Sun, 19 Feb 2023 21:21:44 +0100	[thread overview]
Message-ID: <20230219202144.GA12404@wunner.de> (raw)
In-Reply-To: <BL1PR12MB51445CE9642195E9DEBC9CB8F7A19@BL1PR12MB5144.namprd12.prod.outlook.com>

On Fri, Feb 17, 2023 at 06:37:54PM +0000, Deucher, Alexander wrote:
> > From: Bjorn Helgaas <helgaas@kernel.org>
> > On Mon, Feb 13, 2023 at 09:59:52AM -0500, Anatoli Antonovitch wrote:
> > > On 2023-01-23 14:30, Anatoli Antonovitch wrote:
> > > > I do not see a deadlock, when applying the following old patch:
> > > > https://lore.kernel.org/linux-pci/908047f7699d9de9ec2efd6b79aa752d73dab4b6.1595329748.git.lukas@wunner.de/
> > > 
> > > Can we revisit the patches again to get a fix?
> > > The issue still reproduce and visible in the kernel 6.2.0-rc8.
> > 
> > This old patch would need to be updated and reposted.  There was a 0-day
> > bot issue and a question to be resolved.  Maybe this is all already resolved,
> > but it needs to be posted and tested with a current kernel.
> 
> Lukas, can you resend that patch?  We can test it.

I'm working on a patch which aims to solve these deadlocks differently,
by reducing the critical sections for which the reset_lock is held.
Please stand by.

Thanks,

Lukas

  reply	other threads:[~2023-02-19 20:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 17:01 [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock Anatoli Antonovitch
2023-01-20  9:28 ` Lukas Wunner
2023-01-20 21:35   ` Anatoli Antonovitch
2023-01-21  7:21     ` Lukas Wunner
2023-01-23 19:30       ` Anatoli Antonovitch
2023-02-13 14:59         ` Anatoli Antonovitch
2023-02-17 16:03           ` Bjorn Helgaas
2023-02-17 18:37             ` Deucher, Alexander
2023-02-19 20:21               ` Lukas Wunner [this message]
2023-04-10 20:36                 ` Anatoli Antonovitch
  -- strict thread matches above, loose matches on Subject: below --
2023-01-05 18:43 Anatoli Antonovitch
2023-01-05 19:18 ` Bjorn Helgaas
     [not found]   ` <5b9a2dc7-54ab-82c5-81e7-1770a4ec891c@amd.com>
2023-01-16 18:37     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230219202144.GA12404@wunner.de \
    --to=lukas@wunner.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=a.antonovitch@gmail.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.