From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47A52C05027 for ; Sun, 19 Feb 2023 22:02:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C388185860; Sun, 19 Feb 2023 23:02:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kwiboo.se header.i=@kwiboo.se header.b="rW0T9GmV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD3978584D; Sun, 19 Feb 2023 23:02:12 +0100 (CET) Received: from xtrwhxbr.outbound-mail.sendgrid.net (xtrwhxbr.outbound-mail.sendgrid.net [167.89.10.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4EFAA85843 for ; Sun, 19 Feb 2023 23:02:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=kwiboo.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bounces+31435339-7456-u-boot=lists.denx.de@em2124.kwiboo.se DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=from:subject:mime-version:to:cc:content-transfer-encoding: content-type:cc:content-type:from:subject:to; s=s1; bh=6D2WoMs6hisRhoWAYC5AS4iBuDRO7TisCV2ARSCCJrk=; b=rW0T9GmVjGJaWyindNxW9KYEOoYCwTBUtDL9Vbl6qdJJTIivaYM5VmXs8dsaNSDcEwNv 64MQik6rVwT0zJyflqskXtVHixwctb4PkuURp0tN0vg42m8lhg3XzgU46Dc4sVS2vGaQx5 P1FzrCcJrIAV/wjm23k0jh2FYUpAf31icNbW2d/a1t/hl7InhxKeypzADmVI7oPlmt0Pwa e2dmgGYQA9PFxpT9KDoqSioT22cpYEDMtqjGBtOSWHtQ5g+/PeI+yeDb8TblNMQtRi5PYo FQ9W65gws2peUlxe0s46u4s0Rs838zBCdc4r9DgWdubCgQIHZ9GKBzb+imRcd4KQ== Received: by filterdrecv-7dfc98557c-gnzb2 with SMTP id filterdrecv-7dfc98557c-gnzb2-1-63F29C5A-23 2023-02-19 22:02:02.409891812 +0000 UTC m=+788697.316738641 Received: from bionic.localdomain (unknown) by geopod-ismtpd-canary-0 (SG) with ESMTP id UBZz43y9SH-KzmsHYBQEjA Sun, 19 Feb 2023 22:02:01.991 +0000 (UTC) From: Jonas Karlman Subject: [PATCH 0/9] binman: Show missing blob message when building U-Boot Date: Sun, 19 Feb 2023 22:02:02 +0000 (UTC) Message-Id: <20230219220158.4160763-1-jonas@kwiboo.se> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h59+mpZyzfRbM2wuP?= =?us-ascii?Q?zl0OXbLR=2Fe1EgGTHvRYlosvOf1DA4+f2Hr=2FQPmm?= =?us-ascii?Q?QYIzCbOrBG6ux7BRuYnK46Guaz0r+tBdWHwxms4?= =?us-ascii?Q?zEejEYk1hiXfS7GPktBzZPL8PxgwMQYLHtdUClt?= =?us-ascii?Q?L=2Flvgh3eLhP=2Fau1mj5iumcnvjREUTx=2F1PZqeaF?= To: Simon Glass , Alper Nebi Yasak Cc: Pali =?iso-8859-1?b?Um9o4XI=?= , Heinrich Schuchardt , Marek =?iso-8859-1?b?QmVo+m4=?= , Quentin Schulz , Stefan Herbrechtsmeier , u-boot@lists.denx.de, Jonas Karlman X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean binman currently support showing a helpful missing blob message, but only when the --allow-missing flag is used. This changes so that binman is invoked with the --allow-missing flag and the helpful message can be shown by default when building U-Boot. Using the following: make rockpro64-rk3399_defconfig make CROSS_COMPILE="aarch64-linux-gnu-" Before this series a build fails with: binman: Filename 'atf-bl31' not found in input path (...) After this series a build fails with: Image 'simple-bin' is missing external blobs and is non-functional: atf-bl31 /binman/simple-bin/fit/images/@atf-SEQ/atf-bl31 (atf-bl31): See the documentation for your board. You may need to build ARM Trusted Firmware and build with BL31=/path/to/bl31.bin Image 'simple-bin' is missing external blobs but is still functional: tee-os /binman/simple-bin/fit/images/@tee-SEQ/tee-os (tee-os): See the documentation for your board. You may need to build Open Portable Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin Some images are invalid Builds will continue to fail when there is missing blobs, and the use of BINMAN_ALLOW_MISSING=1 now only enables the --ignore-missing flag. This series also fixes a few minor issues that prevented some missing and optional blobs to be detected for fit and mkimage entries. Patch 1-3 contains spelling fixes and code cleanup for related parts. Patch 4-6 improve missing/optional detection for fit and mkimage entries. Patch 7-8 improve the missing blob warning message output. Patch 9 finally update Makefile to always pass the --allow-missing flag. The series is based on top of [1], and is the follow-up series meant to address the issue with missing blob message for mkimage entries. [1] https://patchwork.ozlabs.org/project/uboot/cover/20230219150629.4012377-1-jonas@kwiboo.se/ Jonas Karlman (9): binman: Remove redundant SetAllowFakeBlob from blob-ext entry binman: Fix spelling of nodes in code comments binman: Use correct argument name in docstrings binman: Override CheckOptional in fit entry binman: Implement missing check functions in mkimage entry binman: Mark mkimage entry missing when its subnodes is missing binman: Fix blank line usage for invalid images warning text binman: Show filename in missing blob help message Makefile: Show binman missing blob message Makefile | 2 +- tools/binman/control.py | 24 ++++++--- tools/binman/entry.py | 2 +- tools/binman/etype/blob.py | 2 +- tools/binman/etype/blob_ext.py | 8 --- tools/binman/etype/fit.py | 9 +++- tools/binman/etype/mkimage.py | 54 ++++++++++++++++++- tools/binman/etype/section.py | 6 +-- tools/binman/ftest.py | 9 ++++ tools/binman/state.py | 2 +- .../test/278_mkimage_missing_multiple.dts | 19 +++++++ 11 files changed, 111 insertions(+), 26 deletions(-) create mode 100644 tools/binman/test/278_mkimage_missing_multiple.dts -- 2.39.2