Re: [Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: David Bachelart <david.bachelart@bbright.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ipmiutil: fix uclibc build without wchar
Date: Sun, 19 Feb 2023 23:05:10 +0100	[thread overview]
Message-ID: <20230219230510.4b29d5be@windsurf> (raw)
In-Reply-To: <20230219161453.87903-1-fontaine.fabrice@gmail.com>

On Sun, 19 Feb 2023 17:14:53 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> For an unknown reason, wchar_t is incorrectly detected with uclibc
> resulting in the following build failure:
> 
> In file included from igetevent.c:136:
> imb_api.h:150:5: error: unknown type name 'wchar_t'
>   150 |     wchar_t *Buffer;
>       |     ^~~~~~~
> 
> The build failure can be reproduced even when reverting bump to version
> 3.1.8.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e9ff3bd08e106dc834968bf5e4296ce8299027f8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ipmiutil/ipmiutil.mk | 1 +
>  1 file changed, 1 insertion(+)

I think the problem is that uClibc-ng defines the wchar_t type even if
wchar support is disabled. I believe if the AC_CHECK_TYPES() check in
ipmiutil ensured that <wchar.h> was included, the detection would work
correctly, as wchar.h contains a #error when wchar support is disabled.

Anyway, in the mean time, what you proposed looks fine to me, so:
applied!

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot