From: Ming Lei <ming.lei@redhat.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH blktests v3 2/2] block/033: add test to cover gendisk leak
Date: Mon, 20 Feb 2023 11:46:49 +0800 [thread overview]
Message-ID: <20230220034649.1522978-3-ming.lei@redhat.com> (raw)
In-Reply-To: <20230220034649.1522978-1-ming.lei@redhat.com>
So far only sync ublk removal is supported, and the device's
last reference is dropped in gendisk's ->free_disk(), so it
can be used to test gendisk leak issue.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
common/ublk | 35 +++++++++++++++++++++++++++++++++++
tests/block/033 | 41 +++++++++++++++++++++++++++++++++++++++++
tests/block/033.out | 2 ++
3 files changed, 78 insertions(+)
create mode 100644 common/ublk
create mode 100755 tests/block/033
create mode 100644 tests/block/033.out
diff --git a/common/ublk b/common/ublk
new file mode 100644
index 0000000..932c534
--- /dev/null
+++ b/common/ublk
@@ -0,0 +1,35 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2023 Ming Lei
+#
+# ublk_drv helper functions.
+
+. common/shellcheck
+
+_have_ublk() {
+ _have_driver ublk_drv
+ _have_src_program miniublk
+}
+
+_remove_ublk_devices() {
+ src/miniublk del -a
+}
+
+_init_ublk() {
+ _remove_ublk_devices
+
+ modprobe -rq ublk_drv
+ if ! modprobe ublk_drv; then
+ SKIP_REASONS+=("requires ublk_drv")
+ return 1
+ fi
+
+ udevadm settle
+ return 0
+}
+
+_exit_ublk() {
+ _remove_ublk_devices
+ udevadm settle
+ modprobe -r -q ublk_drv
+}
diff --git a/tests/block/033 b/tests/block/033
new file mode 100755
index 0000000..762f606
--- /dev/null
+++ b/tests/block/033
@@ -0,0 +1,41 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2023 Ming Lei
+#
+# Test if gendisk is leaked, and regression in the following commit
+# c43332fe028c ("blk-cgroup: delay calling blkcg_exit_disk until disk_release")
+# can be covered
+
+. tests/block/rc
+. common/ublk
+
+DESCRIPTION="add & delete ublk device and test if gendisk is leaked"
+QUICK=1
+
+requires() {
+ _have_ublk
+}
+
+test() {
+ local ublk_prog="src/miniublk"
+
+ echo "Running ${TEST_NAME}"
+
+ if ! _init_ublk; then
+ return 1
+ fi
+
+ ${ublk_prog} add -t null -n 0 > "$FULL"
+ udevadm settle
+ if ! ${ublk_prog} list -n 0 >> "$FULL"; then
+ echo "fail to list dev"
+ fi
+ if ! dd if=/dev/ublkb0 iflag=direct of=/dev/null bs=1M count=512 >> "$FULL" 2>&1; then
+ echo "fail io"
+ fi
+ ${ublk_prog} del -n 0 >> "$FULL"
+
+ _exit_ublk
+
+ echo "Test complete"
+}
diff --git a/tests/block/033.out b/tests/block/033.out
new file mode 100644
index 0000000..067846a
--- /dev/null
+++ b/tests/block/033.out
@@ -0,0 +1,2 @@
+Running block/033
+Test complete
--
2.31.1
next prev parent reply other threads:[~2023-02-20 3:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 3:46 [PATCH blktests v3 0/2] blktests: add mini ublk source and blktests/033 Ming Lei
2023-02-20 3:46 ` [PATCH blktests v3 1/2] src: add mini ublk source code Ming Lei
2023-02-21 19:58 ` Chaitanya Kulkarni
2023-02-24 8:40 ` Ming Lei
2023-02-24 8:45 ` Ming Lei
2023-02-24 7:52 ` Ziyang Zhang
2023-02-24 8:28 ` Ming Lei
2023-02-24 11:41 ` Shinichiro Kawasaki
2023-02-27 2:57 ` Ziyang Zhang
2023-02-27 5:41 ` Shinichiro Kawasaki
2023-02-27 6:10 ` Ziyang Zhang
2023-02-28 9:25 ` Shinichiro Kawasaki
2023-02-20 3:46 ` Ming Lei [this message]
2023-02-20 13:03 ` [PATCH blktests v3 0/2] blktests: add mini ublk source and blktests/033 Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220034649.1522978-3-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.