From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 195EDC05027 for ; Mon, 20 Feb 2023 09:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gs7Xo10Jt7OfMuw2uR29gE8uOV1atf7qNNss0U80ym0=; b=YSEdXiXgBAqmbTyL1qPIHUH7aR G4/z1bjWDHZmjrxxp3Bjh0RyJHrmptuTqjIWNKvvHjgu4cCM756TqlBbDe/U6ZOicwrWdgks36bNL SeuZ9V1h1y1l5cUdhU0kw1QGkqbUKJFraVtm67JVxo8zSxYZfx05wNPqieu51B3ngVDUrvOcGKmNi e3giAUKGS/rf6gcBwua+f0IohwtS9T4mzcqFQGXSYO49pVtZIsncU64l7D2hU7SRTboas4GwuC+a6 WUyMJf6VgXhQizxj25vhqjsvhxUmPaIjGLsmde3/ihRMmQ5gD57lWyl0G+ZXvIIX+sE524cTdB5BE GwkJOFGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU2XF-003W9w-M7; Mon, 20 Feb 2023 09:32:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU2Wy-003W80-Sv; Mon, 20 Feb 2023 09:32:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1475260CF5; Mon, 20 Feb 2023 09:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59BB1C4339B; Mon, 20 Feb 2023 09:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676885538; bh=WP/C8hKVpvdrRvMRdROd3OdMlXuM01497fljMlMi13o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ne24zRzA9QCyMRSpjrif2y6f5rLPcC0ETThe1iYNjjAPHbITeX6qnCpTIr2gRpBkn naztHHw2oEfx4t2zDq3yhKTbnS0Sg37tjoNdzIdlxq4jD39qyFFkH5z3alt1AO6paw yTGE9rnUoKgvZ6swolAIHfOSiUV2kDoGxVkmESi4aqJt7EwX6xXguI1aAI1TdS66jK seazaUZJ6ZHubyphkZ5IqmH3qhiinYEdlbPADku+RKCMy8yUjJAsPofF7dxPkfOJ5h Px4s8Xh+WmsO3wo8T6F3qBcZ8BKpC4hJxE4K9EC9gxVZG9rBt5q1mC5veXVbW5+/Wh VJjXz/e91+JSQ== Date: Mon, 20 Feb 2023 15:02:10 +0530 From: Manivannan Sadhasivam To: Stephen Zhang Cc: jejb@linux.ibm.com, artin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, beanhuo@micron.com, bvanassche@acm.org, avri.altman@wdc.com, yoshihiro.shimoda.uh@renesas.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, zhangshida@kylinos.cn, k2ci Subject: Re: [PATCH] scsi: ufs: Add select to CONFIG_PM in Kconfig Message-ID: <20230220093210.GA27366@thinkpad> References: <20230220083256.997470-1-zhangshida@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230220083256.997470-1-zhangshida@kylinos.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_013220_996375_D3C2C4AD X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Feb 20, 2023 at 04:32:56PM +0800, Stephen Zhang wrote: > From: Shida Zhang > > From: Shida Zhang > > In a configuration with CONFIG_SCSI_UFS_MEDIATEK set to 'm' and > CONFIG_PM set to 'n', errors occur at compile time: > > ==== > ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_suspend’: > ../drivers/ufs/host/ufs-mediatek.c:1621:8: error: implicit declaration of function ‘ufshcd_runtime_suspend’; did you mean ‘ufs_mtk_runtime_suspend’? [-Werror=implicit-function-declaration] > ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_resume’: > ../drivers/ufs/host/ufs-mediatek.c:1636:9: error: implicit declaration of function ‘ufshcd_runtime_resume’; did you mean ‘ufs_mtk_runtime_resume’? [-Werror=implicit-function-declaration] > ==== > > This patch fixes these by selecting CONFIG_PM from CONFIG_SCSI_UFS_MEDIATEK. > > Reported-by: k2ci > Signed-off-by: Shida Zhang > --- > drivers/ufs/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig > index 4cc2dbd79ed0..f9786f085b54 100644 > --- a/drivers/ufs/host/Kconfig > +++ b/drivers/ufs/host/Kconfig > @@ -71,6 +71,7 @@ config SCSI_UFS_QCOM > config SCSI_UFS_MEDIATEK > tristate "Mediatek specific hooks to UFS controller platform driver" > depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK > + select PM Forcing a dependency is only valid if the driver won't work without it. PM is an optional feature, so it shouldn't be forced. Moreover, in your case the drivers were not used but instead erroring out because their definitions exist. Here you should guard the ufs_mtk_runtime_suspend and ufs_mtk_runtime_resume functions with CONFIG_PM instead. Thanks, Mani > select PHY_MTK_UFS > select RESET_TI_SYSCON > help > -- > 2.27.0 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65AECC636CC for ; Mon, 20 Feb 2023 09:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=et4b9ViMMQQhKW8kiT082140nLL5qK0MCPhKAXKddPs=; b=yMVD1CcqR2X08Z vlVX8ED4Sg4hrZ4ySIO917O7O+iEIcH6qjEoq8sufkLSEr5vBsYZaCGIEnN47b0k0y8FVQ6r/rxqI Dh6wzoMeKSW6581Ko8dScFqbgeITir/OOU9fWk/wbF1Iu++UcsIeM7Ly6RLpmPS1NVVznOuaO2SL/ gF0dJ3Swekw2cgQPNv3SGDI3CtML15kGIK3/pdUO6wcfR4xArKqWtF8xXFSEmtI9FZcqVVQt0wOKG cyKxwhETIZTdM9gvdZ+6oYeQ7v+FdiMSAtGUqPFc8cwleQy7XIS72cUrDKNiG0xqtBtpaBlhq7E3J 9DNbbcOy8gaNVwj7uTTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU2X3-003W8b-JN; Mon, 20 Feb 2023 09:32:25 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU2Wy-003W80-Sv; Mon, 20 Feb 2023 09:32:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1475260CF5; Mon, 20 Feb 2023 09:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59BB1C4339B; Mon, 20 Feb 2023 09:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676885538; bh=WP/C8hKVpvdrRvMRdROd3OdMlXuM01497fljMlMi13o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ne24zRzA9QCyMRSpjrif2y6f5rLPcC0ETThe1iYNjjAPHbITeX6qnCpTIr2gRpBkn naztHHw2oEfx4t2zDq3yhKTbnS0Sg37tjoNdzIdlxq4jD39qyFFkH5z3alt1AO6paw yTGE9rnUoKgvZ6swolAIHfOSiUV2kDoGxVkmESi4aqJt7EwX6xXguI1aAI1TdS66jK seazaUZJ6ZHubyphkZ5IqmH3qhiinYEdlbPADku+RKCMy8yUjJAsPofF7dxPkfOJ5h Px4s8Xh+WmsO3wo8T6F3qBcZ8BKpC4hJxE4K9EC9gxVZG9rBt5q1mC5veXVbW5+/Wh VJjXz/e91+JSQ== Date: Mon, 20 Feb 2023 15:02:10 +0530 From: Manivannan Sadhasivam To: Stephen Zhang Cc: jejb@linux.ibm.com, artin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, beanhuo@micron.com, bvanassche@acm.org, avri.altman@wdc.com, yoshihiro.shimoda.uh@renesas.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, zhangshida@kylinos.cn, k2ci Subject: Re: [PATCH] scsi: ufs: Add select to CONFIG_PM in Kconfig Message-ID: <20230220093210.GA27366@thinkpad> References: <20230220083256.997470-1-zhangshida@kylinos.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230220083256.997470-1-zhangshida@kylinos.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_013220_996375_D3C2C4AD X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBGZWIgMjAsIDIwMjMgYXQgMDQ6MzI6NTZQTSArMDgwMCwgU3RlcGhlbiBaaGFuZyB3 cm90ZToKPiBGcm9tOiBTaGlkYSBaaGFuZyA8emhhbmdzaGlkYUBreWxpbm9zLmNuPgo+IAo+IEZy b206IFNoaWRhIFpoYW5nIDx6aGFuZ3NoaWRhQGt5bGlub3MuY24+Cj4gCj4gSW4gYSBjb25maWd1 cmF0aW9uIHdpdGggQ09ORklHX1NDU0lfVUZTX01FRElBVEVLIHNldCB0byAnbScgYW5kCj4gQ09O RklHX1BNIHNldCB0byAnbicsIGVycm9ycyBvY2N1ciBhdCBjb21waWxlIHRpbWU6Cj4gCj4gPT09 PQo+IC4uL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmM6IEluIGZ1bmN0aW9uIOKAmHVm c19tdGtfcnVudGltZV9zdXNwZW5k4oCZOgo+IC4uL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlh dGVrLmM6MTYyMTo4OiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCY dWZzaGNkX3J1bnRpbWVfc3VzcGVuZOKAmTsgZGlkIHlvdSBtZWFuIOKAmHVmc19tdGtfcnVudGlt ZV9zdXNwZW5k4oCZPyBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlvbl0KPiAu Li9kcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jOiBJbiBmdW5jdGlvbiDigJh1ZnNfbXRr X3J1bnRpbWVfcmVzdW1l4oCZOgo+IC4uL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmM6 MTYzNjo5OiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYdWZzaGNk X3J1bnRpbWVfcmVzdW1l4oCZOyBkaWQgeW91IG1lYW4g4oCYdWZzX210a19ydW50aW1lX3Jlc3Vt ZeKAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPT09PQo+IAo+ IFRoaXMgcGF0Y2ggZml4ZXMgdGhlc2UgYnkgc2VsZWN0aW5nIENPTkZJR19QTSBmcm9tIENPTkZJ R19TQ1NJX1VGU19NRURJQVRFSy4KPiAKPiBSZXBvcnRlZC1ieTogazJjaSA8a2VybmVsLWJvdEBr eWxpbm9zLmNuPgo+IFNpZ25lZC1vZmYtYnk6IFNoaWRhIFpoYW5nIDx6aGFuZ3NoaWRhQGt5bGlu b3MuY24+Cj4gLS0tCj4gIGRyaXZlcnMvdWZzL2hvc3QvS2NvbmZpZyB8IDEgKwo+ICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91ZnMvaG9z dC9LY29uZmlnIGIvZHJpdmVycy91ZnMvaG9zdC9LY29uZmlnCj4gaW5kZXggNGNjMmRiZDc5ZWQw Li5mOTc4NmYwODViNTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91ZnMvaG9zdC9LY29uZmlnCj4g KysrIGIvZHJpdmVycy91ZnMvaG9zdC9LY29uZmlnCj4gQEAgLTcxLDYgKzcxLDcgQEAgY29uZmln IFNDU0lfVUZTX1FDT00KPiAgY29uZmlnIFNDU0lfVUZTX01FRElBVEVLCj4gIAl0cmlzdGF0ZSAi TWVkaWF0ZWsgc3BlY2lmaWMgaG9va3MgdG8gVUZTIGNvbnRyb2xsZXIgcGxhdGZvcm0gZHJpdmVy Igo+ICAJZGVwZW5kcyBvbiBTQ1NJX1VGU0hDRF9QTEFURk9STSAmJiBBUkNIX01FRElBVEVLCj4g KwlzZWxlY3QgUE0KCkZvcmNpbmcgYSBkZXBlbmRlbmN5IGlzIG9ubHkgdmFsaWQgaWYgdGhlIGRy aXZlciB3b24ndCB3b3JrIHdpdGhvdXQgaXQuIFBNIGlzCmFuIG9wdGlvbmFsIGZlYXR1cmUsIHNv IGl0IHNob3VsZG4ndCBiZSBmb3JjZWQuIE1vcmVvdmVyLCBpbiB5b3VyIGNhc2UgdGhlCmRyaXZl cnMgd2VyZSBub3QgdXNlZCBidXQgaW5zdGVhZCBlcnJvcmluZyBvdXQgYmVjYXVzZSB0aGVpciBk ZWZpbml0aW9ucyBleGlzdC4KCkhlcmUgeW91IHNob3VsZCBndWFyZCB0aGUgdWZzX210a19ydW50 aW1lX3N1c3BlbmQgYW5kIHVmc19tdGtfcnVudGltZV9yZXN1bWUKZnVuY3Rpb25zIHdpdGggQ09O RklHX1BNIGluc3RlYWQuCgpUaGFua3MsCk1hbmkKCj4gIAlzZWxlY3QgUEhZX01US19VRlMKPiAg CXNlbGVjdCBSRVNFVF9USV9TWVNDT04KPiAgCWhlbHAKPiAtLSAKPiAyLjI3LjAKPiAKCi0tIArg rq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==