From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E23C05027 for ; Mon, 20 Feb 2023 08:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbjBTI6r (ORCPT ); Mon, 20 Feb 2023 03:58:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbjBTI6p (ORCPT ); Mon, 20 Feb 2023 03:58:45 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 887767DB8; Mon, 20 Feb 2023 00:58:33 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C198760002; Mon, 20 Feb 2023 08:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676883511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fz7ymKkeqvHCDa/6k6ptYf6tiYPwOleZAKDnnk0ryko=; b=WRXxB5cRd4mIWFQQx94i4cOSCLm26Fqr86Rg1aViqT3mwAQqKP6f+SZCAeNxPuF6YYgSx6 YiN0/1c9H/0ueNExaOd+BUSDu7nVPs3K4clkWQuHW0MJa1NS11IN4PXEZBuXUaZYTrly5g mB+lxg74Ht14gbpP3k1fOpOvbOPtScmaybhxxTElFl5psZncnCZU0BGUiglsQU5HykqPiP 92UxNJuC1UlUHh7DDHsRygjfyNMVhPqZhjdrfiA6mIKtIInpB/KVCiTLBumQlgoCKd/dym MRtPbQa5dNzpyKn6U+aADxeFF7hqCgLRS7pc1GViYWYuLwN0IEgVYg2hvi0fhw== Date: Mon, 20 Feb 2023 09:58:29 +0100 From: Miquel Raynal To: Daniel Lezcano Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , Zhang Rui , Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: Re: [PATCH v1 03/17] thermal: Remove debug or error messages in get_temp() ops Message-ID: <20230220095829.1591a532@xps-13> In-Reply-To: <20230219143657.241542-4-daniel.lezcano@linaro.org> References: <20230219143657.241542-1-daniel.lezcano@linaro.org> <20230219143657.241542-4-daniel.lezcano@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Daniel, daniel.lezcano@linaro.org wrote on Sun, 19 Feb 2023 15:36:43 +0100: > Some get_temp() ops implementation are showing an error or a debug > message if the reading of the sensor fails. >=20 > The debug message is already displayed from the call site of this > ops. So we can remove it. >=20 > On the other side, the error should not be displayed because in > production that can raise tons of messages. >=20 > Finally, some drivers are showing a debug message with the > temperature, this is also accessible through the trace from the core > code in the temperature_update() function. >=20 > Another benefit is the dev_* messages are accessing the thermal zone > device field from the structure, so we encapsulate even more the code > by preventing these accesses. >=20 > Remove those messages. >=20 > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/armada_thermal.c | 10 ++-------- For Armada: Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B6B5C05027 for ; Mon, 20 Feb 2023 08:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fzzZzThbhAvt9QQKs88aT/NQLSC87dDedH0rbTiy1V0=; b=JdO2D2pGBeKfZz tuHqBR2NXORPyLOPMGgicV0X2tzJIN8xfso0ZmBcMfIHziqvlz/tQWh47BIkNI/IW2hV+Sva0Dn7O gjdUyT71h3t51/oFuRxufXCrAMErt5aVu/YGlN/l45p8y91s3yMFVRsJXEnOmwPSIvYWO+L+LengC FJaxkw8ndr22+aRb9dwNkLaCj/Fx8onDIXuOXltgdoqrmtEMwOXfPXXsmTYVGccvTXukbBDR18V5r 5r0hLwWPSN2GXqFr3HHPjcA6WptI6QS3c9sg/upfh0sStfNcS3e5Ez71Fpl4PbwCKBg312HmTWMKY +24dzI1FE4MU6uJyYLJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU20c-003Plk-OJ; Mon, 20 Feb 2023 08:58:54 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU20O-003PiK-O9; Mon, 20 Feb 2023 08:58:43 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C198760002; Mon, 20 Feb 2023 08:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676883511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fz7ymKkeqvHCDa/6k6ptYf6tiYPwOleZAKDnnk0ryko=; b=WRXxB5cRd4mIWFQQx94i4cOSCLm26Fqr86Rg1aViqT3mwAQqKP6f+SZCAeNxPuF6YYgSx6 YiN0/1c9H/0ueNExaOd+BUSDu7nVPs3K4clkWQuHW0MJa1NS11IN4PXEZBuXUaZYTrly5g mB+lxg74Ht14gbpP3k1fOpOvbOPtScmaybhxxTElFl5psZncnCZU0BGUiglsQU5HykqPiP 92UxNJuC1UlUHh7DDHsRygjfyNMVhPqZhjdrfiA6mIKtIInpB/KVCiTLBumQlgoCKd/dym MRtPbQa5dNzpyKn6U+aADxeFF7hqCgLRS7pc1GViYWYuLwN0IEgVYg2hvi0fhw== Date: Mon, 20 Feb 2023 09:58:29 +0100 From: Miquel Raynal To: Daniel Lezcano Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , Zhang Rui , Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: Re: [PATCH v1 03/17] thermal: Remove debug or error messages in get_temp() ops Message-ID: <20230220095829.1591a532@xps-13> In-Reply-To: <20230219143657.241542-4-daniel.lezcano@linaro.org> References: <20230219143657.241542-1-daniel.lezcano@linaro.org> <20230219143657.241542-4-daniel.lezcano@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_005840_986731_F001DC52 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZyB3cm90ZSBvbiBTdW4sIDE5IEZl YiAyMDIzIDE1OjM2OjQzICswMTAwOgoKPiBTb21lIGdldF90ZW1wKCkgb3BzIGltcGxlbWVudGF0 aW9uIGFyZSBzaG93aW5nIGFuIGVycm9yIG9yIGEgZGVidWcKPiBtZXNzYWdlIGlmIHRoZSByZWFk aW5nIG9mIHRoZSBzZW5zb3IgZmFpbHMuCj4gCj4gVGhlIGRlYnVnIG1lc3NhZ2UgaXMgYWxyZWFk eSBkaXNwbGF5ZWQgZnJvbSB0aGUgY2FsbCBzaXRlIG9mIHRoaXMKPiBvcHMuIFNvIHdlIGNhbiBy ZW1vdmUgaXQuCj4gCj4gT24gdGhlIG90aGVyIHNpZGUsIHRoZSBlcnJvciBzaG91bGQgbm90IGJl IGRpc3BsYXllZCBiZWNhdXNlIGluCj4gcHJvZHVjdGlvbiB0aGF0IGNhbiByYWlzZSB0b25zIG9m IG1lc3NhZ2VzLgo+IAo+IEZpbmFsbHksIHNvbWUgZHJpdmVycyBhcmUgc2hvd2luZyBhIGRlYnVn IG1lc3NhZ2Ugd2l0aCB0aGUKPiB0ZW1wZXJhdHVyZSwgdGhpcyBpcyBhbHNvIGFjY2Vzc2libGUg dGhyb3VnaCB0aGUgdHJhY2UgZnJvbSB0aGUgY29yZQo+IGNvZGUgaW4gdGhlIHRlbXBlcmF0dXJl X3VwZGF0ZSgpIGZ1bmN0aW9uLgo+IAo+IEFub3RoZXIgYmVuZWZpdCBpcyB0aGUgZGV2XyogbWVz c2FnZXMgYXJlIGFjY2Vzc2luZyB0aGUgdGhlcm1hbCB6b25lCj4gZGV2aWNlIGZpZWxkIGZyb20g dGhlIHN0cnVjdHVyZSwgc28gd2UgZW5jYXBzdWxhdGUgZXZlbiBtb3JlIHRoZSBjb2RlCj4gYnkg cHJldmVudGluZyB0aGVzZSBhY2Nlc3Nlcy4KPiAKPiBSZW1vdmUgdGhvc2UgbWVzc2FnZXMuCj4g Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIExlemNhbm8gPGRhbmllbC5sZXpjYW5vQGxpbmFyby5v cmc+Cj4gLS0tCj4gIGRyaXZlcnMvdGhlcm1hbC9hcm1hZGFfdGhlcm1hbC5jICAgICAgICAgICB8 IDEwICsrLS0tLS0tLS0KCkZvciBBcm1hZGE6CgpSZXZpZXdlZC1ieTogTWlxdWVsIFJheW5hbCA8 bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGlu ZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EF1FC05027 for ; Mon, 20 Feb 2023 08:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YFTWuB06IwZmgZv4U/BtGP51OqrZk+wPFN5uwcnSy6E=; b=Yw/siEXrL/7IJT qQ/Z468MVCZfnZtzoeQaY/yndHzKT26yg8IxaCd77vQogSOZqKKjNFkiPUhHWvWw6rPXllI6DTXaG ZoN0iItBbmv4CFMJR7Drh9nz++e5a8onumMAt15BwkMjkzd6+LnIPE+DBl2aRKQ3282nZjEAozTCJ nHH0ixrUmkNvTEsw+GQ/sgyb/fCCEiW/K6H84UJxBZSjCjCJQZ8dxiugXGPgTNPrdbLJ+/COxt1JC ipd0IAyEqXwn088BNq6qk26OBK+jgvA+wWGNFHdZwTlbBxYnvYJ2gMzt2JoVBc+lSscBiYfZeujjM DD1/NPdrMeiOlGthSG1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU20V-003PkE-AN; Mon, 20 Feb 2023 08:58:47 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU20O-003PiK-O9; Mon, 20 Feb 2023 08:58:43 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C198760002; Mon, 20 Feb 2023 08:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676883511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fz7ymKkeqvHCDa/6k6ptYf6tiYPwOleZAKDnnk0ryko=; b=WRXxB5cRd4mIWFQQx94i4cOSCLm26Fqr86Rg1aViqT3mwAQqKP6f+SZCAeNxPuF6YYgSx6 YiN0/1c9H/0ueNExaOd+BUSDu7nVPs3K4clkWQuHW0MJa1NS11IN4PXEZBuXUaZYTrly5g mB+lxg74Ht14gbpP3k1fOpOvbOPtScmaybhxxTElFl5psZncnCZU0BGUiglsQU5HykqPiP 92UxNJuC1UlUHh7DDHsRygjfyNMVhPqZhjdrfiA6mIKtIInpB/KVCiTLBumQlgoCKd/dym MRtPbQa5dNzpyKn6U+aADxeFF7hqCgLRS7pc1GViYWYuLwN0IEgVYg2hvi0fhw== Date: Mon, 20 Feb 2023 09:58:29 +0100 From: Miquel Raynal To: Daniel Lezcano Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , Zhang Rui , Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: Re: [PATCH v1 03/17] thermal: Remove debug or error messages in get_temp() ops Message-ID: <20230220095829.1591a532@xps-13> In-Reply-To: <20230219143657.241542-4-daniel.lezcano@linaro.org> References: <20230219143657.241542-1-daniel.lezcano@linaro.org> <20230219143657.241542-4-daniel.lezcano@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_005840_986731_F001DC52 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZyB3cm90ZSBvbiBTdW4sIDE5IEZl YiAyMDIzIDE1OjM2OjQzICswMTAwOgoKPiBTb21lIGdldF90ZW1wKCkgb3BzIGltcGxlbWVudGF0 aW9uIGFyZSBzaG93aW5nIGFuIGVycm9yIG9yIGEgZGVidWcKPiBtZXNzYWdlIGlmIHRoZSByZWFk aW5nIG9mIHRoZSBzZW5zb3IgZmFpbHMuCj4gCj4gVGhlIGRlYnVnIG1lc3NhZ2UgaXMgYWxyZWFk eSBkaXNwbGF5ZWQgZnJvbSB0aGUgY2FsbCBzaXRlIG9mIHRoaXMKPiBvcHMuIFNvIHdlIGNhbiBy ZW1vdmUgaXQuCj4gCj4gT24gdGhlIG90aGVyIHNpZGUsIHRoZSBlcnJvciBzaG91bGQgbm90IGJl IGRpc3BsYXllZCBiZWNhdXNlIGluCj4gcHJvZHVjdGlvbiB0aGF0IGNhbiByYWlzZSB0b25zIG9m IG1lc3NhZ2VzLgo+IAo+IEZpbmFsbHksIHNvbWUgZHJpdmVycyBhcmUgc2hvd2luZyBhIGRlYnVn IG1lc3NhZ2Ugd2l0aCB0aGUKPiB0ZW1wZXJhdHVyZSwgdGhpcyBpcyBhbHNvIGFjY2Vzc2libGUg dGhyb3VnaCB0aGUgdHJhY2UgZnJvbSB0aGUgY29yZQo+IGNvZGUgaW4gdGhlIHRlbXBlcmF0dXJl X3VwZGF0ZSgpIGZ1bmN0aW9uLgo+IAo+IEFub3RoZXIgYmVuZWZpdCBpcyB0aGUgZGV2XyogbWVz c2FnZXMgYXJlIGFjY2Vzc2luZyB0aGUgdGhlcm1hbCB6b25lCj4gZGV2aWNlIGZpZWxkIGZyb20g dGhlIHN0cnVjdHVyZSwgc28gd2UgZW5jYXBzdWxhdGUgZXZlbiBtb3JlIHRoZSBjb2RlCj4gYnkg cHJldmVudGluZyB0aGVzZSBhY2Nlc3Nlcy4KPiAKPiBSZW1vdmUgdGhvc2UgbWVzc2FnZXMuCj4g Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIExlemNhbm8gPGRhbmllbC5sZXpjYW5vQGxpbmFyby5v cmc+Cj4gLS0tCj4gIGRyaXZlcnMvdGhlcm1hbC9hcm1hZGFfdGhlcm1hbC5jICAgICAgICAgICB8 IDEwICsrLS0tLS0tLS0KCkZvciBBcm1hZGE6CgpSZXZpZXdlZC1ieTogTWlxdWVsIFJheW5hbCA8 bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=