From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: Gavin Li <gavinl@nvidia.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
roopa@nvidia.com, eng.alaamohamedsoliman.am@gmail.com,
bigeasy@linutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gavi@nvidia.com, roid@nvidia.com,
maord@nvidia.com, saeedm@nvidia.com
Subject: Re: [PATCH net-next v3 2/5] vxlan: Expose helper vxlan_build_gbp_hdr
Date: Mon, 20 Feb 2023 12:30:21 -0800 [thread overview]
Message-ID: <20230220123021.448dc1a0@kernel.org> (raw)
In-Reply-To: <Y/NMH2QRKoUpdNef@corigine.com>
On Mon, 20 Feb 2023 11:31:59 +0100 Simon Horman wrote:
> On Mon, Feb 20, 2023 at 03:15:20PM +0800, Gavin Li wrote:
> > > Right. But what I was really wondering is if the definition
> > > of the function could stay in drivers/net/vxlan/vxlan_core.c,
> > > without being static. And have a declaration in include/net/vxlan.h
> >
> > Tried that the first time the function was called by driver code. It would
> > introduce dependency in linking between the driver and the kernel module.
> >
> > Do you think it's OK to have such dependency?
>
> IMHO, yes. But others may feel differently.
>
> I do wonder if any performance overhead of a non-inline function
> also needs to be considered.
Do you recall any details of why Hannes broke the dependency in the
first place?
Commit b7aade15485a ("vxlan: break dependency with netdev drivers")
Maybe we should stick to the static inline, it doesn't look too
large/terrible?
next prev parent reply other threads:[~2023-02-20 20:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 3:39 [PATCH net-next v3 0/5] net/mlx5e: Add GBP VxLAN HW offload support Gavin Li
2023-02-17 3:39 ` [PATCH net-next v3 1/5] vxlan: Remove unused argument from vxlan_build_gbp_hdr( ) and vxlan_build_gpe_hdr( ) Gavin Li
2023-02-19 20:30 ` Simon Horman
2023-02-17 3:39 ` [PATCH net-next v3 2/5] vxlan: Expose helper vxlan_build_gbp_hdr Gavin Li
2023-02-19 20:32 ` Simon Horman
2023-02-20 2:05 ` Gavin Li
2023-02-20 6:40 ` Simon Horman
2023-02-20 7:15 ` Gavin Li
2023-02-20 10:31 ` Simon Horman
2023-02-20 20:30 ` Jakub Kicinski [this message]
2023-02-21 7:38 ` Paolo Abeni
2023-02-21 9:30 ` Simon Horman
2023-02-17 3:39 ` [PATCH net-next v3 3/5] net/mlx5e: Add helper for encap_info_equal for tunnels with options Gavin Li
2023-02-19 20:34 ` Simon Horman
2023-02-17 3:39 ` [PATCH net-next v3 4/5] ip_tunnel: constify input argument of ip_tunnel_info_opts( ) Gavin Li
2023-02-19 20:29 ` Simon Horman
2023-02-19 20:46 ` Simon Horman
2023-02-20 10:42 ` Gavin Li
2023-02-24 16:11 ` Alexander Lobakin
2023-02-22 2:47 ` Gavin Li
2023-02-17 3:39 ` [PATCH net-next v3 5/5] net/mlx5e: TC, Add support for VxLAN GBP encap/decap flows offload Gavin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220123021.448dc1a0@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=gavi@nvidia.com \
--cc=gavinl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maord@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roid@nvidia.com \
--cc=roopa@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.