From: kernel test robot <lkp@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [lunn:v6.2-rc7-net-next-ethtool-eee-v4 5/21] net/dsa/port.c:1664:9: error: too few arguments to function 'ds->ops->phylink_mac_link_up'
Date: Mon, 20 Feb 2023 14:20:27 +0800 [thread overview]
Message-ID: <202302201417.2gOq9MVB-lkp@intel.com> (raw)
tree: https://github.com/lunn/linux.git v6.2-rc7-net-next-ethtool-eee-v4
head: 77e826a1c4b7decf488d4966ae751195e3043a9d
commit: a544bb9b4c9c9576416b576a4ac00a9fda773a7d [5/21] net: phylink: Plumb eee_active in mac_link_up call
config: loongarch-randconfig-r003-20230220 (https://download.01.org/0day-ci/archive/20230220/202302201417.2gOq9MVB-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/lunn/linux/commit/a544bb9b4c9c9576416b576a4ac00a9fda773a7d
git remote add lunn https://github.com/lunn/linux.git
git fetch --no-tags lunn v6.2-rc7-net-next-ethtool-eee-v4
git checkout a544bb9b4c9c9576416b576a4ac00a9fda773a7d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash net/dsa/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302201417.2gOq9MVB-lkp@intel.com/
All errors (new ones prefixed by >>):
net/dsa/port.c: In function 'dsa_port_phylink_mac_link_up':
>> net/dsa/port.c:1664:9: error: too few arguments to function 'ds->ops->phylink_mac_link_up'
1664 | ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev,
| ^~
net/dsa/port.c: At top level:
>> net/dsa/port.c:1675:24: error: initialization of 'void (*)(struct phylink_config *, struct phy_device *, unsigned int, phy_interface_t, int, int, bool, bool, bool)' {aka 'void (*)(struct phylink_config *, struct phy_device *, unsigned int, phy_interface_t, int, int, _Bool, _Bool, _Bool)'} from incompatible pointer type 'void (*)(struct phylink_config *, struct phy_device *, unsigned int, phy_interface_t, int, int, bool, bool)' {aka 'void (*)(struct phylink_config *, struct phy_device *, unsigned int, phy_interface_t, int, int, _Bool, _Bool)'} [-Werror=incompatible-pointer-types]
1675 | .mac_link_up = dsa_port_phylink_mac_link_up,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/dsa/port.c:1675:24: note: (near initialization for 'dsa_port_phylink_mac_ops.mac_link_up')
cc1: some warnings being treated as errors
vim +1664 net/dsa/port.c
77373d49de22e8 Ioana Ciornei 2019-05-28 1647
8ae674964e67eb Florian Fainelli 2019-12-16 1648 static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
91a208f2185ad4 Russell King 2020-02-26 1649 struct phy_device *phydev,
77373d49de22e8 Ioana Ciornei 2019-05-28 1650 unsigned int mode,
77373d49de22e8 Ioana Ciornei 2019-05-28 1651 phy_interface_t interface,
91a208f2185ad4 Russell King 2020-02-26 1652 int speed, int duplex,
91a208f2185ad4 Russell King 2020-02-26 1653 bool tx_pause, bool rx_pause)
77373d49de22e8 Ioana Ciornei 2019-05-28 1654 {
77373d49de22e8 Ioana Ciornei 2019-05-28 1655 struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
77373d49de22e8 Ioana Ciornei 2019-05-28 1656 struct dsa_switch *ds = dp->ds;
77373d49de22e8 Ioana Ciornei 2019-05-28 1657
77373d49de22e8 Ioana Ciornei 2019-05-28 1658 if (!ds->ops->phylink_mac_link_up) {
0e27921816ad99 Ioana Ciornei 2019-05-28 1659 if (ds->ops->adjust_link && phydev)
0e27921816ad99 Ioana Ciornei 2019-05-28 1660 ds->ops->adjust_link(ds, dp->index, phydev);
77373d49de22e8 Ioana Ciornei 2019-05-28 1661 return;
77373d49de22e8 Ioana Ciornei 2019-05-28 1662 }
77373d49de22e8 Ioana Ciornei 2019-05-28 1663
5b502a7b299200 Russell King 2020-02-26 @1664 ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev,
5b502a7b299200 Russell King 2020-02-26 1665 speed, duplex, tx_pause, rx_pause);
77373d49de22e8 Ioana Ciornei 2019-05-28 1666 }
77373d49de22e8 Ioana Ciornei 2019-05-28 1667
21bd64bd717ded Russell King (Oracle 2021-11-30 1668) static const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
77373d49de22e8 Ioana Ciornei 2019-05-28 1669 .validate = dsa_port_phylink_validate,
bde018222c6b08 Russell King (Oracle 2022-02-17 1670) .mac_select_pcs = dsa_port_phylink_mac_select_pcs,
d46b7e4fb06037 Russell King 2019-11-21 1671 .mac_pcs_get_state = dsa_port_phylink_mac_pcs_get_state,
77373d49de22e8 Ioana Ciornei 2019-05-28 1672 .mac_config = dsa_port_phylink_mac_config,
77373d49de22e8 Ioana Ciornei 2019-05-28 1673 .mac_an_restart = dsa_port_phylink_mac_an_restart,
77373d49de22e8 Ioana Ciornei 2019-05-28 1674 .mac_link_down = dsa_port_phylink_mac_link_down,
77373d49de22e8 Ioana Ciornei 2019-05-28 @1675 .mac_link_up = dsa_port_phylink_mac_link_up,
77373d49de22e8 Ioana Ciornei 2019-05-28 1676 };
77373d49de22e8 Ioana Ciornei 2019-05-28 1677
:::::: The code at line 1664 was first introduced by commit
:::::: 5b502a7b2992008a1fd5962ba032771b03c4e840 net: dsa: propagate resolved link config via mac_link_up()
:::::: TO: Russell King <rmk+kernel@armlinux.org.uk>
:::::: CC: David S. Miller <davem@davemloft.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-02-20 6:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302201417.2gOq9MVB-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.