From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Julien Olivain <ju.o@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali
Date: Mon, 20 Feb 2023 15:59:09 +0100 [thread overview]
Message-ID: <20230220155909.634ee802@windsurf> (raw)
In-Reply-To: <CAPi7W81cfaQ_Gk5u5sNHufCATEdrYM4Lgi2gH6hPySPwEYE=jQ@mail.gmail.com>
On Mon, 20 Feb 2023 15:23:42 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Patching rockchip-mali is probably better but I don't know what version
> number should be put inside glesv2.pc.
> Should I hardcode 2 in the pkgconfig file?
I guess whatever works for glslsandbox-player. Packages like
rockchip-mali are anyway crappy.
> Moreover, should I patch the file through a sed in buildroot or send an
> upstream patch?
> Upstreaming this change is probably impossible as rockchip-mali uses a
> commit from October 2018 and the pkgconfig is not available anymore in
> usptream master.
I suppose a patch is fine, and it won't be upstream. As said above,
those OpenGL blobs are anyway crappy :-/
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-20 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 11:24 [Buildroot] [PATCH 1/1] package/glslsandbox-player: fix build with rockchip-mali Fabrice Fontaine
2023-02-20 14:07 ` Thomas Petazzoni via buildroot
2023-02-20 14:23 ` Fabrice Fontaine
2023-02-20 14:59 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220155909.634ee802@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.