From: Josh Poimboeuf <jpoimboe@kernel.org>
To: KP Singh <kpsingh@kernel.org>
Cc: "Borislav Petkov" <bp@alien8.de>,
linux-kernel@vger.kernel.org, pjt@google.com, evn@google.com,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
peterz@infradead.org, pawan.kumar.gupta@linux.intel.com,
kim.phillips@amd.com, alexandre.chartre@oracle.com,
daniel.sneddon@linux.intel.com,
"José Oliveira" <joseloliveira11@gmail.com>,
"Rodrigo Branco" <rodrigo@kernelhacking.com>,
"Alexandra Sandulescu" <aesa@google.com>,
"Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH] x86/bugs: Allow STIBP with IBRS
Date: Mon, 20 Feb 2023 11:35:26 -0800 [thread overview]
Message-ID: <20230220193526.if5zfd6j7sbjpf7g@treble> (raw)
In-Reply-To: <CACYkzJ58HoDz+hpLzWf0PZQX7ykWqB6-uQR9HVb5YqaF-rdScA@mail.gmail.com>
On Mon, Feb 20, 2023 at 11:16:45AM -0800, KP Singh wrote:
> > As far as I can tell, that document was never updated to describe
> > spectre_v2=ibrs in the first place. That would be a whole 'nother patch
> > which I'm not volunteering for. Nice try ;-)
>
> This should at least be documented in the code.
>
> Now it seems like it is not okay to work with people on the list and
> just send revisions bypassing them. This is not something we do in the
> kernel area I come from (an x86 favorite ;)). Please feel free to go
> with Josh's version (or its future revisions). If you want me to
> re-spin with some comments, happy to. If not, please do at least give
> me Reported-by here.
It's a common practice even outside of x86. I'd recommend not taking it
personally. In the end it's all about what produces better code.
And please don't take this the wrong way, but sometimes it takes a bad
patch to inspire a better one. I mean that with no disrespect, I myself
have sent many bad patches.
And if you don't like my patch, fine, send a v2...
--
Josh
next prev parent reply other threads:[~2023-02-20 19:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 12:01 [PATCH RESEND] x86/speculation: Fix user-mode spectre-v2 protection with KERNEL_IBRS KP Singh
2023-02-20 12:13 ` Josh Poimboeuf
2023-02-20 12:20 ` KP Singh
2023-02-20 12:34 ` KP Singh
2023-02-20 14:31 ` Borislav Petkov
2023-02-20 15:38 ` Dave Hansen
2023-02-20 19:57 ` Andrew Cooper
2023-02-20 21:10 ` Borislav Petkov
2023-02-20 23:01 ` KP Singh
2023-02-20 23:30 ` Andrew Cooper
2023-02-20 23:45 ` KP Singh
2023-02-21 18:52 ` KP Singh
2023-02-21 10:59 ` Borislav Petkov
2023-02-20 16:34 ` Josh Poimboeuf
2023-02-20 17:46 ` Borislav Petkov
2023-02-20 17:59 ` Josh Poimboeuf
2023-02-20 18:01 ` KP Singh
2023-02-20 18:22 ` Borislav Petkov
2023-02-20 18:44 ` KP Singh
2023-02-20 18:51 ` Borislav Petkov
2023-02-20 18:56 ` KP Singh
2023-02-20 19:02 ` Borislav Petkov
2023-02-20 19:10 ` KP Singh
2023-02-20 18:27 ` [PATCH] x86/bugs: Allow STIBP with IBRS Josh Poimboeuf
2023-02-20 18:28 ` kernel test robot
2023-02-20 18:33 ` KP Singh
2023-02-20 18:59 ` Josh Poimboeuf
2023-02-20 19:04 ` KP Singh
2023-02-20 19:19 ` Josh Poimboeuf
2023-02-20 18:34 ` Borislav Petkov
2023-02-20 19:09 ` Josh Poimboeuf
2023-02-20 19:16 ` KP Singh
2023-02-20 19:35 ` Josh Poimboeuf [this message]
2023-02-20 19:38 ` KP Singh
2023-02-20 19:20 ` Borislav Petkov
2023-02-22 1:20 ` Pawan Gupta
2023-02-22 1:26 ` KP Singh
2023-02-22 1:38 ` Pawan Gupta
2023-02-27 19:59 ` [tip: x86/urgent] x86/speculation: Allow enabling STIBP with legacy IBRS tip-bot2 for KP Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220193526.if5zfd6j7sbjpf7g@treble \
--to=jpoimboe@kernel.org \
--cc=aesa@google.com \
--cc=alexandre.chartre@oracle.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=evn@google.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joseloliveira11@gmail.com \
--cc=kim.phillips@amd.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rodrigo@kernelhacking.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.