Re: [Buildroot] [PATCH 1/3] package/libjxl: fix build with libjpeg

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 19 Feb 2023 15:00:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Building with libjpeg will raise the following build failure on some
> architectures since the addition of the package in commit
> e648d399d8bd609697e78f13f7fa76be06d91a57:
> 
> /tmp/instance-14/output-1/build/libjxl-0.7.0/lib/extras/enc/jpg.cc: In function 'jxl::Status jxl::extras::{anonymous}::EncodeWithLibJpeg(const jxl::extras::PackedImage&, const JxlBasicInfo&, const std::vector<unsigned char>&, std::vector<unsigned char>, size_t, const string&, std::vector<unsigned char>*)':
> /tmp/instance-14/output-1/build/libjxl-0.7.0/lib/extras/enc/jpg.cc:126:34: error: invalid conversion from 'long unsigned int*' to 'size_t*' {aka 'unsigned int*'} [-fpermissive]
>   126 |   jpeg_mem_dest(&cinfo, &buffer, &size);
>       |                                  ^~~~~
>       |                                  |
>       |                                  long unsigned int*
> 
> Upstream advocates to use jpeg-turbo:
> https://github.com/libjxl/libjxl/issues/1802
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/9a2a7c6072876f2562609bf98f32a1ce93631a75
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libjxl/libjxl.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

To be honest, I find quite ugly the fact that only jpeg-turbo is
supported, but it indeed seems like libjpeg and jpeg-turbo are not 100%
compatible, unfortunately.

So: entire series applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot