From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [linux-next:master 11777/13681] drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'.
Date: Tue, 21 Feb 2023 01:20:35 +0800 [thread overview]
Message-ID: <202302210103.Ed18BExo-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Oleksij Rempel <o.rempel@pengutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: d2af0fa4bfa4ec29d03b449ccd43fee39501112d
commit: 022c3f87f88e2d68e90be7687d981c9cb893a3b1 [11777/13681] net: phy: add genphy_c45_ethtool_get/set_eee() support
:::::: branch date: 12 hours ago
:::::: commit date: 7 days ago
config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230221/202302210103.Ed18BExo-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302210103.Ed18BExo-lkp@intel.com/
smatch warnings:
drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'.
vim +/changed +712 drivers/net/phy/phy-c45.c
ea4efe25ec937a Russell King 2017-12-29 663
022c3f87f88e2d Oleksij Rempel 2023-02-11 664 /**
022c3f87f88e2d Oleksij Rempel 2023-02-11 665 * genphy_c45_write_eee_adv - write advertised EEE link modes
022c3f87f88e2d Oleksij Rempel 2023-02-11 666 * @phydev: target phy_device struct
022c3f87f88e2d Oleksij Rempel 2023-02-11 667 * @adv: the linkmode advertisement settings
022c3f87f88e2d Oleksij Rempel 2023-02-11 668 */
022c3f87f88e2d Oleksij Rempel 2023-02-11 669 int genphy_c45_write_eee_adv(struct phy_device *phydev, unsigned long *adv)
022c3f87f88e2d Oleksij Rempel 2023-02-11 670 {
022c3f87f88e2d Oleksij Rempel 2023-02-11 671 int val, changed;
022c3f87f88e2d Oleksij Rempel 2023-02-11 672
022c3f87f88e2d Oleksij Rempel 2023-02-11 673 if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {
022c3f87f88e2d Oleksij Rempel 2023-02-11 674 val = linkmode_to_mii_eee_cap1_t(adv);
022c3f87f88e2d Oleksij Rempel 2023-02-11 675
022c3f87f88e2d Oleksij Rempel 2023-02-11 676 /* In eee_broken_modes are stored MDIO_AN_EEE_ADV specific raw
022c3f87f88e2d Oleksij Rempel 2023-02-11 677 * register values.
022c3f87f88e2d Oleksij Rempel 2023-02-11 678 */
022c3f87f88e2d Oleksij Rempel 2023-02-11 679 val &= ~phydev->eee_broken_modes;
022c3f87f88e2d Oleksij Rempel 2023-02-11 680
022c3f87f88e2d Oleksij Rempel 2023-02-11 681 /* IEEE 802.3-2018 45.2.7.13 EEE advertisement 1
022c3f87f88e2d Oleksij Rempel 2023-02-11 682 * (Register 7.60)
022c3f87f88e2d Oleksij Rempel 2023-02-11 683 */
022c3f87f88e2d Oleksij Rempel 2023-02-11 684 val = phy_modify_mmd_changed(phydev, MDIO_MMD_AN,
022c3f87f88e2d Oleksij Rempel 2023-02-11 685 MDIO_AN_EEE_ADV,
022c3f87f88e2d Oleksij Rempel 2023-02-11 686 MDIO_EEE_100TX | MDIO_EEE_1000T |
022c3f87f88e2d Oleksij Rempel 2023-02-11 687 MDIO_EEE_10GT | MDIO_EEE_1000KX |
022c3f87f88e2d Oleksij Rempel 2023-02-11 688 MDIO_EEE_10GKX4 | MDIO_EEE_10GKR,
022c3f87f88e2d Oleksij Rempel 2023-02-11 689 val);
022c3f87f88e2d Oleksij Rempel 2023-02-11 690 if (val < 0)
022c3f87f88e2d Oleksij Rempel 2023-02-11 691 return val;
022c3f87f88e2d Oleksij Rempel 2023-02-11 692 if (val > 0)
022c3f87f88e2d Oleksij Rempel 2023-02-11 693 changed = 1;
022c3f87f88e2d Oleksij Rempel 2023-02-11 694 }
022c3f87f88e2d Oleksij Rempel 2023-02-11 695
022c3f87f88e2d Oleksij Rempel 2023-02-11 696 if (linkmode_test_bit(ETHTOOL_LINK_MODE_10baseT1L_Full_BIT,
022c3f87f88e2d Oleksij Rempel 2023-02-11 697 phydev->supported_eee)) {
022c3f87f88e2d Oleksij Rempel 2023-02-11 698 val = linkmode_adv_to_mii_10base_t1_t(adv);
022c3f87f88e2d Oleksij Rempel 2023-02-11 699 /* IEEE 802.3cg-2019 45.2.7.25 10BASE-T1 AN control register
022c3f87f88e2d Oleksij Rempel 2023-02-11 700 * (Register 7.526)
022c3f87f88e2d Oleksij Rempel 2023-02-11 701 */
022c3f87f88e2d Oleksij Rempel 2023-02-11 702 val = phy_modify_mmd_changed(phydev, MDIO_MMD_AN,
022c3f87f88e2d Oleksij Rempel 2023-02-11 703 MDIO_AN_10BT1_AN_CTRL,
022c3f87f88e2d Oleksij Rempel 2023-02-11 704 MDIO_AN_10BT1_AN_CTRL_ADV_EEE_T1L,
022c3f87f88e2d Oleksij Rempel 2023-02-11 705 val);
022c3f87f88e2d Oleksij Rempel 2023-02-11 706 if (val < 0)
022c3f87f88e2d Oleksij Rempel 2023-02-11 707 return val;
022c3f87f88e2d Oleksij Rempel 2023-02-11 708 if (val > 0)
022c3f87f88e2d Oleksij Rempel 2023-02-11 709 changed = 1;
022c3f87f88e2d Oleksij Rempel 2023-02-11 710 }
022c3f87f88e2d Oleksij Rempel 2023-02-11 711
022c3f87f88e2d Oleksij Rempel 2023-02-11 @712 return changed;
022c3f87f88e2d Oleksij Rempel 2023-02-11 713 }
022c3f87f88e2d Oleksij Rempel 2023-02-11 714
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-02-20 17:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302210103.Ed18BExo-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.