From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43282C61DA3 for ; Tue, 21 Feb 2023 07:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tkGiHmQdXc5FM3Ws+nDWjPOJQWPQv+uYe8De+i16v9A=; b=sXtaYbJnxE9NKUEED0n69Rr9vE V7LOA9dqb5OZWLOWcljJtt5WhZHyc4DZixA0rugoZs2nmc0bIul6dUDJcnWWm+QM4WJP0nKFltBtZ VQhVWsDamUsEUaPzBpm7nZvS7Q5AQnnHyQqjrOo1CHxos1nPUx159/5BHnKT8uqx7XtPq3UKQs6bP wr6jSSQcuVev/Jf8hFON2c52TtlP57KMIuOQYk7LfoeVFtGSVXZc3dRFvEFLOFICxMmJjPe1dUyYB /+NVj2cHu9+VzOF0zh83jpe4fcW8j/3oDSw1I70n+znNX9VGhRZt2KKtpC/djetUnkR2gnutlGp8d rMf3JooA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUN4u-006tsH-43; Tue, 21 Feb 2023 07:28:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUN4j-006tpq-Es; Tue, 21 Feb 2023 07:28:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBA3660F26; Tue, 21 Feb 2023 07:28:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FC9AC433D2; Tue, 21 Feb 2023 07:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676964512; bh=yrEXHlD+OGvdKZR47aQcY+a66pmfUFJm1C18b22BmkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pzq2UwLbV8oJcbduSvS38Q+3wATyxt1VIUgplYDzUNqQXXGRstOt80Khkd122WQPM l4c985Od9zzW8xxGcWGhxG0SXqionhv68Ig5RYURlyo2c9IumK7ZeSBu0EjlXZjH8l w3DXaIcGjFNcoNmE2z15twbFO7iYpjyAjheG7ZnY/0bEAevnDVw7oRD5H3NeLXY7WM zPHyHkvTbf5F4aXB0V0TtGnkDZ438ZTOLaDIgkkS+fyz35J8knc1NVM+JRJ5aXhjxD eA9boBX2iehs+wL7Oi7cuC6Exd0rKZK/fcTxXJZu9zxbcI1OgyF5KJAn3V+qTyMzCe ySh7RPbMuc9Fw== Date: Tue, 21 Feb 2023 12:58:22 +0530 From: Manivannan Sadhasivam To: Stephen Zhang Cc: jejb@linux.ibm.com, artin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, beanhuo@micron.com, bvanassche@acm.org, avri.altman@wdc.com, yoshihiro.shimoda.uh@renesas.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, zhangshida@kylinos.cn, k2ci Subject: Re: [PATCH v2] scsi: ufs: Guard the ufs_mtk_runtime_suspend and ufs_mtk_runtime_resume with CONFIG_PM Message-ID: <20230221072822.GA99958@thinkpad> References: <20230221025055.1031342-1-zhangshida@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230221025055.1031342-1-zhangshida@kylinos.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_232833_591945_BD8765B7 X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Feb 21, 2023 at 10:50:55AM +0800, Stephen Zhang wrote: > From: Shida Zhang > Subject could be fixed as: "scsi: ufs: mediatek: Guard runtime PM functions" > In a configuration with CONFIG_SCSI_UFS_MEDIATEK set to 'm' and > CONFIG_PM set to 'n', errors occur at compile time: > > ==== > ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_suspend’: > ../drivers/ufs/host/ufs-mediatek.c:1621:8: error: implicit declaration of function ‘ufshcd_runtime_suspend’; did you mean ‘ufs_mtk_runtime_suspend’? [-Werror=implicit-function-declaration] > ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_resume’: > ../drivers/ufs/host/ufs-mediatek.c:1636:9: error: implicit declaration of function ‘ufshcd_runtime_resume’; did you mean ‘ufs_mtk_runtime_resume’? [-Werror=implicit-function-declaration] > ==== > > This patch fixes these by guarding these functions with CONFIG_PM. > Remove reference to "patch" in the commit message as it will be meaningless once merged. The line could be reworded as, "Fix these errors by guarding the runtime PM functions with CONFIG_PM" > Reported-by: k2ci > Signed-off-by: Shida Zhang With the changes, Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > Changes in v2: > Guarding these functions with CONFIG_PM instead of selecting the config. > > drivers/ufs/host/ufs-mediatek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c > index 21d9b047539f..73e217260390 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -1613,6 +1613,7 @@ static int ufs_mtk_system_resume(struct device *dev) > } > #endif > > +#ifdef CONFIG_PM > static int ufs_mtk_runtime_suspend(struct device *dev) > { > struct ufs_hba *hba = dev_get_drvdata(dev); > @@ -1635,6 +1636,7 @@ static int ufs_mtk_runtime_resume(struct device *dev) > > return ufshcd_runtime_resume(dev); > } > +#endif > > static const struct dev_pm_ops ufs_mtk_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ufs_mtk_system_suspend, > -- > 2.27.0 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25827C6379F for ; Tue, 21 Feb 2023 07:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CSEzvjGpkuJLcdQB5Yoi6CPrBc4pdKCvGky8thWA1OE=; b=N22GCToCXVc/Pw V85lHNBHdjs6pYOo3nR3mALMX7agpUu04y4IEcM4kt/bxQkpOkiDKTV2wtTZ0rHHXrpuw9lmHBU/h rrGiiV4rQSspyJVHn+xB7b6vlJdN8bdsi8VpP1hthOlKkgkN/xH/sjyT3IgjmKSO2UsqatL29GduD y+ourdBoTy7tWrYneQ8A92uBhS/GuW8HHRAR2SUqabmqZpQ5VAn9d1awsnem7myGQa3Ler7C19S2L Li9BtAFvkVAHFclQyWeb8epWzfdWZIzLezXCItfzOqdJQfW8NvquJW2GbCfq1ub4ntixvOIDfk0wt ygQOXg6jCoZpLwf4uSMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUN4n-006tqO-0R; Tue, 21 Feb 2023 07:28:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUN4j-006tpq-Es; Tue, 21 Feb 2023 07:28:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBA3660F26; Tue, 21 Feb 2023 07:28:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FC9AC433D2; Tue, 21 Feb 2023 07:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676964512; bh=yrEXHlD+OGvdKZR47aQcY+a66pmfUFJm1C18b22BmkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pzq2UwLbV8oJcbduSvS38Q+3wATyxt1VIUgplYDzUNqQXXGRstOt80Khkd122WQPM l4c985Od9zzW8xxGcWGhxG0SXqionhv68Ig5RYURlyo2c9IumK7ZeSBu0EjlXZjH8l w3DXaIcGjFNcoNmE2z15twbFO7iYpjyAjheG7ZnY/0bEAevnDVw7oRD5H3NeLXY7WM zPHyHkvTbf5F4aXB0V0TtGnkDZ438ZTOLaDIgkkS+fyz35J8knc1NVM+JRJ5aXhjxD eA9boBX2iehs+wL7Oi7cuC6Exd0rKZK/fcTxXJZu9zxbcI1OgyF5KJAn3V+qTyMzCe ySh7RPbMuc9Fw== Date: Tue, 21 Feb 2023 12:58:22 +0530 From: Manivannan Sadhasivam To: Stephen Zhang Cc: jejb@linux.ibm.com, artin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, beanhuo@micron.com, bvanassche@acm.org, avri.altman@wdc.com, yoshihiro.shimoda.uh@renesas.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, zhangshida@kylinos.cn, k2ci Subject: Re: [PATCH v2] scsi: ufs: Guard the ufs_mtk_runtime_suspend and ufs_mtk_runtime_resume with CONFIG_PM Message-ID: <20230221072822.GA99958@thinkpad> References: <20230221025055.1031342-1-zhangshida@kylinos.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230221025055.1031342-1-zhangshida@kylinos.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_232833_591945_BD8765B7 X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjEsIDIwMjMgYXQgMTA6NTA6NTVBTSArMDgwMCwgU3RlcGhlbiBaaGFuZyB3 cm90ZToKPiBGcm9tOiBTaGlkYSBaaGFuZyA8emhhbmdzaGlkYUBreWxpbm9zLmNuPgo+IAoKU3Vi amVjdCBjb3VsZCBiZSBmaXhlZCBhczoKCiJzY3NpOiB1ZnM6IG1lZGlhdGVrOiBHdWFyZCBydW50 aW1lIFBNIGZ1bmN0aW9ucyIKCj4gSW4gYSBjb25maWd1cmF0aW9uIHdpdGggQ09ORklHX1NDU0lf VUZTX01FRElBVEVLIHNldCB0byAnbScgYW5kCj4gQ09ORklHX1BNIHNldCB0byAnbicsIGVycm9y cyBvY2N1ciBhdCBjb21waWxlIHRpbWU6Cj4gCj4gPT09PQo+IC4uL2RyaXZlcnMvdWZzL2hvc3Qv dWZzLW1lZGlhdGVrLmM6IEluIGZ1bmN0aW9uIOKAmHVmc19tdGtfcnVudGltZV9zdXNwZW5k4oCZ Ogo+IC4uL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmM6MTYyMTo4OiBlcnJvcjogaW1w bGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYdWZzaGNkX3J1bnRpbWVfc3VzcGVuZOKA mTsgZGlkIHlvdSBtZWFuIOKAmHVmc19tdGtfcnVudGltZV9zdXNwZW5k4oCZPyBbLVdlcnJvcj1p bXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlvbl0KPiAuLi9kcml2ZXJzL3Vmcy9ob3N0L3Vmcy1t ZWRpYXRlay5jOiBJbiBmdW5jdGlvbiDigJh1ZnNfbXRrX3J1bnRpbWVfcmVzdW1l4oCZOgo+IC4u L2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmM6MTYzNjo5OiBlcnJvcjogaW1wbGljaXQg ZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYdWZzaGNkX3J1bnRpbWVfcmVzdW1l4oCZOyBkaWQg eW91IG1lYW4g4oCYdWZzX210a19ydW50aW1lX3Jlc3VtZeKAmT8gWy1XZXJyb3I9aW1wbGljaXQt ZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gPT09PQo+IAo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhlc2Ug YnkgZ3VhcmRpbmcgdGhlc2UgZnVuY3Rpb25zIHdpdGggQ09ORklHX1BNLgo+IAoKUmVtb3ZlIHJl ZmVyZW5jZSB0byAicGF0Y2giIGluIHRoZSBjb21taXQgbWVzc2FnZSBhcyBpdCB3aWxsIGJlIG1l YW5pbmdsZXNzCm9uY2UgbWVyZ2VkLiBUaGUgbGluZSBjb3VsZCBiZSByZXdvcmRlZCBhcywKCiJG aXggdGhlc2UgZXJyb3JzIGJ5IGd1YXJkaW5nIHRoZSBydW50aW1lIFBNIGZ1bmN0aW9ucyB3aXRo IENPTkZJR19QTSIKCj4gUmVwb3J0ZWQtYnk6IGsyY2kgPGtlcm5lbC1ib3RAa3lsaW5vcy5jbj4K PiBTaWduZWQtb2ZmLWJ5OiBTaGlkYSBaaGFuZyA8emhhbmdzaGlkYUBreWxpbm9zLmNuPgoKV2l0 aCB0aGUgY2hhbmdlcywKClJldmlld2VkLWJ5OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbmlA a2VybmVsLm9yZz4KClRoYW5rcywKTWFuaQoKPiAtLS0KPiBDaGFuZ2VzIGluIHYyOgo+ICAgR3Vh cmRpbmcgdGhlc2UgZnVuY3Rpb25zIHdpdGggQ09ORklHX1BNIGluc3RlYWQgb2Ygc2VsZWN0aW5n IHRoZSBjb25maWcuCj4gCj4gIGRyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmMgfCAyICsr Cj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy91ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYyBiL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlh dGVrLmMKPiBpbmRleCAyMWQ5YjA0NzUzOWYuLjczZTIxNzI2MDM5MCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jCj4gKysrIGIvZHJpdmVycy91ZnMvaG9zdC91 ZnMtbWVkaWF0ZWsuYwo+IEBAIC0xNjEzLDYgKzE2MTMsNyBAQCBzdGF0aWMgaW50IHVmc19tdGtf c3lzdGVtX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIH0KPiAgI2VuZGlmCj4gIAo+ICsj aWZkZWYgQ09ORklHX1BNCj4gIHN0YXRpYyBpbnQgdWZzX210a19ydW50aW1lX3N1c3BlbmQoc3Ry dWN0IGRldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgdWZzX2hiYSAqaGJhID0gZGV2X2dldF9k cnZkYXRhKGRldik7Cj4gQEAgLTE2MzUsNiArMTYzNiw3IEBAIHN0YXRpYyBpbnQgdWZzX210a19y dW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAo+ICAJcmV0dXJuIHVmc2hjZF9y dW50aW1lX3Jlc3VtZShkZXYpOwo+ICB9Cj4gKyNlbmRpZgo+ICAKPiAgc3RhdGljIGNvbnN0IHN0 cnVjdCBkZXZfcG1fb3BzIHVmc19tdGtfcG1fb3BzID0gewo+ICAJU0VUX1NZU1RFTV9TTEVFUF9Q TV9PUFModWZzX210a19zeXN0ZW1fc3VzcGVuZCwKPiAtLSAKPiAyLjI3LjAKPiAKCi0tIArgrq7g rqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==