All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	Robert Rose <robertroyrose@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/grpc: bump to version 1.52.1
Date: Tue, 21 Feb 2023 09:28:21 +0100	[thread overview]
Message-ID: <20230221092821.2f227afc@windsurf> (raw)
In-Reply-To: <20230220124945.1842532-1-buildroot@heine.tech>

Hello Michael,

Thanks for the new iteration!

On Mon, 20 Feb 2023 13:49:45 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> +comment "grpc needs a toolchain w/ C++, gcc >= 7.3"

It's a bit annoying that it depends on gcc >= 7.3 and not gcc >= 7,
because technically BR2_TOOLCHAIN_GCC_AT_LEAST_7 only implies >= 7.x,
and not >= 7.3.

Did you check what happens with gcc 7.0, 7.1 or 7.2 ?

https://toolchains.bootlin.com/downloads/releases/toolchains/armv7-eabihf/tarballs/armv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2
uses gcc 7.2.0 for example. Here is a fragment to use it:
https://toolchains.bootlin.com/downloads/releases/toolchains/armv7-eabihf/fragments/armv7-eabihf--glibc--bleeding-edge-2017.11-1.frag.

I don't easily find a toolchain with gcc 7.0 or 7.1 unfortunately.

Worst case, we could make this dependency >= 8.0.

But clearly, a comment that says >= 7.3, but with a dependency on
BR2_TOOLCHAIN_GCC_AT_LEAST_7 is going to be very misleading.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-02-21  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 12:49 [Buildroot] [PATCH] package/grpc: bump to version 1.52.1 Michael Nosthoff via buildroot
2023-02-21  8:28 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221092821.2f227afc@windsurf \
    --to=buildroot@buildroot.org \
    --cc=angelo.compagnucci@gmail.com \
    --cc=asafka7@gmail.com \
    --cc=robertroyrose@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.