From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F33AC61DA3 for ; Tue, 21 Feb 2023 19:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q2a+P1//fyWJeCinFlVMtmjGSaSuq13qe72m+ZhqDcc=; b=kYzrJI3VRnK9WE ccVCvm+YpL+OcHlVe9dffZaIkpYOhTZZxZTh7lwjutejEmVDMtwbMw/xh6a1lvjxIwrhx1LIgUPuG lHvkpYKwTMbrHSJMb9frgKELbWAqdi/M2EfkpJLss707+JvWJ/s/LQre5c3GRLAbuk5cZ6h4UfYT6 s8lVUwriLIr6LogrGgVHOqX4l/iELJOrCwdNqTaHnaRiR8K20zFDKz4TeXhccXJadrSvGG3unVevc wm2Q4PXe76YRccaw9BYobw8gdK+LdgvJp3ObiLxuGe274BX72eq5FIMvWhQiywjxJIqYXgb63bIBb gVxS5Sj+IGL7auDm/71A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUYVe-009ZNT-Js; Tue, 21 Feb 2023 19:41:06 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUYVZ-009ZMN-VL for linux-arm-kernel@lists.infradead.org; Tue, 21 Feb 2023 19:41:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 65D5C611B2; Tue, 21 Feb 2023 19:41:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51C8AC433EF; Tue, 21 Feb 2023 19:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677008459; bh=eYLLW5S3Lj0DfJGoQXiq8cvFhX8POKnoMCP9k1pGSvs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eVb89wVeLoZIphCUnqK8cj8jMop3IR9+3QChT71az41oS9ofu5w/z/BkhbiJ4e303 +rCySsaZGqAYdNOQ3BwDDH9e0AILMmJ8DSWJdtOAuEtTxEccsDeTEsv8sw/xUrTo5N TbvBt1+87H7HA4Yfzdd0gML+HB9zjyNGwY6jXB7hMkXD/AZ4E+YeEDJciKjEYG7cVV Y6MU89pWb9X6LAV5kZ7dTkAQlVAw53c4tP8bLlw0WRocTDX/Dp5YZnj244mWnaQwG2 6qz7y67AuafRORCs6QX6ukbx5mCiFI6T5zrp5dYpRo7V59ftuNf7gPPiAmZoZ9BtpA yOC8V2od/uikQ== Date: Tue, 21 Feb 2023 11:40:58 -0800 From: Jakub Kicinski To: Jochen Henneberg Cc: Simon Horman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net V2] net: stmmac: Premature loop termination check was ignored Message-ID: <20230221114058.5775664d@kernel.org> In-Reply-To: <877cwa7qtm.fsf@henneberg-systemdesign.com> References: <87fsaz6smr.fsf@henneberg-systemdesign.com> <877cwa7qtm.fsf@henneberg-systemdesign.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230221_114102_096508_B423369A X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 21 Feb 2023 20:35:25 +0100 Jochen Henneberg wrote: > The premature loop termination check makes sense only in case of the > jump to read_again where the count may have been updated. But > read_again did not include the check. > > Fixes: bba2556efad6 (net: stmmac: Enable RX via AF_XDP zero-copy) > Fixes: ec222003bd94 (net: stmmac: Prepare to add Split Header support) > Signed-off-by: Jochen Henneberg Please repost separately, not as a reply. Patch tracking utilities will categorize emails with Re in the subject as comments rather than submissions. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86160C636D7 for ; Tue, 21 Feb 2023 19:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbjBUTlM (ORCPT ); Tue, 21 Feb 2023 14:41:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbjBUTlI (ORCPT ); Tue, 21 Feb 2023 14:41:08 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D764E2E80C; Tue, 21 Feb 2023 11:41:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D339611B3; Tue, 21 Feb 2023 19:41:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51C8AC433EF; Tue, 21 Feb 2023 19:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677008459; bh=eYLLW5S3Lj0DfJGoQXiq8cvFhX8POKnoMCP9k1pGSvs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eVb89wVeLoZIphCUnqK8cj8jMop3IR9+3QChT71az41oS9ofu5w/z/BkhbiJ4e303 +rCySsaZGqAYdNOQ3BwDDH9e0AILMmJ8DSWJdtOAuEtTxEccsDeTEsv8sw/xUrTo5N TbvBt1+87H7HA4Yfzdd0gML+HB9zjyNGwY6jXB7hMkXD/AZ4E+YeEDJciKjEYG7cVV Y6MU89pWb9X6LAV5kZ7dTkAQlVAw53c4tP8bLlw0WRocTDX/Dp5YZnj244mWnaQwG2 6qz7y67AuafRORCs6QX6ukbx5mCiFI6T5zrp5dYpRo7V59ftuNf7gPPiAmZoZ9BtpA yOC8V2od/uikQ== Date: Tue, 21 Feb 2023 11:40:58 -0800 From: Jakub Kicinski To: Jochen Henneberg Cc: Simon Horman , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net V2] net: stmmac: Premature loop termination check was ignored Message-ID: <20230221114058.5775664d@kernel.org> In-Reply-To: <877cwa7qtm.fsf@henneberg-systemdesign.com> References: <87fsaz6smr.fsf@henneberg-systemdesign.com> <877cwa7qtm.fsf@henneberg-systemdesign.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Feb 2023 20:35:25 +0100 Jochen Henneberg wrote: > The premature loop termination check makes sense only in case of the > jump to read_again where the count may have been updated. But > read_again did not include the check. > > Fixes: bba2556efad6 (net: stmmac: Enable RX via AF_XDP zero-copy) > Fixes: ec222003bd94 (net: stmmac: Prepare to add Split Header support) > Signed-off-by: Jochen Henneberg Please repost separately, not as a reply. Patch tracking utilities will categorize emails with Re in the subject as comments rather than submissions.