From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <wqu@suse.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 02/12] btrfs: remove a bogus submit_one_bio call in read_extent_buffer_subpage
Date: Tue, 21 Feb 2023 15:31:21 +0100 [thread overview]
Message-ID: <20230221143121.GB29949@lst.de> (raw)
In-Reply-To: <6754b78a-ee58-9054-1494-335f062dd620@suse.com>
On Tue, Feb 21, 2023 at 07:14:09PM +0800, Qu Wenruo wrote:
>
>
> On 2023/2/17 00:34, Christoph Hellwig wrote:
>> The first call to submit_one_bio call in read_extent_buffer_subpage is
>> for a btrfs_bio_ctrl structure that has just been initialized and thus
>> can't have a non-NULL bio, so remove it.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> This new submit_one_bio() is mostly caused by the previous patch.
>
> Can we just fold this one into the previous patch?
I don't think mixing a change in behavior (even if it is a no-op
for the I/O pattern) into a pure refactoring is a good idea. I've
been arguing about doing this patch first before patch 1 as I've
been expecting this argument, but the current order seems more
obvious to review. I could switch it around if strongly preferred.
next prev parent reply other threads:[~2023-02-21 14:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 16:34 cleanup submit_extent_page and friends Christoph Hellwig
2023-02-16 16:34 ` [PATCH 01/12] btrfs: remove the force_bio_submit to submit_extent_page Christoph Hellwig
2023-02-20 9:43 ` Johannes Thumshirn
2023-02-21 11:15 ` Qu Wenruo
2023-02-16 16:34 ` [PATCH 02/12] btrfs: remove a bogus submit_one_bio call in read_extent_buffer_subpage Christoph Hellwig
2023-02-20 9:45 ` Johannes Thumshirn
2023-02-21 11:14 ` Qu Wenruo
2023-02-21 14:31 ` Christoph Hellwig [this message]
2023-02-16 16:34 ` [PATCH 03/12] btrfs: store the bio opf in struct btrfs_bio_ctrl Christoph Hellwig
2023-02-20 9:52 ` Johannes Thumshirn
2023-02-21 11:17 ` Qu Wenruo
2023-02-16 16:34 ` [PATCH 04/12] btrfs: remove the sync_io flag " Christoph Hellwig
2023-02-20 9:54 ` Johannes Thumshirn
2023-02-16 16:34 ` [PATCH 05/12] btrfs: add a wbc pointer to " Christoph Hellwig
2023-02-20 9:59 ` Johannes Thumshirn
2023-02-21 11:18 ` Qu Wenruo
2023-02-21 14:31 ` Christoph Hellwig
2023-02-16 16:34 ` [PATCH 06/12] btrfs: move the compress_type check out of btrfs_bio_add_page Christoph Hellwig
2023-02-17 12:04 ` Johannes Thumshirn
2023-02-16 16:34 ` [PATCH 07/12] btrfs: rename the this_bio_flag variable in btrfs_do_readpage Christoph Hellwig
2023-02-20 11:39 ` Johannes Thumshirn
2023-02-21 11:21 ` Qu Wenruo
2023-02-16 16:34 ` [PATCH 08/12] btrfs: remove the compress_type argument to submit_extent_page Christoph Hellwig
2023-02-20 11:58 ` Johannes Thumshirn
2023-02-21 11:32 ` Qu Wenruo
2023-02-21 14:34 ` Christoph Hellwig
2023-02-16 16:34 ` [PATCH 09/12] btrfs: remove the submit_extent_page return value Christoph Hellwig
2023-02-20 12:12 ` Johannes Thumshirn
2023-02-16 16:34 ` [PATCH 10/12] btrfs: simplify the error handling in __extent_writepage_io Christoph Hellwig
2023-02-20 12:16 ` Johannes Thumshirn
2023-02-16 16:34 ` [PATCH 11/12] btrfs: check for contiguity in submit_extent_page Christoph Hellwig
2023-02-21 13:03 ` Johannes Thumshirn
2023-02-16 16:34 ` [PATCH 12/12] btrfs: simplify submit_extent_page Christoph Hellwig
2023-02-21 13:14 ` Johannes Thumshirn
2023-02-21 14:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221143121.GB29949@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.