From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D19C636D7 for ; Tue, 21 Feb 2023 18:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbjBUSiY (ORCPT ); Tue, 21 Feb 2023 13:38:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbjBUSiT (ORCPT ); Tue, 21 Feb 2023 13:38:19 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC54B17CDA for ; Tue, 21 Feb 2023 10:38:16 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1pUXWn-0001Sk-Tj; Tue, 21 Feb 2023 19:38:13 +0100 Date: Tue, 21 Feb 2023 19:38:13 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH] netlink_delinearize: Sanitize concat data element decoding Message-ID: <20230221183813.GD12484@breakpoint.cc> References: <20230221182133.11746-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230221182133.11746-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > The call to netlink_get_register() might return NULL, catch this before > dereferencing the pointer. > > Fixes: db59a5c1204c9 ("netlink_delinearize: fix decoding of concat data element") Acked-by: Florian Westphal